You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Thread - Unable to send a reply in thread after leaving the thread in offline mode #34424
Version Number: Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Slack conversation:
Action Performed:
Go to workspace chat
Go offline.
Send a message and reply in thread.
Leave the thread.
Open the thread and send a reply again.
Expected Result:
User is able to send a reply in thread after leaving the thread in offline mode.
Actual Result:
User is unable to send a reply in thread after leaving the thread in offline mode.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Thread - Unable to send a reply in thread after leaving the thread in offline mode[/-][+][$500] Thread - Unable to send a reply in thread after leaving the thread in offline mode[/+]on Jan 12, 2024
Please re-state the problem that we are trying to solve in this issue.
User is unable to send a reply in thread after leaving the thread in offline mode.
What is the root cause of that problem?
After leaving thread, we will delete the report along with report actions, that why if users want to visit again, we have to load it from BE -> In offline mode we just can see the loading page
What changes do you think we should make in order to solve the problem?
We should not delete the thread report/ report action after leaving thread, we just need to update the notification preference to not receive the notification.
Activity
[-]Thread - Unable to send a reply in thread after leaving the thread in offline mode[/-][+][$500] Thread - Unable to send a reply in thread after leaving the thread in offline mode[/+]melvin-bot commentedon Jan 12, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0190e8891c6eb5ad7c
melvin-bot commentedon Jan 12, 2024
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jan 12, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)tienifr commentedon Jan 12, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
User is unable to send a reply in thread after leaving the thread in offline mode.
What is the root cause of that problem?
After leaving thread, we will delete the report along with report actions, that why if users want to visit again, we have to load it from BE -> In offline mode we just can see the loading page
What changes do you think we should make in order to solve the problem?
We should not delete the thread report/ report action after leaving thread, we just need to update the notification preference to not receive the notification.
In
leaveRoomfunction:we need to update successfulData as well.
Then navigate to the previous chat.
What alternative solutions did you explore? (Optional)
NA
Result
Screen.Recording.2024-01-12.at.17.29.59.mov
Tony-MK commentedon Jan 15, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Thread - Unable to send a reply inside of a thread after leaving the thread in offline mode
What is the root cause of that problem?
The
canLeaveRoomfunction is used in theHeaderViewcomponent to display the leave room menu option.App/src/pages/home/HeaderView.js
Lines 166 to 171 in a2864a0
I believe solely using
isWorkspaceMemberLeavingWorkspaceRoomto create a condition in theleaveRoomfunction for this PR #33053 was not a good idea.App/src/libs/actions/Report.ts
Lines 2092 to 2097 in f268c39
This is because PR removes the
report.ReportIDfrom the onyx ifisWorkspaceMemberLeavingWorkspaceRoomisfalse.Hence, threads are also affected.
App/src/pages/home/ReportScreen.js
Lines 250 to 251 in a2864a0
Therefore,
isReportReadyForDisplaywill always befalse, and theReportScreenwill load infinitely.App/src/pages/home/ReportScreen.js
Lines 517 to 518 in a2864a0
It is just not displaying the
ReportActionsViewcomponent.Finally, the user can not reply because of the
ReportFootercomponent over here.What changes do you think we should make in order to solve the problem?
Part 1
We will use the
isChatThreadfunction with theisWorkspaceMemberLeavingWorkspaceRoomvariable to create a better condition.App/src/libs/actions/Report.ts
Line 2092 in f268c39
Modify the above condition to something similar to the one below:
App/src/libs/actions/Report.ts
Lines 2152 to 2154 in f268c39
Part 2
Finally, we create a new condition after
API.writeshown above.It will navigate the user back to the parent report.
Question
Is the navigating back part not supposed to happen for threads? 🤔
I added part 2 in case it was needed.
Result (macOS - Chrome)
296661827-ba321858-6fd0-49de-8e87-2ecb0eda39ae.mov
joekaufmanexpensify commentedon Jan 15, 2024
Pending proposal reviews from @thesahindia
60 remaining items
tienifr commentedon Mar 1, 2024
joekaufmanexpensify commentedon Mar 4, 2024
Got it. I'll take a look.
joekaufmanexpensify commentedon Mar 5, 2024
Discussing
joekaufmanexpensify commentedon Mar 6, 2024
We discussed and landed on the following:
joekaufmanexpensify commentedon Mar 6, 2024
@tienifr $500 sent and contract ended!
joekaufmanexpensify commentedon Mar 6, 2024
@mollfpr please accept our offer so we can pay you.
joekaufmanexpensify commentedon Mar 6, 2024
I'm OOO the next two days, so we'll issue payment to @mollfpr on Monday (once you accept the offer).
mollfpr commentedon Mar 7, 2024
Sorry for the late reply @joekaufmanexpensify I did manual request in NewDot.
joekaufmanexpensify commentedon Mar 11, 2024
Ah, all good. I canceled the offer in upwork, and updated my post above to clarify that you're being paid via NewDot.
joekaufmanexpensify commentedon Mar 11, 2024
Payment summary is here.
joekaufmanexpensify commentedon Mar 11, 2024
All set!
JmillsExpensify commentedon Mar 12, 2024
$250 approved for @mollfpr based on this summary.