Skip to content

Deploy Checklist: Expensify.cash 2021-06-08 #3450

Closed

Description

@OSBotify

Release Version: 1.0.68-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

cc @Expensify/applauseleads

Activity

  1. isagoico commented on Jun 9, 2021

    @isagoico

    Starting QA

  2. isagoico commented on Jun 9, 2021

    @isagoico

    Should I check these off #3456 and #3445 and test them when the prod build is deployed? CC @AndrewGable @roryabraham

  3. roryabraham commented on Jun 9, 2021

    @roryabraham
    Contributor

    Should I check these off #3456 and #3445 and test them when the prod build is deployed?

    Yep! Just ping us before you run the next prod deploy and we'll verify that it worked. No worries, it's unlikely those PRs will break android prod deploys any more than they're already broken.

  4. isagoico commented on Jun 10, 2021

    @isagoico

    @roryabraham haven't added the DB label yet since there haven't been any changes

  5. roryabraham commented on Jun 10, 2021

    @roryabraham
    Contributor

    @isagoico I'm investigating why there haven't been any changes here – there have been PRs merged since this was unlocked, which should update this issue.

  6. isagoico commented on Jun 10, 2021

    @isagoico

    Oh y yeah I found it really weird that no changes were disolayed. Let me know when we can start QA.

  7. roryabraham commented on Jun 10, 2021

    @roryabraham
    Contributor

    Looks like CP's may have broken the normal deploy workflow in an unexpected way – this version-bump PR includes changes that it should not, and has merge conflicts in the normal version-bump files

  8. stitesExpensify commented on Jun 10, 2021

    @stitesExpensify
    Contributor

    Checking off #3512 in the deploy blocker section, we're not going to block on it.

  9. roryabraham commented on Jun 10, 2021

    @roryabraham
    Contributor

    Okay, staging deploys are fixed now, but I'm going to have to manually update the checklist. It's missing PRs, but I have a PR here that should make it more robust and self-correcting in the future.

  10. isagoico commented on Jun 10, 2021

    @isagoico

    Starting QA

  11. 13 remaining items

  12. roryabraham commented on Jun 11, 2021

    @roryabraham
    Contributor

    #3550 is being CP'd to staging, should fix #3543 in 1.0.68-1 🤞

    Staging deploy happening here

  13. roryabraham commented on Jun 11, 2021

    @roryabraham
    Contributor

    CP'ing #3535 to staging: should fix #3488 and #3536 in 1.0.68-3 🤞

  14. isagoico commented on Jun 12, 2021

    @isagoico

    Regression is finished!
    1 issue found today:

    1. Web - IOU - Previously used currency appears for a brief moment for request/ split money #3560

    PRs are finished too
    No comments added 🎉

    Thanks!

  15. isagoico commented on Jun 12, 2021

    @isagoico

    #3510 checked off, will be worked on a separate issue

    #3215 links are opening in a different tab now so it's a pass 🎉

  16. isagoico commented on Jun 12, 2021

    @isagoico

    @roryabraham: While re testing the deploy blockers we were able to reproduce this issue:

    1. When signing into an account after signing out, you are brought to /r/ instead of a chat #3559

    #3536 and #3488 were a pass. For #3543 I'm waiting for someone with iOS to check it since I don't have my iOS on my atm.

  17. isagoico commented on Jun 12, 2021

    @isagoico

    #3543 is still reproducible, reopening the issue.

  18. Julesssss commented on Jun 14, 2021

    @Julesssss
    Contributor

    Marked #3423 as resolved, as the raised issues were fixed and merged.

  19. Julesssss commented on Jun 14, 2021

    @Julesssss
    Contributor

    I removed #3215 from being a deployBlocker, as this comment proves it did not introduce the iOS attachment regression.

  20. Julesssss commented on Jun 15, 2021

    @Julesssss
    Contributor

    @isagoico I am happy to confirm all deployBlockers have been resolved

  21. isagoico commented on Jun 15, 2021

    @isagoico

    That's great news 🎉 are you guys gonna try a production deploy?

  22. roryabraham commented on Jun 15, 2021

    @roryabraham
    Contributor

    I think so ... pending the 👍 from @trjExpensify

  23. trjExpensify commented on Jun 15, 2021

    @trjExpensify
    Contributor

    Yep, let's do it! 👍

  24. Julesssss commented on Jun 15, 2021

    @Julesssss
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions