Repository navigation
Closed
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.0.68-4
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Upgrade react-navigation to 6.x #3078
- See extra fields per chat #3095
- Bump react-native-web to 0.15.7 react to 17.0.2 #3215
- [No QA] Improved permission checking #3321
- File upload failure checking #3332
- [IS-3186] Fixed cursor position issue on Android #3374
- Update merge-deep per SNYK-JS-MERGEDEEP-1070277 #3409
- iOS - Plus green button isn't announced via Voiceover #3415
- fixed edited flag is shown for brief moment #3421
- Update react-native-onyx with the latest version #3423
- Fix regression with default option selection #3426
- [IS-3218] Fixed cursor issue on edit comment box #3434
- Apply localization to all hard coded text in the Expensify.cash app #3435
- Rename AddBankAccountPage to AddPersonalBankAccountPage #3443
- Use
VERSION_CODEinstead ofVERSION#3445 - Update react-native for SNYK vulnerability #3446
- Fix versionCode regex to work on ubuntu #3456
- Add VBA flow Part 1 #3459
- Update Permissions logic to fix IOU regression #3481
- [NO-QA] Bump Onyx commit to fix IOU regression #3483
- Use hrefAttrs for links #3486
- [No QA] Single brackets not double brackets #3491
- [No QA] Push changes before trying to create CP branch #3493
- Fix line breaks in homepage links #3502
- Upgrade the urbanairship-react-native package #3508
- [IS-3218] Fixed cursor issue #3510
- Quit early when persistedRequests is empty #3511
- Remove Geolocation library for initial IOU release #3514
- [NO QA] Urgent Fix: Missed passing a parameter to NewchatOptions #3517
- [No QA] Update staging,prod from a separate branch to auto-resolve conflicts #3521
- #3102 add es translation for close #3525
- [No QA] Add committer name #3529
- Make tapping the entire IOU preview component open the IOU Details modal #3541
- Upgrade react-native-document-picker to 5.1.0 #3550
- Add capturing event listeners to the KeyboardShortcut library #3555
- fix: Document Picker crash on IOS #3581
Deploy Blockers:
- Bump react-native-web to 0.15.7 react to 17.0.2 #3215
- [No QA] Improved permission checking #3321
- Update react-native-onyx with the latest version #3423
- [IS-3218] Fixed cursor issue on edit comment box #3434
- IOU - Currencies are not displayed after clicking the currency symbol for a second time #3482
- iOS - App crashes after turning off the internet connection #3485
- Web/mWeb- Sign in - Endless loading spinner appears when re login #3488
- Android - App crashes when logging out #3503
- CMD + K is not working when the focus is on compose box #3512
- App freezes after reopening it from background after a while #3536
- Push Notification not received if app is backgrounded #3542
- [HOLD for payment 21 June] iOS - Attachment picker flickers and unable to select for choose document #3543
- Tapping on Edit Message scrolls down to the bottom to the compose box #3545
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
isagoico commentedon Jun 9, 2021
Starting QA
isagoico commentedon Jun 9, 2021
Should I check these off #3456 and #3445 and test them when the prod build is deployed? CC @AndrewGable @roryabraham
roryabraham commentedon Jun 9, 2021
Yep! Just ping us before you run the next prod deploy and we'll verify that it worked. No worries, it's unlikely those PRs will break android prod deploys any more than they're already broken.
isagoico commentedon Jun 9, 2021
Regression is finished
3 issues found:
PRs are finished.
2 comments added:
Thanks!
isagoico commentedon Jun 10, 2021
@roryabraham haven't added the DB label yet since there haven't been any changes
roryabraham commentedon Jun 10, 2021
@isagoico I'm investigating why there haven't been any changes here – there have been PRs merged since this was unlocked, which should update this issue.
isagoico commentedon Jun 10, 2021
Oh y yeah I found it really weird that no changes were disolayed. Let me know when we can start QA.
roryabraham commentedon Jun 10, 2021
Looks like CP's may have broken the normal deploy workflow in an unexpected way – this version-bump PR includes changes that it should not, and has merge conflicts in the normal version-bump files
stitesExpensify commentedon Jun 10, 2021
Checking off #3512 in the deploy blocker section, we're not going to block on it.
roryabraham commentedon Jun 10, 2021
Okay, staging deploys are fixed now, but I'm going to have to manually update the checklist. It's missing PRs, but I have a PR here that should make it more robust and self-correcting in the future.
isagoico commentedon Jun 10, 2021
Starting QA
13 remaining items
roryabraham commentedon Jun 11, 2021
#3550 is being CP'd to staging, should fix #3543 in
1.0.68-1🤞Staging deploy happening here
roryabraham commentedon Jun 11, 2021
CP'ing #3535 to staging: should fix #3488 and #3536 in
1.0.68-3🤞roryabraham commentedon Jun 11, 2021
Build for
1.0.63-3is running here ... @isagoico when it's done can you please have your testers retest:🙏
isagoico commentedon Jun 12, 2021
Regression is finished!
1 issue found today:
PRs are finished too
No comments added 🎉
Thanks!
isagoico commentedon Jun 12, 2021
#3510 checked off, will be worked on a separate issue
#3215 links are opening in a different tab now so it's a pass 🎉
isagoico commentedon Jun 12, 2021
@roryabraham: While re testing the deploy blockers we were able to reproduce this issue:
#3536 and #3488 were a pass. For #3543 I'm waiting for someone with iOS to check it since I don't have my iOS on my atm.
isagoico commentedon Jun 12, 2021
#3543 is still reproducible, reopening the issue.
Julesssss commentedon Jun 14, 2021
Marked #3423 as resolved, as the raised issues were fixed and merged.
Julesssss commentedon Jun 14, 2021
I removed #3215 from being a deployBlocker, as this comment proves it did not introduce the iOS attachment regression.
Julesssss commentedon Jun 15, 2021
@isagoico I am happy to confirm all deployBlockers have been resolved
isagoico commentedon Jun 15, 2021
That's great news 🎉 are you guys gonna try a production deploy?
roryabraham commentedon Jun 15, 2021
I think so ... pending the 👍 from @trjExpensify
trjExpensify commentedon Jun 15, 2021
Yep, let's do it! 👍
Julesssss commentedon Jun 15, 2021