You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for Payment 2024-05-29] [HIGH] [Groups] Frontend: Migrate off of participantAccountIDs to participants format in the front end #34692
As part of the Group Chats design doc we are migrating all report.participantAccountIDs to report.participants with a new data structure that can be used to show:
all participants of a report
whether they are "visible" or not
what their role in the chat is i.e. 'admin'|'member'
The general roll out of this should be as follows:
The backend will start by sending both data structures
The App will be updated to never use the deprecated one
We will also need an Onyx migration to create the new participants object for all reports.
After merging the App PR and deploying it we will force all production app versions to switch to the latest (Internal engineer will coordinate this once the native apps are deployed to production)
We can then stop sending the deprecated data structures report.participants (old version where it is an array of emails), report.participantAccountIDs & report.visibleChatMemberAccountIDs
changed the title [-][HOLD] Frontend: Migrate off of `participantAccountIDs` to `participants` format in the front end[/-][+][HOLD] [MEDIUM] Frontend: Migrate off of `participantAccountIDs` to `participants` format in the front end[/+]on Jan 19, 2024
changed the title [-][HOLD] [MEDIUM] Frontend: Migrate off of `participantAccountIDs` to `participants` format in the front end[/-][+][HOLD] [CRITICAL] [Groups] Frontend: Migrate off of `participantAccountIDs` to `participants` format in the front end[/+]on Feb 22, 2024
@arielgreen this one would be good to get a contributor to work on. Perhaps someone with experience working on performance or typescript refactors as the changes will be a little surgical and quite large.
Similar to other issues - we can technically launch without this and the feature will be the same for users (but it should be done).
changed the title [-][HOLD] [CRITICAL] [Groups] Frontend: Migrate off of `participantAccountIDs` to `participants` format in the front end[/-][+][HOLD] [HIGH] [Groups] Frontend: Migrate off of `participantAccountIDs` to `participants` format in the front end[/+]on Mar 4, 2024
@marcaaron do you know what is the current progress on the first step: The backend will start by sending both data structures? just trying to get a rough idea, and I would be happy to help clearing this up after I finish with other high priority issues.
Investigate moving participants Onyx updates to a "lower level" + write tests. Suggested by @flodnvhere.
Remove any places that are returning duplicate jsonResponse['someOnyxUpdate'] (e.g. here and here - but there are a few more). These are not needed as the updates always get passed to the API caller in the PHP $response.
I will work on creating some issues for these tasks if you want to help there. Tbh kind of planned on doing it myself since I'm very invested in cleaning up everything, but appreciate the help for sure ❤️
changed the title [-][HIGH] [Groups] Frontend: Migrate off of `participantAccountIDs` to `participants` format in the front end[/-][+][HOLD for Payment 2024-05-29] [HIGH] [Groups] Frontend: Migrate off of `participantAccountIDs` to `participants` format in the front end[/+]on May 29, 2024
I think the PR may had a relation with this bug #40254 (comment) but after the BE changes fixing this the bug was no longer reproducible. I can't tell for sure if the BE changes were enough or if an actual frontend solution was needed.
Activity
[-][HOLD] Frontend: Migrate off of `participantAccountIDs` to `participants` format in the front end[/-][+][HOLD] [MEDIUM] Frontend: Migrate off of `participantAccountIDs` to `participants` format in the front end[/+][-][HOLD] [MEDIUM] Frontend: Migrate off of `participantAccountIDs` to `participants` format in the front end[/-][+][HOLD] [CRITICAL] [Groups] Frontend: Migrate off of `participantAccountIDs` to `participants` format in the front end[/+]marcaaron commentedon Feb 27, 2024
@arielgreen this one would be good to get a contributor to work on. Perhaps someone with experience working on performance or typescript refactors as the changes will be a little surgical and quite large.
Similar to other issues - we can technically launch without this and the feature will be the same for users (but it should be done).
arielgreen commentedon Mar 4, 2024
Thanks for the context @marcaaron! Perhaps with that detail, for now I'll bump this down to HIGH and plan on sourcing contributor help with it.
[-][HOLD] [CRITICAL] [Groups] Frontend: Migrate off of `participantAccountIDs` to `participants` format in the front end[/-][+][HOLD] [HIGH] [Groups] Frontend: Migrate off of `participantAccountIDs` to `participants` format in the front end[/+]aldo-expensify commentedon Mar 26, 2024
@marcaaron do you know what is the current progress on the first step:
The backend will start by sending both data structures? just trying to get a rough idea, and I would be happy to help clearing this up after I finish with other high priority issues.marcaaron commentedon Mar 26, 2024
Hey thanks @aldo-expensify !
We are pretty close - this issue gives a good idea -> https://github.com/Expensify/Expensify/issues/341000
What's left is to...
OpenReportchangesClean up
jsonResponse['someOnyxUpdate'](e.g. here and here - but there are a few more). These are not needed as the updates always get passed to the API caller in the PHP$response.I will work on creating some issues for these tasks if you want to help there. Tbh kind of planned on doing it myself since I'm very invested in cleaning up everything, but appreciate the help for sure ❤️
25 remaining items
marcaaron commentedon May 23, 2024
Thanks! Assigned you and adding the correct labels to get this sorted.
@miljakljajic this was a new feature not a
Bugso I added that label.Other details:
@s77rt is working with me and @mallenexpensify directly on this one
@ikevin127 worked as the C+ on the review so he needs to get paid for that
[-][HIGH] [Groups] Frontend: Migrate off of `participantAccountIDs` to `participants` format in the front end[/-][+][HOLD for Payment 2024-05-29] [HIGH] [Groups] Frontend: Migrate off of `participantAccountIDs` to `participants` format in the front end[/+]trjExpensify commentedon May 29, 2024
Payment summary as follows:
Is that correct?
trjExpensify commentedon May 29, 2024
Also, after paying this out we can close the issue? (Sorry, there's a bunch of PRs linked here)
ikevin127 commentedon May 29, 2024
I think that's correct! The reported deploy blocker from #34692 (comment) was not related to the participants migration based on #42232 (comment).
✅
cc @marcaaron @s77rt Please, correct me if I'm wrong on any of the questions!
trjExpensify commentedon May 29, 2024
Alright, I've sent an offer in the meantime. I can always amend the price after the hipcheck.
s77rt commentedon May 29, 2024
I think the PR may had a relation with this bug #40254 (comment) but after the BE changes fixing this the bug was no longer reproducible. I can't tell for sure if the BE changes were enough or if an actual frontend solution was needed.
ikevin127 commentedon May 30, 2024
@trjExpensify Is this enough for payment to be issued today or we're waiting for Marc's confirmation too ?
trjExpensify commentedon May 30, 2024
Yeah, the latter. I'm coming in pretty cold on this one. I reached out to Marc earlier and I'll settle this after. 👍
trjExpensify commentedon May 30, 2024
Alright, Marc got back to me. Paid!