You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] mweb/Chrome - Expense - App returns to LHN when tapping back button after refreshing request page #35084
Version Number: 1.4.31-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
changed the title [-]mweb/Chrome - Expense - App returns to LHN when tapping back button after refreshing request page[/-][+][$500] mweb/Chrome - Expense - App returns to LHN when tapping back button after refreshing request page[/+]on Jan 24, 2024
Directly via URL - It should go back to the parent report
On Large screens Web - It doesn't display so no worries here
ON smaller screens - It applies to small screens only 👍
Via deeplink ( I assume the link was a message on another report chat) - it should go back to the original report from which the link was clicked.
The only odd case is (4). If we should consider achieving that we need to pass as a fallback route the previous screen/route and if it doesn't exist (in the case of refreshing the page ) we will fallback to the parent report.
@sonialiap this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
Activity
melvin-bot commentedon Jan 24, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0183615511eed125fe
[-]mweb/Chrome - Expense - App returns to LHN when tapping back button after refreshing request page[/-][+][$500] mweb/Chrome - Expense - App returns to LHN when tapping back button after refreshing request page[/+]melvin-bot commentedon Jan 24, 2024
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jan 24, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (
External)FitseTLT commentedon Jan 24, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense - App returns to LHN when tapping back button after refreshing request page
What is the root cause of that problem?
It is because
ROUTES.HOMEis our fallback hereApp/src/components/MoneyRequestHeader.js
Lines 139 to 140 in 74f1163
What changes do you think we should make in order to solve the problem?
We should give the parentReport route as a fallback
What alternative solutions did you explore? (Optional)
parasharrajat commentedon Jan 24, 2024
Hmm! These kinds of issues are always a headache.
@FitseTLT Can you try playing around with different ways of navigation and see what is expected from this button in those cases.
It would be great if you can present that list here.
FitseTLT commentedon Jan 24, 2024
????
parasharrajat commentedon Jan 24, 2024
Try navigating to expense reports in different ways.
etc.
FitseTLT commentedon Jan 24, 2024
The only odd case is (4). If we should consider achieving that we need to pass as a fallback route the previous screen/route and if it doesn't exist (in the case of refreshing the page ) we will fallback to the parent report.
15 remaining items
melvin-bot commentedon Feb 7, 2024
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
melvin-bot commentedon Feb 8, 2024
@sonialiap, @parasharrajat 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
ishpaul777 commentedon Feb 8, 2024
I can take over while @parasharrajat is unavailable https://expensify.slack.com/archives/C02NK2DQWUX/p1707413964286239
ishpaul777 commentedon Feb 9, 2024
I think we should hold for #36050, maybe this PR resolves the issue
melvin-bot commentedon Feb 12, 2024
@sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Feb 14, 2024
@sonialiap this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
melvin-bot commentedon Feb 14, 2024
@sonialiap Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Feb 14, 2024
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
sonialiap commentedon Feb 15, 2024
I cannot reproduce. I think #36050 may have solved this. Please reopen if you can reproduce