Skip to content

[HOLD for payment 2024-04-05] [$1000] Chat - The keyboard is overlapping with the composer #35380

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.33-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Open a chat
  2. Open the native keyboard emoji picker

Expected Result:

It shouldn't overlap.

Actual Result:

The keyboard is overlapping with the composer.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014446080d93df8ee7
  • Upwork Job ID: 1752288736160931840
  • Last Price Increase: 2024-03-20
  • Automatic offers:
    • situchan | Reviewer | 0
    • suneox | Contributor | 0

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 30, 2024
  2. changed the title [-]Chat - The keyboard is overlapping with the composer[/-] [+][$500] Chat - The keyboard is overlapping with the composer[/+] on Jan 30, 2024
  3. melvin-bot commented on Jan 30, 2024

    @melvin-bot
  4. melvin-bot commented on Jan 30, 2024

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 30, 2024
  6. melvin-bot commented on Jan 30, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

  7. eeleuch commented on Jan 30, 2024

    @eeleuch

    This can be fixed using height: "100smv" on the big container of this page
    https://css-tricks.com/the-large-small-and-dynamic-viewports/

  8. melvin-bot commented on Jan 30, 2024

    @melvin-bot

    📣 @eeleuch! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  9. eeleuch commented on Jan 30, 2024

    @eeleuch

    Contributor details
    Your Expensify account email: ely.369@outlook.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~01237276f354a158ce

  10. melvin-bot commented on Jan 30, 2024

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  11. 103 remaining items

  12. changed the title [-][$1000] Chat - The keyboard is overlapping with the composer[/-] [+][HOLD for payment 2024-04-05] [$1000] Chat - The keyboard is overlapping with the composer[/+] on Mar 29, 2024
  13. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-05. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
    • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@situchan] Determine if we should create a regression test for this bug.
    • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. sobitneupane commented on Mar 29, 2024

    @sobitneupane
    Contributor

    #39061 is regression from this issue @situchan Can you please review #39209 PR.

  17. mallenexpensify commented on Apr 5, 2024

    @mallenexpensify
    Contributor

    Holding on payment due to the regression. @situchan is out so @sobitneupane will be reviewing the PR

  18. mallenexpensify commented on Apr 17, 2024

    @mallenexpensify
    Contributor

    Sobit, the PR hit production 6 days ago, are you due payment here? If so, is it $250 or $500? I think it's $500 cuz the price reduction went into April 4 and your comment above is from March 29.

  19. sobitneupane commented on Apr 17, 2024

    @sobitneupane
    Contributor

    @mallenexpensify Yup. I also think It should be $500.

  20. mallenexpensify commented on Apr 18, 2024

    @mallenexpensify
    Contributor

    Contributor: @suneox paid $1000 via Upwork
    Contributor+: @situchan paid $500 via Upwork (50% reduction due to regression)
    Contributor+: @sobitneupane owed $500 via NewDot (PR review to fix regression cuz @situchan was OOO).

    TestRail GH created - https://github.com/Expensify/Expensify/issues/389037

    Gonna close, @situchan , when you're back from OOO, please finish the checklist. Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions