You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Room - Web - Header shows changed Room name & room name on composer unchanged room name #35419
Version Number: 1.4.33-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Go offline
Create a room
Change the name of the room
Take a note of room name on header and room name above the composer
Expected Result:
Room name should be consistent
Actual Result:
Inconsistency in Room name preview when change in offline mode.
Header shows changed Room name while room name above composer shows the first unchanged room name
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-] Room - Web - Header shows changed Room name & room name on composer unchanged room name[/-][+][$500] Room - Web - Header shows changed Room name & room name on composer unchanged room name[/+]on Jan 30, 2024
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
@Ollyws it looks like you haven't accepted the offer on Upwork, once you do I can remit payment and will you take a look at the checklist below?
;;BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
N/A
A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
Regression Test Proposal
1. Go offline
2. Create a room
3. Change the name of the room
4. Take a note of room name on header and room name above the composer and make sure they are same.
@Ollyws Sorry for not replying before. I had to take a break due to health reasons, so wasn't active then. Be sure to contact anytime in future if such help is needed. Thanks!
Activity
[-] Room - Web - Header shows changed Room name & room name on composer unchanged room name[/-][+][$500] Room - Web - Header shows changed Room name & room name on composer unchanged room name[/+]melvin-bot commentedon Jan 30, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01d1afbac3cc3b8deb
melvin-bot commentedon Jan 30, 2024
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jan 30, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)lanitochka17 commentedon Jan 30, 2024
We think that this bug might be related to #vip-vsp.
CC @quinthar
esh-g commentedon Jan 30, 2024
Proposal
Please re-state the issue we are trying to solve
Header shows changed Room name & room name on composer unchanged room name
Root cause
We are memoizing the
ReportActionItemCreatedcomponent incorrectly.App/src/pages/home/report/ReportActionItemCreated.tsx
Lines 111 to 119 in 9909a36
What changes should be made to fix this?
We should check if
props.report?.reportNamechanged in the memomkhutornyi commentedon Jan 30, 2024
I think this can be fixed together in #35123 or #35378
Ollyws commentedon Feb 1, 2024
@mkhutornyi None of the solutions proposed in those issues would fix this one.
@esh-g's proposal LGTM.
🎀👀🎀 C+ reviewed
13 remaining items
melvin-bot commentedon Mar 4, 2024
This issue has not been updated in over 15 days. @Ollyws, @Gonals, @adelekennedy, @esh-g eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
esh-g commentedon Mar 4, 2024
@adelekennedy I think the payments for this issue are pending. The PR was deployed to prod 3 weeks ago.
adelekennedy commentedon Mar 4, 2024
@esh-g thank you! It looks like the automation failed for updating the title - settling payments now
adelekennedy commentedon Mar 4, 2024
@Ollyws it looks like you haven't accepted the offer on Upwork, once you do I can remit payment and will you take a look at the checklist below?
;;BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Ollyws commentedon Mar 7, 2024
Just trying to track down which PR caused this.... @esh-g if you have any insights they would be much appreciated.
Ollyws commentedon Mar 10, 2024
BugZero Checklist:
#34463
#34463 (comment)
N/A
Regression Test Proposal
Do we agree 👍 or 👎
Ollyws commentedon Mar 10, 2024
@adelekennedy Checklist complete and offer accepted.
esh-g commentedon Mar 12, 2024
@Ollyws Sorry for not replying before. I had to take a break due to health reasons, so wasn't active then. Be sure to contact anytime in future if such help is needed. Thanks!
Ollyws commentedon Apr 9, 2024
@adelekennedy Can we pay and close this one? Thanks!
Ollyws commentedon Apr 24, 2024
Friendly bump @adelekennedy
adelekennedy commentedon Apr 26, 2024
So sorry!! Paying this out now