Skip to content

[$500] Room - Web - Header shows changed Room name & room name on composer unchanged room name #35419

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.33-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go offline
  2. Create a room
  3. Change the name of the room
  4. Take a note of room name on header and room name above the composer

Expected Result:

Room name should be consistent

Actual Result:

Inconsistency in Room name preview when change in offline mode.
Header shows changed Room name while room name above composer shows the first unchanged room name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6361117_1706634444941.Recording__1966.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d1afbac3cc3b8deb
  • Upwork Job ID: 1752383443231072256
  • Last Price Increase: 2024-02-06
  • Automatic offers:
    • Ollyws | Reviewer | 28150301
    • esh-g | Contributor | 28150302

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 30, 2024
  2. changed the title [-] Room - Web - Header shows changed Room name & room name on composer unchanged room name[/-] [+][$500] Room - Web - Header shows changed Room name & room name on composer unchanged room name[/+] on Jan 30, 2024
  3. melvin-bot commented on Jan 30, 2024

    @melvin-bot
  4. melvin-bot commented on Jan 30, 2024

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 30, 2024
  6. melvin-bot commented on Jan 30, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

  7. lanitochka17 commented on Jan 30, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp.
    CC @quinthar

  8. esh-g commented on Jan 30, 2024

    @esh-g
    Contributor

    Proposal

    Please re-state the issue we are trying to solve

    Header shows changed Room name & room name on composer unchanged room name

    Root cause

    We are memoizing the ReportActionItemCreated component incorrectly.

    memo(
    ReportActionItemCreated,
    (prevProps, nextProps) =>
    prevProps.policy?.name === nextProps.policy?.name &&
    prevProps.policy?.avatar === nextProps.policy?.avatar &&
    prevProps.report?.stateNum === nextProps.report?.stateNum &&
    prevProps.report?.statusNum === nextProps.report?.statusNum &&
    prevProps.report?.lastReadTime === nextProps.report?.lastReadTime,
    ),

    What changes should be made to fix this?

    We should check if props.report?.reportName changed in the memo

  9. mkhutornyi commented on Jan 30, 2024

    @mkhutornyi
    Contributor

    I think this can be fixed together in #35123 or #35378

  10. Ollyws commented on Feb 1, 2024

    @Ollyws
    Contributor

    @mkhutornyi None of the solutions proposed in those issues would fix this one.

    @esh-g's proposal LGTM.

    🎀👀🎀 C+ reviewed

  11. 13 remaining items

  12. melvin-bot commented on Mar 4, 2024

    @melvin-bot

    This issue has not been updated in over 15 days. @Ollyws, @Gonals, @adelekennedy, @esh-g eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  13. esh-g commented on Mar 4, 2024

    @esh-g
    Contributor

    @adelekennedy I think the payments for this issue are pending. The PR was deployed to prod 3 weeks ago.

  14. adelekennedy commented on Mar 4, 2024

    @adelekennedy
    Contributor

    @esh-g thank you! It looks like the automation failed for updating the title - settling payments now

  15. adelekennedy commented on Mar 4, 2024

    @adelekennedy
    Contributor

    @Ollyws it looks like you haven't accepted the offer on Upwork, once you do I can remit payment and will you take a look at the checklist below?

    ;;BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • The PR that introduced the bug has been identified. Link to the PR:
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
  16. Ollyws commented on Mar 7, 2024

    @Ollyws
    Contributor

    Just trying to track down which PR caused this.... @esh-g if you have any insights they would be much appreciated.

  17. Ollyws commented on Mar 10, 2024

    @Ollyws
    Contributor

    BugZero Checklist:

    • The PR that introduced the bug has been identified. Link to the PR:

    #34463

    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    #34463 (comment)

    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    N/A

    • A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

    Regression Test Proposal

    1. Go offline
    2. Create a room
    3. Change the name of the room
    4. Take a note of room name on header and room name above the composer and make sure they are same.
    

    Do we agree 👍 or 👎

  18. Ollyws commented on Mar 10, 2024

    @Ollyws
    Contributor

    @adelekennedy Checklist complete and offer accepted.

  19. esh-g commented on Mar 12, 2024

    @esh-g
    Contributor

    @Ollyws Sorry for not replying before. I had to take a break due to health reasons, so wasn't active then. Be sure to contact anytime in future if such help is needed. Thanks!

  20. Ollyws commented on Apr 9, 2024

    @Ollyws
    Contributor

    @adelekennedy Can we pay and close this one? Thanks!

  21. Ollyws commented on Apr 24, 2024

    @Ollyws
    Contributor

    Friendly bump @adelekennedy

  22. adelekennedy commented on Apr 26, 2024

    @adelekennedy
    Contributor

    So sorry!! Paying this out now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions