Skip to content

[HOLD for payment 2024-02-14] Scan- Invalid file is downloaded when uploading invalid file and downloading from receipt view #35482

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.34-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #34087

Action Performed:

  1. Create a money request with receipt
  2. Navigate to request details page
  3. Click on the receipt > 3-dot menu > Replace
  4. Upload a corrupted file
  5. Click on the receipt preview > 3-dot menu > Download
  6. Open the downloaded file

Expected Result:

The downloaded file will be the corrupted file

Actual Result:

The download receipt name belongs to the previous receipt (png format), but the downloaded file itself is invalid

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6362441_1706713172959.20240131_203208.mp4

Bug6362441_1706713172960!CORRUPT.pdf

View all open jobs on GitHub

Activity

  1. github-actions commented on Jan 31, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Jan 31, 2024

    @melvin-bot

    Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. lanitochka17 commented on Jan 31, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave5.
    CC @dylanexpensify

  4. luacmartins commented on Jan 31, 2024

    @luacmartins
    Contributor

    Looking at this now

  5. francoisl commented on Jan 31, 2024

    @francoisl
    Contributor

    @luacmartins any luck with this one?

  6. luacmartins commented on Jan 31, 2024

    @luacmartins
    Contributor

    Demoting to NAB. Gonna leave a comment in the original PR so the contributor can look into it.

  7. luacmartins commented on Jan 31, 2024

    @luacmartins
    Contributor

    @tienifr could you look into this one? seems like a regression from #34087

  8. tienifr commented on Feb 1, 2024

    @tienifr
    Contributor

    I'm doing

  9. 12 remaining items

  10. melvin-bot commented on Feb 14, 2024

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  11. melvin-bot commented on Feb 16, 2024

    @melvin-bot

    @luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

  12. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 19, 2024
  13. self-assigned this
    on Feb 19, 2024
  14. melvin-bot commented on Feb 19, 2024

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  15. luacmartins commented on Feb 19, 2024

    @luacmartins
    Contributor

    No payment needed here, this was a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions