You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-02-09] Thread - Join button in thread is not responsive #35562
Version Number: 1.3.45-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Send a message in any chat
Right click on the message > Leave thread
Right click on the message > Reply in thread
Click Join
Expected Result:
Join button is responsive
Actual Result:
Join button is not responsive. The same issue also occurs when clicking Join from 3-dot menu
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Thread - Join button in thread is not responsive[/-][+][HOLD for payment 2024-02-09] Thread - Join button in thread is not responsive[/+]on Feb 2, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.35-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
github-actions commentedon Feb 1, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 1, 2024
Triggered auto assignment to @AndrewGable (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Feb 1, 2024
We think that this bug might be related to #vip-vsp
CC @quinthar
paultsimura commentedon Feb 1, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The "Join" button has no effect until the report page is re-visited.
What is the root cause of that problem?
A regression from #30168
This is happening because we memoize the
ReportScreenincorrectly: we do not compare thereport.notificationPreference:App/src/pages/home/ReportScreen.js
Lines 645 to 662 in 9ab4fe9
As a result, the header is not updated when the report's
notificationPreferenceis gets updated.What changes do you think we should make in order to solve the problem?
We should add this check as well:
What alternative solutions did you explore? (Optional)
mountiny commentedon Feb 1, 2024
@rlinoz I think we should fix this in your PR too #35563 you making a same change there basically
melvin-bot commentedon Feb 1, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
AndrewGable commentedon Feb 1, 2024
Looks like the fix for this is CP-ed to web already: https://github.com/Expensify/App/actions/runs/7746962730 and https://github.com/Expensify/App/actions/runs/7747613218 so going to test the fix on web.
AndrewGable commentedon Feb 1, 2024
The join button now works on staging 👍
Great job @rlinoz
[-]Thread - Join button in thread is not responsive[/-][+][HOLD for payment 2024-02-09] Thread - Join button in thread is not responsive[/+]melvin-bot commentedon Feb 2, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 2, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.35-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-02-09. 🎊