Skip to content

[HOLD for payment 2024-02-09] Thread - Join button in thread is not responsive #35562

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.45-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Send a message in any chat
  2. Right click on the message > Leave thread
  3. Right click on the message > Reply in thread
  4. Click Join

Expected Result:

Join button is responsive

Actual Result:

Join button is not responsive. The same issue also occurs when clicking Join from 3-dot menu

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6363697_1706797945079.20240201_163812__1_.1.mp4

View all open jobs on GitHub

Activity

  1. github-actions commented on Feb 1, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Feb 1, 2024

    @melvin-bot

    Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. lanitochka17 commented on Feb 1, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp
    CC @quinthar

  4. paultsimura commented on Feb 1, 2024

    @paultsimura
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The "Join" button has no effect until the report page is re-visited.

    What is the root cause of that problem?

    A regression from #30168

    This is happening because we memoize the ReportScreen incorrectly: we do not compare the report.notificationPreference:

    memo(
    ReportScreen,
    (prevProps, nextProps) =>
    prevProps.isSidebarLoaded === nextProps.isSidebarLoaded &&
    _.isEqual(prevProps.reportActions, nextProps.reportActions) &&
    _.isEqual(prevProps.reportMetadata, nextProps.reportMetadata) &&
    prevProps.isComposerFullSize === nextProps.isComposerFullSize &&
    _.isEqual(prevProps.betas, nextProps.betas) &&
    _.isEqual(prevProps.policies, nextProps.policies) &&
    prevProps.accountManagerReportID === nextProps.accountManagerReportID &&
    prevProps.userLeavingStatus === nextProps.userLeavingStatus &&
    prevProps.report.reportID === nextProps.report.reportID &&
    prevProps.report.policyID === nextProps.report.policyID &&
    prevProps.report.isOptimisticReport === nextProps.report.isOptimisticReport &&
    prevProps.report.statusNum === nextProps.report.statusNum &&
    _.isEqual(prevProps.report.pendingFields, nextProps.report.pendingFields) &&
    prevProps.currentReportID === nextProps.currentReportID,
    ),

    As a result, the header is not updated when the report's notificationPreference is gets updated.

    What changes do you think we should make in order to solve the problem?

    We should add this check as well:

    prevProps.report.notificationPreference === nextProps.report.notificationPreference &&

    What alternative solutions did you explore? (Optional)

  5. mountiny commented on Feb 1, 2024

    @mountiny
    Contributor

    @rlinoz I think we should fix this in your PR too #35563 you making a same change there basically

  6. melvin-bot commented on Feb 1, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  7. AndrewGable commented on Feb 1, 2024

    @AndrewGable
    Contributor

    Looks like the fix for this is CP-ed to web already: https://github.com/Expensify/App/actions/runs/7746962730 and https://github.com/Expensify/App/actions/runs/7747613218 so going to test the fix on web.

  8. AndrewGable commented on Feb 1, 2024

    @AndrewGable
    Contributor

    The join button now works on staging 👍

    Great job @rlinoz

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Feb 2, 2024
  10. changed the title [-]Thread - Join button in thread is not responsive[/-] [+][HOLD for payment 2024-02-09] Thread - Join button in thread is not responsive[/+] on Feb 2, 2024
  11. melvin-bot commented on Feb 2, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Feb 2, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.35-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-02-09. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions