You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Theme - App returns to main chat instead of previous page when returning from changing theme #35689
Version Number: .1.4-36.0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Go to staging.new.expensify.com
Click Settings from the bottom
Click Profile from the top
Click back button
Note that app returns to Settings
While in Workspaces page, click Profile > Preferences > Theme
Select a different theme
Click Back button
Expected Result:
App returns to Workspaces page
Actual Result:
App returns to main chat
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
I'm on the fence of this being a blocker, it doesn't really break any functionality, it's just slightly unexpected. I'll leave the decision to @tylerkaraszewski though
changed the title [-]Theme - App returns to main chat instead of previous page when returning from changing theme[/-][+][$500] Theme - App returns to main chat instead of previous page when returning from changing theme[/+]on Feb 3, 2024
By specifying the required deep link, such as: onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS_PREFERENCES)}
Alternatives
It was also observed that the following screens: Priority Mode, Language, and Theme, within the /settings/preferences stack, would all benefit from a similar deep link implementation.
Activity
github-actions commentedon Feb 2, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 2, 2024
Triggered auto assignment to @tylerkaraszewski (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Feb 2, 2024
We think that this bug might be related to #vip-vsp
CC @quinthar
luacmartins commentedon Feb 2, 2024
I think this is actually related to Wave8: Ideal Nav
luacmartins commentedon Feb 2, 2024
I'm on the fence of this being a blocker, it doesn't really break any functionality, it's just slightly unexpected. I'll leave the decision to @tylerkaraszewski though
tylerkaraszewski commentedon Feb 2, 2024
I don't think it needs to be a blocker. It seems it can probably be external as well, does any one object to that?
melvin-bot commentedon Feb 3, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01bc56887b7e795d9e
[-]Theme - App returns to main chat instead of previous page when returning from changing theme[/-][+][$500] Theme - App returns to main chat instead of previous page when returning from changing theme[/+]melvin-bot commentedon Feb 3, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)jeremy-croff commentedon Feb 3, 2024
Proposal
Problem Statement
The back button, within the theme modal, fails to navigate back to the previous Stack from the theme modal.
Root Cause
The current implementation lacks the necessary deep linking to return to the /settings/preferences previous stack.
Proposed Solution
To solve this issue, we can update the back handler in ThemePage.js:
App/src/pages/settings/Preferences/ThemePage.js
Line 43 in 3ab4e6e
By specifying the required deep link, such as:
onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS_PREFERENCES)}Alternatives
It was also observed that the following screens: Priority Mode, Language, and Theme, within the /settings/preferences stack, would all benefit from a similar deep link implementation.
allgandalf commentedon Feb 3, 2024
this issue needs to be handled here: [#whatsnext] Wave 08 - Collect Plan Admins (view)
hayata-suenaga commentedon Feb 4, 2024
Thank you for pointing that out. I'll close this one in favor of that one 🙇