Skip to content

[$500] Theme - App returns to main chat instead of previous page when returning from changing theme #35689

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: .1.4-36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Click Settings from the bottom
  3. Click Profile from the top
  4. Click back button
  5. Note that app returns to Settings
  6. While in Workspaces page, click Profile > Preferences > Theme
  7. Select a different theme
  8. Click Back button

Expected Result:

App returns to Workspaces page

Actual Result:

App returns to main chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365118_1706895958370.20240203_000127.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bc56887b7e795d9e
  • Upwork Job ID: 1753588018262831104
  • Last Price Increase: 2024-02-03

Activity

  1. github-actions commented on Feb 2, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Feb 2, 2024

    @melvin-bot

    Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. lanitochka17 commented on Feb 2, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp
    CC @quinthar

  4. luacmartins commented on Feb 2, 2024

    @luacmartins
    Contributor

    I think this is actually related to Wave8: Ideal Nav

  5. luacmartins commented on Feb 2, 2024

    @luacmartins
    Contributor

    I'm on the fence of this being a blocker, it doesn't really break any functionality, it's just slightly unexpected. I'll leave the decision to @tylerkaraszewski though

  6. tylerkaraszewski commented on Feb 2, 2024

    @tylerkaraszewski
    Contributor

    I don't think it needs to be a blocker. It seems it can probably be external as well, does any one object to that?

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Feb 3, 2024
  8. melvin-bot commented on Feb 3, 2024

    @melvin-bot
  9. changed the title [-]Theme - App returns to main chat instead of previous page when returning from changing theme[/-] [+][$500] Theme - App returns to main chat instead of previous page when returning from changing theme[/+] on Feb 3, 2024
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 3, 2024
  11. melvin-bot commented on Feb 3, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

  12. jeremy-croff commented on Feb 3, 2024

    @jeremy-croff
    Contributor

    Proposal

    Problem Statement

    The back button, within the theme modal, fails to navigate back to the previous Stack from the theme modal.

    Root Cause

    The current implementation lacks the necessary deep linking to return to the /settings/preferences previous stack.

    Proposed Solution

    To solve this issue, we can update the back handler in ThemePage.js:

    onBackButtonPress={() => Navigation.goBack()}

    By specifying the required deep link, such as:
    onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS_PREFERENCES)}

    Alternatives

    It was also observed that the following screens: Priority Mode, Language, and Theme, within the /settings/preferences stack, would all benefit from a similar deep link implementation.

  13. allgandalf commented on Feb 3, 2024

    @allgandalf
    Contributor

    this issue needs to be handled here: [#whatsnext] Wave 08 - Collect Plan Admins (view)

  14. hayata-suenaga commented on Feb 4, 2024

    @hayata-suenaga
    Contributor

    this issue needs to be handled here: [#whatsnext] Wave 08 - Collect Plan Admins (view)

    Thank you for pointing that out. I'll close this one in favor of that one 🙇

  15. added
    ReviewingHas a PR in review
    and removed on Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions