Skip to content

[$500] Workspace - Tooltip is at the center instead of above display name #35691

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: .1.4-36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open workspace switcher
  3. Select a workspace
  4. Go to Settings at the bottom
  5. Go to Members
  6. Hover over member display name

Expected Result:

Tooltip appeaers above the display name

Actual Result:

Tooltip is at the center instead of above the display name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365133_1706896814542.20240203_001655.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01da161df451d2ec58
  • Upwork Job ID: 1753485595100897280
  • Last Price Increase: 2024-02-02

Activity

  1. github-actions commented on Feb 2, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Feb 2, 2024

    @melvin-bot

    Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. lanitochka17 commented on Feb 2, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #5
    CC @dylanexpensify

  4. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Feb 2, 2024
  5. allgandalf commented on Feb 2, 2024

    @allgandalf
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Tooltip is at the center instead of above display name

    What is the root cause of that problem?

    We place the Tootip at wrong component

    What changes do you think we should make in order to solve the problem?

    Rearrange the tooltip to be placed exactly above the text

    What alternative solutions did you explore? (Optional)

    N/A

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 2, 2024
  7. changed the title [-]Workspace - Tooltip is at the center instead of above display name[/-] [+][$500] Workspace - Tooltip is at the center instead of above display name[/+] on Feb 2, 2024
  8. melvin-bot commented on Feb 2, 2024

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 2, 2024
  10. 20 remaining items

  11. aswin-s commented on Feb 2, 2024

    @aswin-s
    Contributor

    I'll raise a fix shortly

  12. added
    ReviewingHas a PR in review
    and removed on Feb 2, 2024
  13. aswin-s commented on Feb 2, 2024

    @aswin-s
    Contributor

    PR is ready: #35735 @sobitneupane

  14. roryabraham commented on Feb 6, 2024

    @roryabraham
    Contributor

    IDK why, but I'm not able to get tooltips to show up on this view at all 😕

  15. roryabraham commented on Feb 6, 2024

    @roryabraham
    Contributor

    the only tooltip I see is this one:

    image

    same on main and on @aswin-s' branch

  16. mountiny commented on Feb 6, 2024

    @mountiny
    Contributor

    Same as Rory, only that one tooltip
    image

  17. aswin-s commented on Feb 7, 2024

    @aswin-s
    Contributor

    @sobitneupane @roryabraham Looks like hiding the tooltip is intentional. Regression is from #35460. As per issue #34961 it shouldn't even show tooltip here as the label and tooltip is same.

    So is this issue valid any more?

  18. sobitneupane commented on Feb 7, 2024

    @sobitneupane
    Contributor

    @aswin-s Going through the linked PR, we do show the tooltip, If target.scrollWidth > target.offsetWidth (i.e., if the text overflows).

    Screen.Recording.2024-02-07.at.12.27.40.mov

    But I do believe that in case the text overflows, the tooltip will basically appear at the center. But we should extensively test different cases with larger text and alternate texts.

  19. aswin-s commented on Feb 7, 2024

    @aswin-s
    Contributor

    @sobitneupane The scenario where text overflows is when the text length reaches the container width. At this point tool tip should be aligned at the center of the container anyways.

  20. roryabraham commented on Feb 7, 2024

    @roryabraham
    Contributor

    cool, so it sounds like this issue is no longer valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions