You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Workspace - Tooltip is at the center instead of above display name #35691
Version Number: .1.4-36.0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Go to staging.new.expensify.com
Open workspace switcher
Select a workspace
Go to Settings at the bottom
Go to Members
Hover over member display name
Expected Result:
Tooltip appeaers above the display name
Actual Result:
Tooltip is at the center instead of above the display name
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Workspace - Tooltip is at the center instead of above display name[/-][+][$500] Workspace - Tooltip is at the center instead of above display name[/+]on Feb 2, 2024
@sobitneupane@roryabraham Looks like hiding the tooltip is intentional. Regression is from #35460. As per issue #34961 it shouldn't even show tooltip here as the label and tooltip is same.
@aswin-s Going through the linked PR, we do show the tooltip, If target.scrollWidth > target.offsetWidth (i.e., if the text overflows).
Screen.Recording.2024-02-07.at.12.27.40.mov
But I do believe that in case the text overflows, the tooltip will basically appear at the center. But we should extensively test different cases with larger text and alternate texts.
@sobitneupane The scenario where text overflows is when the text length reaches the container width. At this point tool tip should be aligned at the center of the container anyways.
Activity
github-actions commentedon Feb 2, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 2, 2024
Triggered auto assignment to @hayata-suenaga (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Feb 2, 2024
We think that this bug might be related to #5
CC @dylanexpensify
allgandalf commentedon Feb 2, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Tooltip is at the center instead of above display name
What is the root cause of that problem?
We place the Tootip at wrong component
What changes do you think we should make in order to solve the problem?
Rearrange the tooltip to be placed exactly above the text
What alternative solutions did you explore? (Optional)
N/A
[-]Workspace - Tooltip is at the center instead of above display name[/-][+][$500] Workspace - Tooltip is at the center instead of above display name[/+]melvin-bot commentedon Feb 2, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01da161df451d2ec58
20 remaining items
aswin-s commentedon Feb 2, 2024
I'll raise a fix shortly
aswin-s commentedon Feb 2, 2024
PR is ready: #35735 @sobitneupane
roryabraham commentedon Feb 6, 2024
IDK why, but I'm not able to get tooltips to show up on this view at all 😕
roryabraham commentedon Feb 6, 2024
the only tooltip I see is this one:
same on main and on @aswin-s' branch
mountiny commentedon Feb 6, 2024
Same as Rory, only that one tooltip

aswin-s commentedon Feb 7, 2024
@sobitneupane @roryabraham Looks like hiding the tooltip is intentional. Regression is from #35460. As per issue #34961 it shouldn't even show tooltip here as the label and tooltip is same.
So is this issue valid any more?
sobitneupane commentedon Feb 7, 2024
@aswin-s Going through the linked PR, we do show the tooltip, If target.scrollWidth > target.offsetWidth (i.e., if the text overflows).
Screen.Recording.2024-02-07.at.12.27.40.mov
But I do believe that in case the text overflows, the tooltip will basically appear at the center. But we should extensively test different cases with larger text and alternate texts.
aswin-s commentedon Feb 7, 2024
@sobitneupane The scenario where text overflows is when the text length reaches the container width. At this point tool tip should be aligned at the center of the container anyways.
roryabraham commentedon Feb 7, 2024
cool, so it sounds like this issue is no longer valid.