Skip to content

Requesting payments and Splitting bills with self causes indefinite loading #3572

Closed

Description

@Santhosh-Sellavel

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

Requesting payments and splitting bills with self should not be allowed.

Actual Result:

Requesting payments and splitting bills with self results in infinite loading.

Action Performed:

Splitting bills:

  • New
  • Split Bill
  • Enter your own email in search
  • Select your email from result
  • Enter amount & what is it for and tap split.

Requesting money:

  • New
  • Request Money
  • Enter your own email in search
  • Select your email from result
  • Enter amount & reason and send

Workaround:

Need close and reopen app. Refresh in web.
We can restrict the user to pick own email from search result. As we do for new chat with self.

Or if team we have other ideas, I'll do that.

I'll work on my proposal, based on your inputs.

Platform:

Where is this issue occurring?
I personal able to reproduce on android & web, I sure it will occur on all platform.

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:1.0.65
Notes/Photos/Videos:

Splitting bills:
https://user-images.githubusercontent.com/85645967/121790974-99f67980-cc02-11eb-969c-c355961de0c3.mp4

Requesting money:
https://user-images.githubusercontent.com/85645967/121790494-872d7600-cbfd-11eb-964a-1bd8fe0eaa1a.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

Activity

  1. MelvinBot commented on Jun 12, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @Christinadobrzyn (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Jun 12, 2021
  3. Christinadobrzyn commented on Jun 14, 2021

    @Christinadobrzyn
    Contributor

    Should we combine this GH with this GH into one issue?

  4. MelvinBot commented on Jun 14, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @Dal-Papa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  5. removed their assignment
    on Jun 14, 2021
  6. quinthar commented on Jun 14, 2021

    @quinthar
    Contributor
  7. jasperhuangg commented on Jun 16, 2021

    @jasperhuangg
    Contributor

    Hey @Santhosh-Sellavel!

    Do you have a proposal for how you plan to prevent this from happening? I'm thinking it would be something along the lines of filtering out the user both here and here.

    What are your thoughts?

  8. changed the title [-]Spiliting bill between self causes, indefinite loading[/-] [+]Requesting payments and Splitting bills with self causes indefinite loading[/+] on Jun 16, 2021
  9. jasperhuangg commented on Jun 16, 2021

    @jasperhuangg
    Contributor

    @Christinadobrzyn @Santhosh-Sellavel I've closed the other, related issue out and updated this issue to include both Splitting Bills and Requesting Money 👍

  10. Santhosh-Sellavel commented on Jun 16, 2021

    @Santhosh-Sellavel
    CollaboratorAuthor

    Hey @Santhosh-Sellavel!

    Do you have a proposal for how you plan to prevent this from happening? I'm thinking it would be something along the lines of filtering out the user both here and here.

    What are your thoughts?

    Hey @jasperhuangg ,
    Do we need to show, user email in search?

    If yes
    we need to just need to restrict action on tap.
    else
    we can filter out the current user email from search.

    Let me know how you need to handle, I'll propose with technical solution.

  11. 12 remaining items

  12. MelvinBot commented on Jul 19, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  13. stephanieelliott commented on Jul 21, 2021

    @stephanieelliott
    Contributor

    Job in Upwork is here: https://www.upwork.com/jobs/~0180725decbdd185e0

    Heads up @Santhosh-Sellavel, we'll want to agree on a comprehensive proposal here in the GH issue before hiring in Upwork. Once you settle on the solution you'd plan to implement, please post it here in the issue as a comment.

  14. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 21, 2021
  15. MelvinBot commented on Jul 21, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @deetergp (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  16. Santhosh-Sellavel commented on Jul 21, 2021

    @Santhosh-Sellavel
    CollaboratorAuthor

    Already completed,

    Proposals:
    #3572 (comment)
    #3572 (comment)

    Proposal Acceptance
    #3572 (comment)

    Slack discussion
    https://expensify.slack.com/archives/C01GTK53T8Q/p1625752160038700

    Even PR is merged #4062

    @stephanieelliott

  17. stephanieelliott commented on Jul 22, 2021

    @stephanieelliott
    Contributor

    Ah ok thanks for clarifying @Santhosh-Sellavel. Looks like #4063 was the PR merged for this fix. I hired you on Upwork, please accept the offer and we will pay up for the issue + reporting bonus ASAP!

  18. stephanieelliott commented on Jul 22, 2021

    @stephanieelliott
    Contributor

    7-day regression period was already completed, paid in Upwork!

  19. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions