You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[PAYMENT DUE] [$500] mWeb - Device back button with emoji picker opened leads to LHN instead of closing picker #35756
changed the title [-] mWeb - Device back button with emoji picker opened leads to LHN instead of closing picker[/-][+][$500] mWeb - Device back button with emoji picker opened leads to LHN instead of closing picker[/+]on Feb 3, 2024
Please re-state the problem that we are trying to solve in this issue.
mWeb - Device back button with emoji picker opened leads to LHN instead of closing picker
What is the root cause of that problem?
We are call Navigation.goBack when back button is pressed.
What changes do you think we should make in order to solve the problem?
Before navigating check if the emoji picker is visible or not, if visible close it and do not navigate. We can get emojiPicker status from EmojiPickerAction and call hideEmojiPicker.
Please re-state the problem that we are trying to solve in this issue.
mWeb - Device back button with emoji picker opened leads to LHN instead of closing picker
What is the root cause of that problem?
When emoji modal open we don't update window history state after that user clicks on "The browser back button" or "Device Back Button" it will navigate back to the previous page (base on browser history)
What changes do you think we should make in order to solve the problem?
We will handle update the history state for Modal Web and to make sure this change only affects some the modals we can add new props shouldHandleNavigationBack for Modal
Well opening up an emoji picker is not a navigation action.
Naturally clicking the back button would navigate back to the previous screen.
This is working as intended.
The only thing I see is that the background has a disabled state. We could improve the user experience if desired to disable all clicks and only close the emoji picker when clicking outside of it. But this is not what the Issue is asking for.
changed the title [-][$500] mWeb - Device back button with emoji picker opened leads to LHN instead of closing picker[/-][+][PAYMENT DUE] [$500] mWeb - Device back button with emoji picker opened leads to LHN instead of closing picker[/+]on May 7, 2024
Activity
[-] mWeb - Device back button with emoji picker opened leads to LHN instead of closing picker[/-][+][$500] mWeb - Device back button with emoji picker opened leads to LHN instead of closing picker[/+]melvin-bot commentedon Feb 3, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0156cc7a92d86433bd
melvin-bot commentedon Feb 3, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)melvin-bot commentedon Feb 3, 2024
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.lanitochka17 commentedon Feb 3, 2024
We think that this bug might be related to #vip-vsp
CC @quinthar
Krishna2323 commentedon Feb 3, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
mWeb - Device back button with emoji picker opened leads to LHN instead of closing picker
What is the root cause of that problem?
We are call
Navigation.goBackwhen back button is pressed.What changes do you think we should make in order to solve the problem?
Before navigating check if the emoji picker is visible or not, if visible close it and do not navigate. We can get emojiPicker status from
EmojiPickerActionand callhideEmojiPicker.Result
suneox commentedon Feb 3, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
mWeb - Device back button with emoji picker opened leads to LHN instead of closing picker
What is the root cause of that problem?
When emoji modal open we don't update window history state after that user clicks on "The browser back button" or "Device Back Button" it will navigate back to the previous page (base on browser history)
What changes do you think we should make in order to solve the problem?
We will handle update the history state for Modal Web and to make sure this change only affects some the modals we can add new props
shouldHandleNavigationBackfor ModalAt EmojiPicker pass props
shouldHandleNavigationBackto Popover with condition isBrowser.isMobile()POC
Screen.Recording.2024-02-12.at.23.29.35.mov
testing branch
What alternative solutions did you explore? (Optional)
jeremy-croff commentedon Feb 3, 2024
Well opening up an emoji picker is not a navigation action.
Naturally clicking the back button would navigate back to the previous screen.
This is working as intended.
The only thing I see is that the background has a disabled state. We could improve the user experience if desired to disable all clicks and only close the emoji picker when clicking outside of it. But this is not what the Issue is asking for.
hayata-suenaga commentedon Feb 4, 2024
This issue should be handled in this issue
Thank you everyone for your proposals, but we're closing this issue 🙇
95 remaining items
Julesssss commentedon Apr 29, 2024
Hey @zanyrenney, just wanted to check you've seen this payment request?
zanyrenney commentedon May 7, 2024
on it, didn't see this with the lack of date automation.
[-][$500] mWeb - Device back button with emoji picker opened leads to LHN instead of closing picker[/-][+][PAYMENT DUE] [$500] mWeb - Device back button with emoji picker opened leads to LHN instead of closing picker[/+]zanyrenney commentedon May 7, 2024
payment summary
@sobitneupane owed $500 - needs to request through NewDot (manual requests)
@suneox needs $500 from upwork.
zanyrenney commentedon May 7, 2024
@suneox I can't find you on upwork.

Please can you manually apply to the job? https://www.upwork.com/jobs/~01386bcc6b2c6f0fdf
Feel free to DM me in slack when you have and i'll process the payment ASAP.
suneox commentedon May 7, 2024
Here is my profile
zanyrenney commentedon May 7, 2024
Invited, please accept !
suneox commentedon May 7, 2024
I have accept this job, Thank you
zanyrenney commentedon May 7, 2024
payment summary
@sobitneupane owed $500 - needs to request through NewDot (manual requests)
@suneox PAID $500 from upwork.
melvin-bot commentedon May 7, 2024
@shawnborton @Julesssss @zanyrenney Be sure to fill out the Contact List!
JmillsExpensify commentedon May 12, 2024
$500 approved for @sobitneupane