Skip to content

Text in the composer is very small when device font size is minimum #35787

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4-36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: Device font size is set to minimum

  1. Launch New Expensify app
  2. Open any chat
  3. Type in the composer
  4. Send it

Expected Result:

The text in the composer has the same size as the text in the chat
image

Actual Result:

The text in the composer is smaller than the text in the chat
image

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6366898_1707065880365!Screenshot_2024-02-05_at_00 55 51
Bug6366898_1707065880367.Screen_Recording_20240203_033427_New_Expensify.mp4

View all open jobs on GitHub

Activity

  1. github-actions commented on Feb 4, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Feb 4, 2024

    @melvin-bot

    Triggered auto assignment to @grgia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. lanitochka17 commented on Feb 4, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp
    CC @quinthar

  4. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Feb 5, 2024
  5. mountiny commented on Feb 5, 2024

    @mountiny
    Contributor

    Not a blocker. @lanitochka17 how does this behave in production?

  6. kavimuru commented on Feb 5, 2024

    @kavimuru

    @mountiny this is the video from production

    Screen_Recording_20240203_033512_Settings.mp4
  7. mountiny commented on Feb 5, 2024

    @mountiny
    Contributor

    cc @tomekzaw @thienlnam this might be related to the live markdown feature

  8. thienlnam commented on Feb 7, 2024

    @thienlnam
    Contributor

    Looks like this is applicable to iOS as well https://expensify.slack.com/archives/C049HHMV9SM/p1707328995049399

    I'll go ahead and take this over

  9. 5 remaining items

  10. thienlnam commented on Feb 7, 2024

    @thienlnam
    Contributor

    @tomekzaw Are we able to scale back the font size from the setting a bit? It seems to be much smaller than iMessage

    Here's iOS at the smallest font size from @AndrewGable
    image
    image

  11. tomekzaw commented on Feb 7, 2024

    @tomekzaw
    Contributor

    Thanks for reporting this issue. I think we use original fontSize passed via styles but obviously this needs investigation since it changes the behavior of the composer.

  12. tomekzaw commented on Feb 12, 2024

    @tomekzaw
    Contributor

    Should be fixed with #35973.

    The root cause of the issue was missing allowFontScaling={false} property.

    Expensify app uses its own logic for font scaling so it disables operating system scaling.

    Previously, composer would use RNTextInput which is a thin wrapper over built-in TextInput but with allowFontScaling={false} and some other properties already set.

    In #34292, I replaced RNTextInput with MarkdownTextInput directly without any wrappers so allowFontScaling={false} property is not set. PR #35973 restores the wrapper.

    cc @thienlnam

  13. thienlnam commented on Feb 14, 2024

    @thienlnam
    Contributor

    PR in review

  14. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    @tomekzaw, @thienlnam, @thesahindia Huh... This is 4 days overdue. Who can take care of this?

  15. tomekzaw commented on Feb 20, 2024

    @tomekzaw
    Contributor

    Fixed in #35973.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions