You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Text in the composer is very small when device font size is minimum #35787
Version Number: 1.4-36.0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Precondition: Device font size is set to minimum
Launch New Expensify app
Open any chat
Type in the composer
Send it
Expected Result:
The text in the composer has the same size as the text in the chat
Actual Result:
The text in the composer is smaller than the text in the chat
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Thanks for reporting this issue. I think we use original fontSize passed via styles but obviously this needs investigation since it changes the behavior of the composer.
The root cause of the issue was missing allowFontScaling={false} property.
Expensify app uses its own logic for font scaling so it disables operating system scaling.
Previously, composer would use RNTextInput which is a thin wrapper over built-in TextInput but with allowFontScaling={false} and some other properties already set.
In #34292, I replaced RNTextInput with MarkdownTextInput directly without any wrappers so allowFontScaling={false} property is not set. PR #35973 restores the wrapper.
Activity
github-actions commentedon Feb 4, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 4, 2024
Triggered auto assignment to @grgia (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Feb 4, 2024
We think that this bug might be related to #vip-vsp
CC @quinthar
mountiny commentedon Feb 5, 2024
Not a blocker. @lanitochka17 how does this behave in production?
kavimuru commentedon Feb 5, 2024
@mountiny this is the video from production
Screen_Recording_20240203_033512_Settings.mp4
mountiny commentedon Feb 5, 2024
cc @tomekzaw @thienlnam this might be related to the live markdown feature
thienlnam commentedon Feb 7, 2024
Looks like this is applicable to iOS as well https://expensify.slack.com/archives/C049HHMV9SM/p1707328995049399
I'll go ahead and take this over
5 remaining items
thienlnam commentedon Feb 7, 2024
@tomekzaw Are we able to scale back the font size from the setting a bit? It seems to be much smaller than iMessage
Here's iOS at the smallest font size from @AndrewGable


tomekzaw commentedon Feb 7, 2024
Thanks for reporting this issue. I think we use original
fontSizepassed via styles but obviously this needs investigation since it changes the behavior of the composer.tomekzaw commentedon Feb 12, 2024
Should be fixed with #35973.
The root cause of the issue was missing
allowFontScaling={false}property.Expensify app uses its own logic for font scaling so it disables operating system scaling.
Previously, composer would use
RNTextInputwhich is a thin wrapper over built-inTextInputbut withallowFontScaling={false}and some other properties already set.In #34292, I replaced
RNTextInputwithMarkdownTextInputdirectly without any wrappers soallowFontScaling={false}property is not set. PR #35973 restores the wrapper.cc @thienlnam
thienlnam commentedon Feb 14, 2024
PR in review
melvin-bot commentedon Feb 20, 2024
@tomekzaw, @thienlnam, @thesahindia Huh... This is 4 days overdue. Who can take care of this?
tomekzaw commentedon Feb 20, 2024
Fixed in #35973.