You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-06] [$500] There's a lot of extra space above the receipt #35921
📣 @parthvaghani! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
changed the title [-][$500] There's a lot of extra space above the receipt[/-][+][HOLD for payment 2024-06-06] [$500] There's a lot of extra space above the receipt[/+]on May 30, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
[@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@shubham1206agra] Determine if we should create a regression test for this bug.
[@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
[-]There's a lot of extra space above the receipt[/-][+][$500] There's a lot of extra space above the receipt[/+]melvin-bot commentedon Feb 6, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01afdff2fbe1dee085
melvin-bot commentedon Feb 6, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (
External)melvin-bot commentedon Feb 6, 2024
Triggered auto assignment to @miljakljajic (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.parthvaghani commentedon Feb 6, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
There's a lot of extra space above the receipt
What is the root cause of that problem?
https://github.com/Expensify/App/blob/main/src/styles/utils/index.ts#L727
What changes do you think we should make in order to solve the problem?
On L727 When we make marginTop 0, it is removing extra space above the receipt. that's where we should calculate height correctly and dynamically
melvin-bot commentedon Feb 6, 2024
📣 @parthvaghani! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
parthvaghani commentedon Feb 6, 2024
Contributor details
Your Expensify account email: vaghani98@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/pvaghani
melvin-bot commentedon Feb 6, 2024
parthvaghani commentedon Feb 6, 2024
Contributor details
Your Expensify account email: vaghani98@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/pvaghani
23 remaining items
miljakljajic commentedon Feb 23, 2024
Referenced this issue in the original, closing.
melvin-bot commentedon May 30, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-][$500] There's a lot of extra space above the receipt[/-][+][HOLD for payment 2024-06-06] [$500] There's a lot of extra space above the receipt[/+]melvin-bot commentedon May 30, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 30, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-06. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 30, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: