Skip to content

[HOLD for payment 2024-06-06] [$500] There's a lot of extra space above the receipt #35921

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: V1.4.37-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @amyevans
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707179218830079

Action Performed:

1.Initiate a request money by scanning a receipt
2.Tap the preview

Expected Result:

No extra space above the receipt image

Actual Result:

There's a lot of extra space above the receipt

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

IMG_0028

RPReplay_Final1707237277.MP4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01afdff2fbe1dee085
  • Upwork Job ID: 1754909179622940672
  • Last Price Increase: 2024-02-20
Issue OwnerCurrent Issue Owner: @miljakljajic

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 6, 2024
  2. changed the title [-]There's a lot of extra space above the receipt[/-] [+][$500] There's a lot of extra space above the receipt[/+] on Feb 6, 2024
  3. melvin-bot commented on Feb 6, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 6, 2024
  5. melvin-bot commented on Feb 6, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

  6. melvin-bot commented on Feb 6, 2024

    @melvin-bot

    Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. parthvaghani commented on Feb 6, 2024

    @parthvaghani

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    There's a lot of extra space above the receipt

    What is the root cause of that problem?

    https://github.com/Expensify/App/blob/main/src/styles/utils/index.ts#L727

    What changes do you think we should make in order to solve the problem?

    On L727 When we make marginTop 0, it is removing extra space above the receipt. that's where we should calculate height correctly and dynamically

  8. melvin-bot commented on Feb 6, 2024

    @melvin-bot

    📣 @parthvaghani! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  9. parthvaghani commented on Feb 6, 2024

    @parthvaghani

    Contributor details
    Your Expensify account email: vaghani98@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/pvaghani

  10. melvin-bot commented on Feb 6, 2024

    @melvin-bot

    ⚠️ Unable to store contributor details.

  11. parthvaghani commented on Feb 6, 2024

    @parthvaghani

    Contributor details
    Your Expensify account email: vaghani98@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/pvaghani

  12. 23 remaining items

  13. miljakljajic commented on Feb 23, 2024

    @miljakljajic
    Contributor

    Referenced this issue in the original, closing.

  14. melvin-bot commented on May 30, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 30, 2024
  16. changed the title [-][$500] There's a lot of extra space above the receipt[/-] [+][HOLD for payment 2024-06-06] [$500] There's a lot of extra space above the receipt[/+] on May 30, 2024
  17. melvin-bot commented on May 30, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  18. melvin-bot commented on May 30, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-06. 🎊

    For reference, here are some details about the assignees on this issue:

  19. melvin-bot commented on May 30, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
    • [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@shubham1206agra] Determine if we should create a regression test for this bug.
    • [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions