Skip to content

[$500] Domain name is not dropped when sending text with user mention from same domain #36347

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.40-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1.Go to staging.new.expensify.com
2. Go to any chat.
3. Send a message with mention of another user from the same private domain.

Expected Result:

The domain name is dropped because the user mention is from same domain.

Actual Result:

It shows domain name at the end of the mention in the message.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6376788_1707753873011.20240212_225341__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0190f9efc7bd55b768
  • Upwork Job ID: 1757079921886003200
  • Last Price Increase: 2024-02-12

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 12, 2024
  2. changed the title [-]Domain name is not dropped when sending text with user mention from same domain[/-] [+][$500] Domain name is not dropped when sending text with user mention from same domain[/+] on Feb 12, 2024
  3. melvin-bot commented on Feb 12, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 12, 2024
  5. added
    DeployBlockerCashThis issue or pull request should block deployment
    and removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 12, 2024
  6. melvin-bot commented on Feb 12, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

  7. melvin-bot commented on Feb 12, 2024

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  8. 25 remaining items

  9. ruben-rebelo commented on Feb 23, 2024

    @ruben-rebelo
    Contributor

    @isabelastisser I've created PR with the fix, I've just requested an Internal Review by Callstack before I open it for review.

  10. isabelastisser commented on Feb 23, 2024

    @isabelastisser
    Contributor

    Great, thanks @ruben-rebelo!

  11. puneetlath commented on Mar 5, 2024

    @puneetlath
    Contributor

    It looks like the shortened mentions don't get rendered via the live markdown preview. Is that a bug from this PR or something we just haven't implemented yet?
    IMG_19DE5EBD41FB-1

  12. allroundexperts commented on Mar 8, 2024

    @allroundexperts
    Contributor

    It looks like the shortened mentions don't get rendered via the live markdown preview. Is that a bug from this PR or something we just haven't implemented yet? IMG_19DE5EBD41FB-1

    I don't think we ever implemented this @puneetlath

  13. NikkiWines commented on Mar 8, 2024

    @NikkiWines
    Contributor

    This should've gone live as of the changes implemented in #36697 actually nvm - looking at the testing from that PR it doesn't seem like any of the mentions (shortened or not) were rendered via the live markdown preview

  14. puneetlath commented on Mar 10, 2024

    @puneetlath
    Contributor

    Ah ok, I created an issue for it here: #38025

  15. melvin-bot commented on Apr 5, 2024

    @melvin-bot

    This issue has not been updated in over 15 days. @tylerkaraszewski, @allroundexperts, @isabelastisser eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  16. melvin-bot commented on Jun 3, 2024

    @melvin-bot

    @tylerkaraszewski, @allroundexperts, @isabelastisser, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2Not a priorityReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions