Skip to content

[$1250] [HOLD for payment 2024-04-03] CRITICAL: [Track Expense] - FE - Add Track Expense Flow #36362

Closed

Description

@thienlnam

https://docs.google.com/document/d/1gACVXuJS2ojNV_hwQRBLYFK_dR7vXSNlXfTnMOsdd_w/edit#bookmark=id.jw3ehgyt25yl

First, add a beta for 'trackExpense' so this only shows up for those in the beta
Add the Track Expense Button to the FAB
This will open up the standard money request selector
Instead of choosing a participant, it will automatically select the self-DM
This will optimistically create the reportAction to the self-DM

image

Held on 36361
Held on #368199

Note: We will have to hide the Distance option on the selector - this is held on P2P distance requests which is being worked on currently (cc @neil-marcellini )

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0115a976392ebf591e
  • Upwork Job ID: 1773037718251933696
  • Last Price Increase: 2024-03-27
Issue OwnerCurrent Issue Owner: @thienlnam

Activity

  1. thienlnam commented on Feb 17, 2024

    @thienlnam
    ContributorAuthor

    cc @shubham1206agra While Ishpaul is working on the self-DM support, could you get started on this issue?

    This is holding on a few things, but there's a few things that can be done in advance like

    1. Adding the beta and Track to the global create
    2. Updating the IOU flow to skip the participant selector

    The API call is almost done, and it would be nice to test with a draft PR to make sure we're not missing anything from the BE

  2. changed the title [-][Add Track Expense] - FE - Add Track Expense Flow[/-] [+]CRITICAL: [Track Expense] - FE - Add Track Expense Flow[/+] on Feb 27, 2024
  3. quinthar commented on Feb 27, 2024

    @quinthar
    Contributor

    Hi! What's the ETA for this to be on staging?

  4. thienlnam commented on Feb 28, 2024

    @thienlnam
    ContributorAuthor

    @shubham1206agra Has a draft PR up, we're waiting on the self-DM to be merged first #36361

    Hopefully we can get something merged sometime late next week / early week after - does that sound like an accurate timeline once we have the self-DM for you to test with @shubham1206agra?

  5. shubham1206agra commented on Feb 28, 2024

    @shubham1206agra
    Contributor

    Yes sounds reasonable

  6. quinthar commented on Mar 5, 2024

    @quinthar
    Contributor

    Still on track for 3/8?

  7. shubham1206agra commented on Mar 5, 2024

    @shubham1206agra
    Contributor

    Yes, I will open this for review by today.

  8. 40 remaining items

  9. laurenreidexpensify commented on Apr 15, 2024

    @laurenreidexpensify
    Contributor

    @shubham1206agra bump to apply in Upwork please
    @ishpaul777 offer sent 👍

  10. laurenreidexpensify commented on Apr 16, 2024

    @laurenreidexpensify
    Contributor

    Payment Summary:

    $1250 - @shubham1206agra bump to apply in Upwork please
    $1250 - @ishpaul777 paid in Upwork

  11. shubham1206agra commented on Apr 18, 2024

    @shubham1206agra
    Contributor

    @laurenreidexpensify Offer accepted

  12. laurenreidexpensify commented on Apr 19, 2024

    @laurenreidexpensify
    Contributor

    Payment Summary:

    $1250 - @shubham1206agra paid in Upwork
    $1250 - @ishpaul777 paid in Upwork

  13. laurenreidexpensify commented on Apr 19, 2024

    @laurenreidexpensify
    Contributor

    @ishpaul777 can you confirm if there are any regression test steps required here?

  14. laurenreidexpensify commented on Apr 22, 2024

    @laurenreidexpensify
    Contributor

    @ishpaul777 can you confirm if there are any regression test steps required here?

  15. shubham1206agra commented on Apr 22, 2024

    @shubham1206agra
    Contributor

    @laurenreidexpensify New feature. No need for regression steps here.

  16. melvin-bot commented on Apr 22, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  17. laurenreidexpensify commented on Apr 23, 2024

    @laurenreidexpensify
    Contributor
  18. shubham1206agra commented on Apr 23, 2024

    @shubham1206agra
    Contributor

    @laurenreidexpensify The above is a false alert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsNewFeatureSomething to build that is a new item.

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions