You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$1250] [HOLD for payment 2024-04-03] CRITICAL: [Track Expense] - FE - Add Track Expense Flow #36362
First, add a beta for 'trackExpense' so this only shows up for those in the beta
Add the Track Expense Button to the FAB
This will open up the standard money request selector
Instead of choosing a participant, it will automatically select the self-DM
This will optimistically create the reportAction to the self-DM
Note: We will have to hide the Distance option on the selector - this is held on P2P distance requests which is being worked on currently (cc @neil-marcellini )
changed the title [-][Add Track Expense] - FE - Add Track Expense Flow[/-][+]CRITICAL: [Track Expense] - FE - Add Track Expense Flow[/+]on Feb 27, 2024
@shubham1206agra Has a draft PR up, we're waiting on the self-DM to be merged first #36361
Hopefully we can get something merged sometime late next week / early week after - does that sound like an accurate timeline once we have the self-DM for you to test with @shubham1206agra?
Activity
thienlnam commentedon Feb 17, 2024
cc @shubham1206agra While Ishpaul is working on the self-DM support, could you get started on this issue?
This is holding on a few things, but there's a few things that can be done in advance like
The API call is almost done, and it would be nice to test with a draft PR to make sure we're not missing anything from the BE
[-][Add Track Expense] - FE - Add Track Expense Flow[/-][+]CRITICAL: [Track Expense] - FE - Add Track Expense Flow[/+]quinthar commentedon Feb 27, 2024
Hi! What's the ETA for this to be on staging?
thienlnam commentedon Feb 28, 2024
@shubham1206agra Has a draft PR up, we're waiting on the self-DM to be merged first #36361
Hopefully we can get something merged sometime late next week / early week after - does that sound like an accurate timeline once we have the self-DM for you to test with @shubham1206agra?
shubham1206agra commentedon Feb 28, 2024
Yes sounds reasonable
quinthar commentedon Mar 5, 2024
Still on track for 3/8?
shubham1206agra commentedon Mar 5, 2024
Yes, I will open this for review by today.
40 remaining items
laurenreidexpensify commentedon Apr 15, 2024
@shubham1206agra bump to apply in Upwork please
@ishpaul777 offer sent 👍
laurenreidexpensify commentedon Apr 16, 2024
Payment Summary:
$1250 - @shubham1206agra bump to apply in Upwork please
$1250 - @ishpaul777 paid in Upwork
shubham1206agra commentedon Apr 18, 2024
@laurenreidexpensify Offer accepted
laurenreidexpensify commentedon Apr 19, 2024
Payment Summary:
$1250 - @shubham1206agra paid in Upwork
$1250 - @ishpaul777 paid in Upwork
laurenreidexpensify commentedon Apr 19, 2024
@ishpaul777 can you confirm if there are any regression test steps required here?
laurenreidexpensify commentedon Apr 22, 2024
@ishpaul777 can you confirm if there are any regression test steps required here?
shubham1206agra commentedon Apr 22, 2024
@laurenreidexpensify New feature. No need for regression steps here.
melvin-bot commentedon Apr 22, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
laurenreidexpensify commentedon Apr 23, 2024
@thienlnam ^^
shubham1206agra commentedon Apr 23, 2024
@laurenreidexpensify The above is a false alert.