You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-03-14] [Collect approvers] [$500] Offline Pay of an expense will apply even if the submitter edits an expense amount #36440
changed the title [-]Offline Pay of an expense will apply even if the submitter edits an expense amount[/-][+][$500] Offline Pay of an expense will apply even if the submitter edits an expense amount[/+]on Feb 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
[@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mananjadhav] Determine if we should create a regression test for this bug.
[@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
I tried finding the offending PR but couldn't find one. We added another property in the optimistic data, and I am not sure at what point we should've included this along with Math.abs.
But I do think we should add a regression test for this one.
Regression test for this one:
User A invites User B to Free workspace
User B submits an expense
User A goes offline
User A taps ‘Pay’ on the original expense
User B edits the expense amount OR adds an additional expense while User A is offline
User A comes back online
Confirm the money request is not paid and User A sees an error message: The requested amount has changed.
This will serve the linked duplicate issue as well.
@puneetlath Can you confirm the payout summary posted by the bot?
Activity
[-]Offline Pay of an expense will apply even if the submitter edits an expense amount[/-][+][$500] Offline Pay of an expense will apply even if the submitter edits an expense amount[/+]melvin-bot commentedon Feb 13, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01678bf0efdcb7e4a2
melvin-bot commentedon Feb 13, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)melvin-bot commentedon Feb 13, 2024
Triggered auto assignment to @puneetlath (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.puneetlath commentedon Feb 14, 2024
Asked for clarification here: https://expensify.slack.com/archives/C049HHMV9SM/p1707941200321529?thread_ts=1707832645.778869&cid=C049HHMV9SM
melvin-bot commentedon Feb 15, 2024
Current assignee @mananjadhav is eligible for the Internal assigner, not assigning anyone new.
19 remaining items
melvin-bot commentedon Mar 7, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 7, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
puneetlath commentedon Mar 13, 2024
@mananjadhav friendly reminder about the checklist so that we can pay tomorrow.
puneetlath commentedon Mar 14, 2024
@mananjadhav bump!
melvin-bot commentedon Mar 14, 2024
Payment Summary
Upwork Job
BugZero Checklist (@puneetlath)
mananjadhav commentedon Mar 15, 2024
I'll work on the checklist today.
mananjadhav commentedon Mar 15, 2024
I tried finding the offending PR but couldn't find one. We added another property in the optimistic data, and I am not sure at what point we should've included this along with
Math.abs.But I do think we should add a regression test for this one.
Regression test for this one:
The requested amount has changed.This will serve the linked duplicate issue as well.
@puneetlath Can you confirm the payout summary posted by the bot?
puneetlath commentedon Mar 16, 2024
Issue for regression test: https://github.com/Expensify/Expensify/issues/379640
I am confirming that the payment summary here is accurate. @mananjadhav please request on NewDot.
JmillsExpensify commentedon Mar 18, 2024
$500 approved for @mananjadhav based on summary.