You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-02-26] [$500] On Onfido setup, the numbers at the top can be clicked #36449
Version Number: 1.4.41-2 Reproducible in staging?: y Reproducible in production?: n (New flow) If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:
Action Performed:
Go to workspace settings
Start adding bank account manually
Proceed upto onfido page
Click on the circles at the top
Expected Result:
Should not be able to click
Actual Result:
Able to click and change status
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]On Onfido setup, the numbers at the top can be clicked[/-][+][$500] On Onfido setup, the numbers at the top can be clicked[/+]on Feb 13, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@abzokhattab Hi! Sorry for the confusion. This was a deploy blocker issue automatically labelled with External and Help Wanted labels. By contributing guidelines, if there is a regression found from your PR, the author is the one who should fix it. In this case its @MrMuzyk and other callstack devs who worked on this big feature.
We ca however, offer partial reward to contributor who offered solution that was used in the fix.
It seems like @MrMuzyk used different solution than you have proposed though so I would say no partial reward this time.
We appreciate your help and surely it will work out better next time. With Deploy blocker there is always a risk that you wont be the one picked since the PR author is more easily identifiable (but the fix is also more easily identifiable)
changed the title [-][$500] On Onfido setup, the numbers at the top can be clicked[/-][+][HOLD for payment 2024-02-26] [$500] On Onfido setup, the numbers at the top can be clicked[/+]on Feb 19, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@akinwale / @Ollyws] The PR that introduced the bug has been identified. Link to the PR:
[@akinwale / @Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@akinwale / @Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@akinwale / @Ollyws] Determine if we should create a regression test for this bug.
[@akinwale / @Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
[-]On Onfido setup, the numbers at the top can be clicked[/-][+][$500] On Onfido setup, the numbers at the top can be clicked[/+]melvin-bot commentedon Feb 13, 2024
Job added to Upwork: https://www.upwork.com/jobs/~017f9176469aeb0a7d
melvin-bot commentedon Feb 13, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)melvin-bot commentedon Feb 13, 2024
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Feb 13, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
18 remaining items
mountiny commentedon Feb 14, 2024
@abzokhattab Hi! Sorry for the confusion. This was a deploy blocker issue automatically labelled with External and Help Wanted labels. By contributing guidelines, if there is a regression found from your PR, the author is the one who should fix it. In this case its @MrMuzyk and other callstack devs who worked on this big feature.
We ca however, offer partial reward to contributor who offered solution that was used in the fix.
mountiny commentedon Feb 14, 2024
It seems like @MrMuzyk used different solution than you have proposed though so I would say no partial reward this time.
We appreciate your help and surely it will work out better next time. With Deploy blocker there is always a risk that you wont be the one picked since the PR author is more easily identifiable (but the fix is also more easily identifiable)
abzokhattab commentedon Feb 14, 2024
okay thank you so much for the clarification
mountiny commentedon Feb 14, 2024
PR was CPed this is resolved
[-][$500] On Onfido setup, the numbers at the top can be clicked[/-][+][HOLD for payment 2024-02-26] [$500] On Onfido setup, the numbers at the top can be clicked[/+]melvin-bot commentedon Feb 19, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 19, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-02-26. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 19, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: