Skip to content

[HOLD for payment 2024-02-26] [$500] On Onfido setup, the numbers at the top can be clicked #36449

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.41-2
Reproducible in staging?: y
Reproducible in production?: n (New flow)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to workspace settings
  2. Start adding bank account manually
  3. Proceed upto onfido page
  4. Click on the circles at the top

Expected Result:

Should not be able to click

Actual Result:

Able to click and change status

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

20240214_053031.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017f9176469aeb0a7d
  • Upwork Job ID: 1757552549986205696
  • Last Price Increase: 2024-02-13
  • Automatic offers:
    • Ollyws | Reviewer | 0
    • akinwale | Contributor | 0

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 13, 2024
  2. changed the title [-]On Onfido setup, the numbers at the top can be clicked[/-] [+][$500] On Onfido setup, the numbers at the top can be clicked[/+] on Feb 13, 2024
  3. melvin-bot commented on Feb 13, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 13, 2024
  5. melvin-bot commented on Feb 13, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

  6. melvin-bot commented on Feb 13, 2024

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. github-actions commented on Feb 13, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. 18 remaining items

  9. mountiny commented on Feb 14, 2024

    @mountiny
    Contributor

    @abzokhattab Hi! Sorry for the confusion. This was a deploy blocker issue automatically labelled with External and Help Wanted labels. By contributing guidelines, if there is a regression found from your PR, the author is the one who should fix it. In this case its @MrMuzyk and other callstack devs who worked on this big feature.

    We ca however, offer partial reward to contributor who offered solution that was used in the fix.

  10. mountiny commented on Feb 14, 2024

    @mountiny
    Contributor

    It seems like @MrMuzyk used different solution than you have proposed though so I would say no partial reward this time.

    We appreciate your help and surely it will work out better next time. With Deploy blocker there is always a risk that you wont be the one picked since the PR author is more easily identifiable (but the fix is also more easily identifiable)

  11. abzokhattab commented on Feb 14, 2024

    @abzokhattab
    Contributor

    okay thank you so much for the clarification

  12. mountiny commented on Feb 14, 2024

    @mountiny
    Contributor

    PR was CPed this is resolved

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Feb 19, 2024
  14. changed the title [-][$500] On Onfido setup, the numbers at the top can be clicked[/-] [+][HOLD for payment 2024-02-26] [$500] On Onfido setup, the numbers at the top can be clicked[/+] on Feb 19, 2024
  15. melvin-bot commented on Feb 19, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Feb 19, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-02-26. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on Feb 19, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@akinwale / @Ollyws] The PR that introduced the bug has been identified. Link to the PR:
    • [@akinwale / @Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@akinwale / @Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@akinwale / @Ollyws] Determine if we should create a regression test for this bug.
    • [@akinwale / @Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions