Skip to content

[$500][MEDIUM] Bank account - Fields are empty after navigating back to add BA modal #36450

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.41-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Pre-requisite: the user must be logged in and have created a workspace.

  1. Go to Workspace > Bank account.
  2. Select "Connect manually".
  3. Enter the routing number and account number.
  4. Tap on the back arrow.
  5. Navigate back to the Add bank account modal > Manual option.

Expected Result:

The data entered before should remain on the fields.

Actual Result:

The fields are empty.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6378775_1707868433137.Bmzd4213_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016f94e09a4ab6f001
  • Upwork Job ID: 1757555443937619968
  • Last Price Increase: 2024-02-14

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 14, 2024
  2. changed the title [-]Bank account - Fields are empty after navigating back to add BA modal[/-] [+][$500] Bank account - Fields are empty after navigating back to add BA modal[/+] on Feb 14, 2024
  3. melvin-bot commented on Feb 14, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 14, 2024
  5. melvin-bot commented on Feb 14, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

  6. melvin-bot commented on Feb 14, 2024

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. 7 remaining items

  8. mountiny commented on Feb 14, 2024

    @mountiny
    Contributor

    I dont think this is a blocker, we should investigate the root cause however, @barttom @shubham1206agra @MrMuzyk

  9. jeremy-croff commented on Feb 14, 2024

    @jeremy-croff
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    We are clearing the first screens bank info on initial load

    What is the root cause of that problem?

    We starting doing this since: bf43cc4
    The code specifically instructs to clear the bank page screen on initial load.
    because of: #31121 (comment)

    They wanted it to reset to prevent this scenario and being stuck.

    What changes do you think we should make in order to solve the problem?

    I think we should remove the removeExistingBankAccountDetails logic.
    After reviewing the issue, it seems like an edge case that the user is able to recover from.

    What alternative solutions did you explore? (Optional)

  10. jeremy-croff commented on Feb 14, 2024

    @jeremy-croff
    Contributor

    We can handle that edge case in a seperate ticket if desired, to reset if the user is in that step and the information is not passing validation.

  11. mountiny commented on Feb 14, 2024

    @mountiny
    Contributor

    Thanks I agree this is an edge case for now.

  12. akinwale commented on Feb 14, 2024

    @akinwale
    Contributor

    @jeremy-croff Your proposed solution does not fix the core issue here which is that the data is not being saved after manually entering text in the input fields.

  13. shubham1206agra commented on Feb 14, 2024

    @shubham1206agra
    Contributor

    @mountiny Should we consider this a bug at all? I am more inclined to do nothing here.

  14. jeremy-croff commented on Feb 14, 2024

    @jeremy-croff
    Contributor

    @jeremy-croff Your proposed solution does not fix the core issue here which is that the data is not being saved after manually entering text in the input fields.

    I see my mistake now!
    however it does address this flow:

    2024-02-14_00-42-23.mp4
  15. jeremy-croff commented on Feb 14, 2024

    @jeremy-croff
    Contributor

    Rechecked, and confirmed that in conjuction with the previous line - we also have to remove

    ReimbursementAccountUtils.updateReimbursementAccountDraft(bankAccountData);
    line for OP

  16. MrMuzyk commented on Feb 14, 2024

    @MrMuzyk
    Contributor

    I believe this is intended behaviour.

    @nkuoch Can you confirm that?

  17. changed the title [-][$500] Bank account - Fields are empty after navigating back to add BA modal[/-] [+][$500][MEDIUM] Bank account - Fields are empty after navigating back to add BA modal[/+] on Feb 14, 2024
  18. mountiny commented on Feb 14, 2024

    @mountiny
    Contributor

    Checked again and I agree, we saving these values only once submitted so this would be a feature request more than a bug now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions