You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500][MEDIUM] Bank account - Fields are empty after navigating back to add BA modal #36450
Version Number: 1.4.41-2 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: applause internal team Slack conversation:
Action Performed:
Pre-requisite: the user must be logged in and have created a workspace.
Go to Workspace > Bank account.
Select "Connect manually".
Enter the routing number and account number.
Tap on the back arrow.
Navigate back to the Add bank account modal > Manual option.
Expected Result:
The data entered before should remain on the fields.
Actual Result:
The fields are empty.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Bank account - Fields are empty after navigating back to add BA modal[/-][+][$500] Bank account - Fields are empty after navigating back to add BA modal[/+]on Feb 14, 2024
Please re-state the problem that we are trying to solve in this issue.
We are clearing the first screens bank info on initial load
What is the root cause of that problem?
We starting doing this since: bf43cc4
The code specifically instructs to clear the bank page screen on initial load.
because of: #31121 (comment)
They wanted it to reset to prevent this scenario and being stuck.
What changes do you think we should make in order to solve the problem?
I think we should remove the removeExistingBankAccountDetails logic.
After reviewing the issue, it seems like an edge case that the user is able to recover from.
What alternative solutions did you explore? (Optional)
@jeremy-croff Your proposed solution does not fix the core issue here which is that the data is not being saved after manually entering text in the input fields.
@jeremy-croff Your proposed solution does not fix the core issue here which is that the data is not being saved after manually entering text in the input fields.
I see my mistake now!
however it does address this flow:
changed the title [-][$500] Bank account - Fields are empty after navigating back to add BA modal[/-][+][$500][MEDIUM] Bank account - Fields are empty after navigating back to add BA modal[/+]on Feb 14, 2024
Activity
[-]Bank account - Fields are empty after navigating back to add BA modal[/-][+][$500] Bank account - Fields are empty after navigating back to add BA modal[/+]melvin-bot commentedon Feb 14, 2024
Job added to Upwork: https://www.upwork.com/jobs/~016f94e09a4ab6f001
melvin-bot commentedon Feb 14, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (
External)melvin-bot commentedon Feb 14, 2024
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.7 remaining items
mountiny commentedon Feb 14, 2024
I dont think this is a blocker, we should investigate the root cause however, @barttom @shubham1206agra @MrMuzyk
jeremy-croff commentedon Feb 14, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
We are clearing the first screens bank info on initial load
What is the root cause of that problem?
We starting doing this since: bf43cc4
The code specifically instructs to clear the bank page screen on initial load.
because of: #31121 (comment)
They wanted it to reset to prevent this scenario and being stuck.
What changes do you think we should make in order to solve the problem?
I think we should remove the removeExistingBankAccountDetails logic.
After reviewing the issue, it seems like an edge case that the user is able to recover from.
What alternative solutions did you explore? (Optional)
jeremy-croff commentedon Feb 14, 2024
We can handle that edge case in a seperate ticket if desired, to reset if the user is in that step and the information is not passing validation.
mountiny commentedon Feb 14, 2024
Thanks I agree this is an edge case for now.
akinwale commentedon Feb 14, 2024
@jeremy-croff Your proposed solution does not fix the core issue here which is that the data is not being saved after manually entering text in the input fields.
shubham1206agra commentedon Feb 14, 2024
@mountiny Should we consider this a bug at all? I am more inclined to do nothing here.
jeremy-croff commentedon Feb 14, 2024
I see my mistake now!
however it does address this flow:
2024-02-14_00-42-23.mp4
jeremy-croff commentedon Feb 14, 2024
Rechecked, and confirmed that in conjuction with the previous line - we also have to remove
App/src/pages/ReimbursementAccount/BankInfo/BankInfo.tsx
Line 117 in 023d62c
MrMuzyk commentedon Feb 14, 2024
I believe this is intended behaviour.
@nkuoch Can you confirm that?
[-][$500] Bank account - Fields are empty after navigating back to add BA modal[/-][+][$500][MEDIUM] Bank account - Fields are empty after navigating back to add BA modal[/+]mountiny commentedon Feb 14, 2024
Checked again and I agree, we saving these values only once submitted so this would be a feature request more than a bug now