You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-03-07] [$500] Workspace - Tap connect BA in reimbursements & tap app back button unable to go LHN #36460
Version Number: 1.4.41 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Tapping on connect back account in reimbursement page, and tapping app back button, user must be able to navigate to LHN
Actual Result:
Tapping on connect back account in reimbursement page, and tapping app back button unable to navigate to LHN. User is directed to "connect bank account" & "workspaces" page repeatedly instead of LHN when tapping app back button
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Workspace - Tap connect BA in reimbursements & tap app back button unable to go LHN[/-][+][$500] Workspace - Tap connect BA in reimbursements & tap app back button unable to go LHN[/+]on Feb 14, 2024
changed the title [-][$500] Workspace - Tap connect BA in reimbursements & tap app back button unable to go LHN[/-][+][HOLD for payment 2024-03-07] [$500] Workspace - Tap connect BA in reimbursements & tap app back button unable to go LHN[/+]on Feb 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
[@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@jjcoffee] Determine if we should create a regression test for this bug.
[@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [Wave 8] Ideal nav #33280 (comment)
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - massive PR so unavoidable to have a few mistakes
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Tap settings icon
Tap Workspaces
Tap on a workspace which has non-USD default currency
Activity
[-]Workspace - Tap connect BA in reimbursements & tap app back button unable to go LHN[/-][+][$500] Workspace - Tap connect BA in reimbursements & tap app back button unable to go LHN[/+]melvin-bot commentedon Feb 14, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01a0fc2f48cc03bdf1
melvin-bot commentedon Feb 14, 2024
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Feb 14, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (
External)lanitochka17 commentedon Feb 14, 2024
We think that this bug might be related to #vip-vsp
CC @quinthar
abzokhattab commentedon Feb 14, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Tap connect BA in reimbursements & tap app back button unable to go LHN
What is the root cause of that problem?
the go-back behavior when we have the following dialog is not the same when we have USD currency set.
App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js
Line 471 in 9f060e6
What changes do you think we should make in order to solve the problem?
we need to change the
onBackButtonPressin the prev component to be the same asContinueBankAccountSetupcomponent :App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js
Lines 486 to 489 in 9f060e6
ntdiary commentedon Feb 14, 2024
Hey, @trjExpensify, I'm OOO until Feb 18th, could you please reassign another c+? :)
jjcoffee commentedon Feb 14, 2024
Happy to take this one over @trjExpensify 🙇
trjExpensify commentedon Feb 14, 2024
This is likely ideal-nav related with goBack, so wave8 is more appropriate. CC: @adamgrzybowski @hayata-suenaga is this on the radar somewhere?
27 remaining items
trjExpensify commentedon Feb 27, 2024
Thanks, @jjcoffee! Over to you, @grgia. :)
[-][$500] Workspace - Tap connect BA in reimbursements & tap app back button unable to go LHN[/-][+][HOLD for payment 2024-03-07] [$500] Workspace - Tap connect BA in reimbursements & tap app back button unable to go LHN[/+]melvin-bot commentedon Feb 29, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-07. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 29, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
jjcoffee commentedon Mar 7, 2024
Regression Test Proposal
Do we agree 👍 or 👎
trjExpensify commentedon Mar 7, 2024
Thanks!
Payment summary as follows:
Going to hold off on the regression test, as we're changing that flow now, so we're in the process of updating with the new workspace editor.