Skip to content

[$500] Improve Tab Navigation & Accessibility #36476

Closed

Description

@kosmydel

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Latest
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL: N/A
Issue reported by: me
Slack conversation: N/A

Action Performed:

  1. Open report.
  2. Click the user avatar (next to the message).
  3. The RHP opens.
  4. Try to tab navigate.

Expected Result:

You should navigate only inside the RHP modal. You shouldn't be able to escape it (unless you press escape/back button). This would improve the accessibility for users with visual disabilities.

Actual Result:

You can navigate outside the RHP modal.

Workaround:

N / A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-02-14.at.13.09.16.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01681c9914c65b84bc
  • Upwork Job ID: 1758337605760794624
  • Last Price Increase: 2024-02-16
  • Automatic offers:
    • c3024 | Reviewer | 0
    • fedirjh | Contributor | 0
Issue OwnerCurrent Issue Owner: @isabelastisser

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 14, 2024
  2. melvin-bot commented on Feb 14, 2024

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. kosmydel commented on Feb 14, 2024

    @kosmydel
    ContributorAuthor

    Coming from here.
    cc @roryabraham


    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Users can navigate outside the RHP modal using the Tab/Shift+Tab.

    What is the root cause of that problem?

    We are not using FocusTrap on the RHP modals.

    What changes do you think we should make in order to solve the problem?

    Just add the focus trap like in this PR.

    What alternative solutions did you explore? (Optional)

    N/A

  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 16, 2024
  5. changed the title [-]Improve Tab Navigation & Accessibility[/-] [+][$500] Improve Tab Navigation & Accessibility[/+] on Feb 16, 2024
  6. melvin-bot commented on Feb 16, 2024

    @melvin-bot
  7. melvin-bot commented on Feb 16, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

  8. added and removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 19, 2024
  9. 104 remaining items

  10. roryabraham commented on Jul 23, 2024

    @roryabraham
    Contributor

    sorry about that @fedirjh

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Jul 23, 2024
  12. isabelastisser commented on Jul 29, 2024

    @isabelastisser
    Contributor

    Payment summary:

    @fedirjh $500 for C+ review. Pending via NewDot.

    @fedirjh, can you please confirm this is correct? Thanks!

  13. fedirjh commented on Aug 5, 2024

    @fedirjh
    Contributor

    @isabelastisser Yep all good. I have requested payment in NewDot.

  14. JmillsExpensify commented on Aug 5, 2024

    @JmillsExpensify
    Contributor

    $500 approved for @fedirjh

  15. isabelastisser commented on Aug 5, 2024

    @isabelastisser
    Contributor

    All set. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions