You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Version Number: Latest Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): N/A Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: N/A Issue reported by: me Slack conversation: N/A
Action Performed:
Open report.
Click the user avatar (next to the message).
The RHP opens.
Try to tab navigate.
Expected Result:
You should navigate only inside the RHP modal. You shouldn't be able to escape it (unless you press escape/back button). This would improve the accessibility for users with visual disabilities.
Actual Result:
You can navigate outside the RHP modal.
Workaround:
N / A
Platforms:
Which of our officially supported platforms is this issue occurring on?
Activity
melvin-bot commentedon Feb 14, 2024
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.kosmydel commentedon Feb 14, 2024
Coming from here.
cc @roryabraham
Proposal
Please re-state the problem that we are trying to solve in this issue.
Users can navigate outside the RHP modal using the Tab/Shift+Tab.
What is the root cause of that problem?
We are not using FocusTrap on the RHP modals.
What changes do you think we should make in order to solve the problem?
Just add the focus trap like in this PR.
What alternative solutions did you explore? (Optional)
N/A
[-]Improve Tab Navigation & Accessibility[/-][+][$500] Improve Tab Navigation & Accessibility[/+]melvin-bot commentedon Feb 16, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01681c9914c65b84bc
melvin-bot commentedon Feb 16, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (
External)104 remaining items
roryabraham commentedon Jul 23, 2024
sorry about that @fedirjh
isabelastisser commentedon Jul 29, 2024
Payment summary:
@fedirjh $500 for C+ review. Pending via NewDot.
@fedirjh, can you please confirm this is correct? Thanks!
fedirjh commentedon Aug 5, 2024
@isabelastisser Yep all good. I have requested payment in NewDot.
JmillsExpensify commentedon Aug 5, 2024
$500 approved for @fedirjh
isabelastisser commentedon Aug 5, 2024
All set. Closing!