You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] IOU - In distance request confirmation page, location access permission box is shown. #36491
changed the title [-]IOU - In distance request confirmation page, location access permission box is shown.[/-][+][$500] IOU - In distance request confirmation page, location access permission box is shown.[/+]on Feb 14, 2024
It will call getCurrentPosition which will request the location permission. The map view is also placed on the confirmation page, so when we visit the confirmation page, the permission dialog will be shown (no need to perform the long step).
What changes do you think we should make in order to solve the problem?
I think we don't need to get the current position anymore on the confirmation page, so we can introduce a new prop to ignore the getCurrentPosition call and set the current position from the initialState.
if (useInitialStatePosition) {
setCurrentPosition({longitude: initialState.location[0], latitude: initialState.location[1]});
return;
}
Oh true, its been live since feb 28th so this is past the 7 day regression period. I'm unsure why the GH title didn't change here. Might have been a bug.
I don't think anything is pending here. @kevinksullivan can you handle the payment and close out this issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
[-]IOU - In distance request confirmation page, location access permission box is shown.[/-][+][$500] IOU - In distance request confirmation page, location access permission box is shown.[/+]melvin-bot commentedon Feb 14, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01898dd3cbc3df8779
melvin-bot commentedon Feb 14, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)melvin-bot commentedon Feb 14, 2024
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.lanitochka17 commentedon Feb 14, 2024
We think that this bug might be related to #wave5
CC @dylanexpensify
esh-g commentedon Feb 14, 2024
Proposal
Please re-state the problem we are trying to solve
In distance request confirmation page, location access permission box is shown
What is the root cause of this problem?
The root cause is that we try to get the current position of the user for every render for
MapVieweven if we don't need it in thisuseEffecthere:App/src/components/MapView/MapView.tsx
Line 46 in 2e3840f
What changes should be made to fix this?
We should only try to get the current location of the user if
shouldPanMapToCurrentLocationistrueApp/src/components/MapView/MapView.tsx
Line 68 in 2e3840f
bernhardoj commentedon Feb 14, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
In distance confirmation page, a location permission dialog shows.
What is the root cause of that problem?
The map view component has a
useFocusEffectthat will be triggered every time the page is focused.App/src/components/MapView/MapView.tsx
Lines 35 to 46 in 9b7e310
It will call
getCurrentPositionwhich will request the location permission. The map view is also placed on the confirmation page, so when we visit the confirmation page, the permission dialog will be shown (no need to perform the long step).What changes do you think we should make in order to solve the problem?
I think we don't need to get the current position anymore on the confirmation page, so we can introduce a new prop to ignore the
getCurrentPositioncall and set the current position from theinitialState.s77rt commentedon Feb 15, 2024
@esh-g Thanks for the proposal. Your RCA is about right. The solution looks good to me.
🎀 👀 🎀 C+ reviewed
Link to proposal
s77rt commentedon Feb 15, 2024
@bernhardoj Thanks for the proposal. Your RCA is about right. As for the solution, I don't think we need a new prop here
22 remaining items
chiragsalian commentedon Mar 12, 2024
Oh true, its been live since feb 28th so this is past the 7 day regression period. I'm unsure why the GH title didn't change here. Might have been a bug.
I don't think anything is pending here.
@kevinksullivan can you handle the payment and close out this issue.
melvin-bot commentedon Apr 5, 2024
This issue has not been updated in over 15 days. @chiragsalian, @s77rt, @kevinksullivan, @esh-g eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
s77rt commentedon Apr 5, 2024
This is due payment
chiragsalian commentedon Apr 9, 2024
Friendly bump @kevinksullivan, to handle payment.
melvin-bot commentedon Jun 6, 2024
@chiragsalian, @s77rt, @kevinksullivan, @esh-g, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.
s77rt commentedon Jun 6, 2024
Only Melvin got paid. This is still due payment
chiragsalian commentedon Jun 10, 2024
@kevinksullivan / @mallenexpensify, can one of you handle payment for @s77rt over here.
mallenexpensify commentedon Jun 11, 2024
Contributor: @esh-g paid $500 via Upwork
Contributor+: @s77rt paid $500 via Upwork.
Sorry it took forever. If you ever see a
Reviewinglabel on an issue when it's awaiting payment, please comment and ask for it to be removed