Skip to content

[HOLD for payment 2024-03-22] [Wave Collect] [Ideal Nav] Ideal Nav v2 changes #36656

Closed

Description

@JmillsExpensify

Background

Now that we've lived with Ideal Nav for a week, we've experienced the following issues with the core design:

  • Accessing a workspace via the 🔧 resulted in a "lateral," global switch of someone's workspace. This was confusing because we created one known, obvious way to switch a worked – the workspace switcher – and then one secret, confusing way to "laterally" switch a workspace by choosing it in Settings.
  • Account settings was accessed via an avatar in the top right, whereas workspace settings was accessed in the 🔧 bottom tab. Though now that we're deprecating "lateral" switching, separating these two types of settings pages is no longer necessary. Let's combine them in one central place.
  • Finally, while we aspire to have feature-rich global search, today our "search" is merely a chat switcher. As a result, it doesn't deserve the prominence that we've given it.

Summary of changes

All in all these and other experiences have encouraged us to tweak the core Ideal Nav designs via the following v2 changes:

Header

  • The workspace switcher, workspace name and page name all share the same line in the header.
  • Additionally, the search input becomes a magnifying glass icon is only appears the header for the Chats tab (as again, the only "search" we have is a chat switcher).
    image

Bottom Tab

  • The 🔧 is replaced by a 28x28 user avatar, which reveals a new Settings page that combines account settings as well as workspace settings
    image

Settings

  • The new combined Settings page has three main sections: Account, Workspaces and General.
    image

  • A 100x100 user account avatar appear at the top of the Settings, with a "share code" icon in the top left and a "status" icon in the top right. The "share code" icon replaces the previous push row, while "status" displays a user's status, should one exist. Tapping the "status" icon takes the user to https://new.expensify.com/settings/profile/status.

    • Screenshot 2024-02-15 at 22 17 38
  • Account is the first section in Settings, and includes nav items for Profile, Wallet, Preferences and Security

    • Screenshot 2024-02-15 at 22 18 05
  • Workspaces is the second section in Settings, and includes nav items for Workspaces, Subscription, and Cards & Domains.

    • Screenshot 2024-02-15 at 22 23 48
  • General is the last section in Settings, and includes nav items for Switch to Expensify Classic, Help, About and `Sign out.

    • Screenshot 2024-02-15 at 22 20 03

Workspaces

  • The Workspaces page has two states, depending on whether a user is a member of a workspace or not.
    image
  • When viewing a specific workspace's settings, we launch a full screen experience, which pushes the workspace setup pages in the the LHN. No bottom tabs appear in this view.
    image
  • To exit out of the full screen workspace editor, a user would click the back caret in the LHN header, which takes them to https://new.expensify.com/settings/workspaces.
  • Mobile views shown below for extra clarity.
    image

Individual Issues

[This space can be used if we opt to break up this initiative into individual issues and corresponding PRs]

Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. melvin-bot commented on Feb 16, 2024

    @melvin-bot

    Current assignees @JmillsExpensify and @trjExpensify are eligible for the NewFeature assigner, not assigning anyone new.

  2. JmillsExpensify commented on Feb 16, 2024

    @JmillsExpensify
    ContributorAuthor

    Note: This issue is for internal use and the corresponding implementation to be handled by SWM.

  3. moved this to Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) in [#whatsnext] Wave 08 - Collect Plan Adminson Feb 16, 2024
  4. trjExpensify commented on Feb 16, 2024

    @trjExpensify
    Contributor

    Nice!!

    Bottom Tab

    • The 🔧 is replaced by a 28x28 user avatar, which reveals a new Settings page that combines account settings as well as workspace settings
      image

    What about the active state of the settings bottom tab. We're giving the avatar a green ring, right @shawnborton?

  5. shawnborton commented on Feb 16, 2024

    @shawnborton
    Contributor

    That's right, I can update the images above.

  6. trjExpensify commented on Feb 16, 2024

    @trjExpensify
    Contributor

    Perf, thanks!

  7. 63 remaining items

  8. JmillsExpensify commented on Mar 27, 2024

    @JmillsExpensify
    ContributorAuthor

    Ah thanks, that's not captured in the payment summary above. Is there an existing Upwork job for you?

  9. JmillsExpensify commented on Mar 27, 2024

    @JmillsExpensify
    ContributorAuthor

    Looks like we have regressions to account for as well.

  10. mkhutornyi commented on Mar 27, 2024

    @mkhutornyi
    Contributor

    Ah thanks, that's not captured in the payment summary above. Is there an existing Upwork job for you?

    No job created

  11. JmillsExpensify commented on Mar 27, 2024

    @JmillsExpensify
    ContributorAuthor

    Payment summary: $500 to @mkhutornyi for PR review and testing.

  12. mkhutornyi commented on Mar 27, 2024

    @mkhutornyi
    Contributor

    There were regressions, but can we keep standard rate since this was big PR?

  13. hayata-suenaga commented on Mar 27, 2024

    @hayata-suenaga
    Contributor

    I agree @mkhutornyi this PR was quite a huge. we should at least have the standard rate.

    @JmillsExpensify I'm sorry I should have provided a note about it before 🙇

  14. mountiny commented on Mar 27, 2024

    @mountiny
    Contributor

    Yep I agree with updated summary of $500 for @mkhutornyi for reviewing #37421 which was large PR and hard to catch all the regressions.

  15. JmillsExpensify commented on Mar 27, 2024

    @JmillsExpensify
    ContributorAuthor

    Cool, updated!

  16. JmillsExpensify commented on Mar 27, 2024

    @JmillsExpensify
    ContributorAuthor

    @mkhutornyi I just sent you an offer on Upwork.

  17. mountiny commented on Mar 29, 2024

    @mountiny
    Contributor

    I believe @mkhutornyi is out for medical reasons. We can keep this monthly open unless you have confirmed its paid up @JmillsExpensify

  18. mkhutornyi commented on Mar 30, 2024

    @mkhutornyi
    Contributor

    I accepted offer

  19. mountiny commented on Apr 2, 2024

    @mountiny
    Contributor

    @JmillsExpensify @mkhutornyi can this be closed?

  20. JmillsExpensify commented on Apr 3, 2024

    @JmillsExpensify
    ContributorAuthor

    Yes!

  21. moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collecton Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

MonthlyKSv2NewFeatureSomething to build that is a new item.

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions