Skip to content

[$500] [HOLD for payment 2024-03-07] [Performance] Use Intl Collator instead of the string localeCompare #36795

Closed

Description

@mountiny

Coming from Slack

### Problem
Lots of app critical metrics (TTI, input delay etc.) are hindered because of weak performance inside Prototype.string.localeCompare function in Hermes engine.

### Solution
Based on Hur's investigations, we can improve performance by swapping out localeCompare with Intl.Collator implementation.

More details are available in the linked analysis issue.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01af6fd0b61753f3bb
  • Upwork Job ID: 1765747002690428928
  • Last Price Increase: 2024-03-07

Activity

  1. self-assigned this
    on Feb 19, 2024
  2. kacper-mikolajczak commented on Feb 19, 2024

    @kacper-mikolajczak
    Contributor

    Hi @mountiny 👋

  3. mountiny commented on Feb 19, 2024

    @mountiny
    ContributorAuthor

    Follow up from the PR:

    • create uni tests for the new util libs
    • create a plan to remove the string.localeCompare from other parts of the app

    @kacper-mikolajczak would look into this tomorrow

  4. kacper-mikolajczak commented on Feb 20, 2024

    @kacper-mikolajczak
    Contributor

    create uni tests for the new util libs

    PR for tests: #36879

    create a plan to remove the string.localeCompare from other parts of the app

    With this, I will wait till we have 100% sure that there are no regressions and actual performance gains in the app. What do you think @mountiny ?

  5. mountiny commented on Feb 20, 2024

    @mountiny
    ContributorAuthor

    I will wait till we have 100% sure that there are no regressions and actual performance gains in the app

    We can wait a bit, we saw that there are performance gains in the tests and your analysis. How do you want to measure that there are some improvements thanks to this?

  6. 16 remaining items

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 7, 2024
  8. changed the title [-][HOLD for payment 2024-03-07] [Performance] Use Intl Collator instead of the string localeCompare[/-] [+][$500] [HOLD for payment 2024-03-07] [Performance] Use Intl Collator instead of the string localeCompare[/+] on Mar 7, 2024
  9. melvin-bot commented on Mar 7, 2024

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 7, 2024
  11. melvin-bot commented on Mar 7, 2024

    @melvin-bot

    Current assignee @hoangzinh is eligible for the External assigner, not assigning anyone new.

  12. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 7, 2024
  13. mountiny commented on Mar 7, 2024

    @mountiny
    ContributorAuthor

    @zanyrenney this is ready for payment $500 to @hoangzinh

  14. zanyrenney commented on Mar 7, 2024

    @zanyrenney
    Contributor

    please apply to the job on upwork @hoangzinh

  15. hoangzinh commented on Mar 7, 2024

    @hoangzinh
    Contributor

    Applied. Thanks @mountiny @zanyrenney

  16. zanyrenney commented on Mar 7, 2024

    @zanyrenney
    Contributor

    sent offer

  17. hoangzinh commented on Mar 8, 2024

    @hoangzinh
    Contributor

    Accepted. Thanks @zanyrenney

  18. zanyrenney commented on Mar 8, 2024

    @zanyrenney
    Contributor

    payment summary

    paid $500 via upwork to @hoangzinh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.Task

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions