You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] [HOLD for payment 2024-03-07] [Performance] Use Intl Collator instead of the string localeCompare #36795
### Problem
Lots of app critical metrics (TTI, input delay etc.) are hindered because of weak performance inside Prototype.string.localeCompare function in Hermes engine.
### Solution Based on Hur's investigations, we can improve performance by swapping out localeCompare with Intl.Collator implementation.
I will wait till we have 100% sure that there are no regressions and actual performance gains in the app
We can wait a bit, we saw that there are performance gains in the tests and your analysis. How do you want to measure that there are some improvements thanks to this?
changed the title [-][HOLD for payment 2024-03-07] [Performance] Use Intl Collator instead of the string localeCompare[/-][+][$500] [HOLD for payment 2024-03-07] [Performance] Use Intl Collator instead of the string localeCompare[/+]on Mar 7, 2024
Activity
kacper-mikolajczak commentedon Feb 19, 2024
Hi @mountiny 👋
mountiny commentedon Feb 19, 2024
Follow up from the PR:
@kacper-mikolajczak would look into this tomorrow
kacper-mikolajczak commentedon Feb 20, 2024
PR for tests: #36879
With this, I will wait till we have 100% sure that there are no regressions and actual performance gains in the app. What do you think @mountiny ?
mountiny commentedon Feb 20, 2024
We can wait a bit, we saw that there are performance gains in the tests and your analysis. How do you want to measure that there are some improvements thanks to this?
16 remaining items
[-][HOLD for payment 2024-03-07] [Performance] Use Intl Collator instead of the string localeCompare[/-][+][$500] [HOLD for payment 2024-03-07] [Performance] Use Intl Collator instead of the string localeCompare[/+]melvin-bot commentedon Mar 7, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01af6fd0b61753f3bb
melvin-bot commentedon Mar 7, 2024
Current assignee @hoangzinh is eligible for the External assigner, not assigning anyone new.
mountiny commentedon Mar 7, 2024
@zanyrenney this is ready for payment $500 to @hoangzinh
zanyrenney commentedon Mar 7, 2024
please apply to the job on upwork @hoangzinh
hoangzinh commentedon Mar 7, 2024
Applied. Thanks @mountiny @zanyrenney
zanyrenney commentedon Mar 7, 2024
sent offer
hoangzinh commentedon Mar 8, 2024
Accepted. Thanks @zanyrenney
zanyrenney commentedon Mar 8, 2024
payment summary
paid $500 via upwork to @hoangzinh