Skip to content

[HOLD for payment 2024-03-10] [$250] Clean up lounge related code #36796

Closed

Description

@mountiny

Problem

Lounge access is no longer handled through the App. However, the code to manage the lounge access stays around. For unfamiliar engineer it might lead to confusion as to whether this code is still used or not

Why is it important

This is leaving unused code around in the codebase

Solution

Remove any code related to lounge access to remove any confusion.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c6696797695c6c34
  • Upwork Job ID: 1759532890543009792
  • Last Price Increase: 2024-02-19

Activity

  1. self-assigned this
    on Feb 19, 2024
  2. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 19, 2024
  3. changed the title [-]Clean up lounge related code[/-] [+][$500] Clean up lounge related code[/+] on Feb 19, 2024
  4. melvin-bot commented on Feb 19, 2024

    @melvin-bot
  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 19, 2024
  6. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 19, 2024
  7. melvin-bot commented on Feb 19, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

  8. 19 remaining items

  9. melvin-bot commented on Mar 8, 2024

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  10. mountiny commented on Mar 8, 2024

    @mountiny
    ContributorAuthor
  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Mar 8, 2024
  12. changed the title [-][$250] Clean up lounge related code[/-] [+][HOLD for payment 2024-04-10] [$250] Clean up lounge related code[/+] on Mar 8, 2024
  13. changed the title [-][HOLD for payment 2024-04-10] [$250] Clean up lounge related code[/-] [+][HOLD for payment 2024-03-10] [$250] Clean up lounge related code[/+] on Mar 8, 2024
  14. parasharrajat commented on Mar 10, 2024

    @parasharrajat
    Member

    We can close this after posting the summary. I will request it later. Thanks.

  15. melvin-bot commented on Mar 10, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@twisterdotcom)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1759532890543009792/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  16. mountiny commented on Mar 11, 2024

    @mountiny
    ContributorAuthor

    Summary posted, closing

  17. parasharrajat commented on Jun 14, 2024

    @parasharrajat
    Member

    Payment requested as per #36796 (comment)

  18. JmillsExpensify commented on Jun 17, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorTask

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions