Skip to content

[$500] Hold request - App crashes when saving a reason during hold request flow #36831

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.43-0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applasue internal team
Slack conversation:

Action Performed:

  1. Launch New Expensify app.
  2. Create a manual request from any user.
  3. Go to request details page.
  4. Click 3-dot menu > Hold request.
  5. Add a reason and save it.

Expected Result:

App does not crash.

Actual Result:

App crashes.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385223_1708394496532.Screen_Recording_20240220_081809_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0126f2cd8c5ade674d
  • Upwork Job ID: 1759794310203371520
  • Last Price Increase: 2024-02-20
  • Automatic offers:
    • shubham1206agra | Reviewer | 0
    • mkhutornyi | Contributor | 0

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 20, 2024
  2. changed the title [-]Hold request - App crashes when saving a reason during hold request flow[/-] [+][$500] Hold request - App crashes when saving a reason during hold request flow[/+] on Feb 20, 2024
  3. melvin-bot commented on Feb 20, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 20, 2024
  5. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  6. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

  7. github-actions commented on Feb 20, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. 24 remaining items

  9. joekaufmanexpensify commented on Mar 25, 2024

    @joekaufmanexpensify
    Contributor

    Discussing further here.

  10. shubham1206agra commented on Mar 27, 2024

    @shubham1206agra
    Contributor

    @joekaufmanexpensify I have discussed this internally. You may close this issue as I am keeping track of payment internally and will ask to pay once the issue is resolved. Just write in the payment summary that I have not been paid yet.

  11. joekaufmanexpensify commented on Apr 1, 2024

    @joekaufmanexpensify
    Contributor

    Sounds good. TY! LMK when your Upwork situation is all set, and I'll re-open this and pay you.

  12. shubham1206agra commented on Apr 17, 2024

    @shubham1206agra
    Contributor

    @joekaufmanexpensify You can process payment here now.

  13. shubham1206agra commented on Apr 23, 2024

    @shubham1206agra
    Contributor
  14. joekaufmanexpensify commented on Apr 23, 2024

    @joekaufmanexpensify
    Contributor

    Awesome. TY!

  15. joekaufmanexpensify commented on Apr 23, 2024

    @joekaufmanexpensify
    Contributor

    OG upwork job is closed, so opened new one: https://www.upwork.com/jobs/~01456ff2950adec042

  16. joekaufmanexpensify commented on Apr 23, 2024

    @joekaufmanexpensify
    Contributor

    @shubham1206agra offer sent for $500!

  17. shubham1206agra commented on Apr 23, 2024

    @shubham1206agra
    Contributor
  18. joekaufmanexpensify commented on Apr 23, 2024

    @joekaufmanexpensify
    Contributor

    @shubham1206agra $500 sent and contract ended!

  19. joekaufmanexpensify commented on Apr 23, 2024

    @joekaufmanexpensify
    Contributor

    Upwork job closed.

  20. joekaufmanexpensify commented on Apr 23, 2024

    @joekaufmanexpensify
    Contributor

    All set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions