You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Hold Request - "Hold/unhold request" text is not translated to Spanish #36836
Version Number: 1.4.43-0 Reproducible in staging?: y Reproducible in production?: new feature If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: applause internal team Slack conversation:
Action Performed:
Pre: Cond: Text is set to spanish
Access staging.new.expensify.com
Sign into a valid account
Create a money request with any user
Click on 3 dot menu in top right > "Hold/unhold request" > Complete the reason and tap on ENTER
Expected Result:
User expects this text to be translated to Spanish
Actual Result:
Text shows in english as "held this money request with the comment: ..." OR "unheld this money request"
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Hold Request - "Hold/unhold request" text is not translated to Spanish[/-][+][$500] Hold Request - "Hold/unhold request" text is not translated to Spanish[/+]on Feb 20, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
Text shows in english as "held this money request with the comment: ..." OR "unheld this money request"
What is the root cause of that problem?
When generating the optimistic messages for hold/unhold here and here we're not using localization
What changes do you think we should make in order to solve the problem?
Use localization in those places (using Localize.translateLocal or similar methods), we need to define the new translation keys for those messages since they don't seem to be defined yet.
We might have to fix similarly in the back-end too if we're not returning the proper translated message there.
What alternative solutions did you explore? (Optional)
We can custom-render the held/unheld report action, similar to here, and we'll render proper translation there based on the actionName.
It's out of scope but I noticed the held/unheld message is not being displayed properly in the LHN, due to we didn't add the custom handling logic here, if we want to fix it, we need to add handling logic for the HOLD/UNHOLD actionName, and return the translated message.
@MonilBhavsar hi, my proposal was used in the PR to fix the issue, I think I'm eligible for partial compensation here, some similar cases are here and here.
Activity
[-]Hold Request - "Hold/unhold request" text is not translated to Spanish[/-][+][$500] Hold Request - "Hold/unhold request" text is not translated to Spanish[/+]melvin-bot commentedon Feb 20, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0117d6adb152825044
melvin-bot commentedon Feb 20, 2024
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Feb 20, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (
External)github-actions commentedon Feb 20, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 20, 2024
Triggered auto assignment to @MonilBhavsar (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.dukenv0307 commentedon Feb 20, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Text shows in english as "held this money request with the comment: ..." OR "unheld this money request"
What is the root cause of that problem?
When generating the optimistic messages for hold/unhold here and here we're not using localization
What changes do you think we should make in order to solve the problem?
Use localization in those places (using
Localize.translateLocalor similar methods), we need to define the new translation keys for those messages since they don't seem to be defined yet.We might have to fix similarly in the back-end too if we're not returning the proper translated message there.
What alternative solutions did you explore? (Optional)
We can custom-render the held/unheld report action, similar to here, and we'll render proper translation there based on the
actionName.It's out of scope but I noticed the held/unheld message is not being displayed properly in the LHN, due to we didn't add the custom handling logic here, if we want to fix it, we need to add handling logic for the
HOLD/UNHOLDactionName, and return the translated message.melvin-bot commentedon Feb 20, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
BartoszGrajdek commentedon Feb 20, 2024
@MonilBhavsar already started working on a fix, so I'm not going to create a follow-up PR, let me know if I can help you with anything! 👀
c3024 commentedon Feb 27, 2024
This was fixed in the referred PRs. Can you please close this? @bfitzexpensify @MonilBhavsar
MonilBhavsar commentedon Feb 27, 2024
Yes, going to close this. No payment required here
dukenv0307 commentedon Feb 28, 2024
@MonilBhavsar hi, my proposal was used in the PR to fix the issue, I think I'm eligible for partial compensation here, some similar cases are here and here.