Closed
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorHourlyKSv2KSv2ReviewingHas a PR in reviewHas a PR in review
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Found when validating PR: #36147
Version Number: v1.4.43-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:
Action Performed:
- Navigate to staging.new.expensify.com
- Create a new workspace.
- Go to workspace chat.
- Click + > Request money > Distance.
- Enter addresses.
- Proceed to confirmation page.
(Step 2-6 must be done quickly.)
Expected Result:
App does not crash.
Actual Result:
App crashes.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6385297_1708401830321.bandicam_2024-02-20_09-31-11-883.mp4
Bug6385297_1708401830330!staging.new.expensify.com-1708401721990.txt
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01e5db64f304cac8ab
- Upwork Job ID: 1759883217035563008
- Last Price Increase: 2024-02-20
- Automatic offers:
- c3024 | Reviewer | 0
- situchan | Contributor | 0
Metadata
Metadata
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorHourlyKSv2KSv2ReviewingHas a PR in reviewHas a PR in review
Activity
[-]Distance - App crashes when creating a distance request after creating a new workspace[/-][+][$500] Distance - App crashes when creating a distance request after creating a new workspace[/+]melvin-bot commentedon Feb 20, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01e5db64f304cac8ab
melvin-bot commentedon Feb 20, 2024
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Feb 20, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (
External)github-actions commentedon Feb 20, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
13 remaining items
melvin-bot commentedon Feb 20, 2024
📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
melvin-bot commentedon Feb 20, 2024
📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
melvin-bot commentedon Feb 20, 2024
📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
melvin-bot commentedon Feb 20, 2024
📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
CortneyOfstad commentedon Feb 20, 2024
PR here and looks as though it was cherry-picked for Staging 5 hours ago 👍
cristipaval commentedon Feb 20, 2024
@CortneyOfstad, FYI: @situchan is the only contributor to pay here. The C+ is the one who reviewed the original PR that introduced the regression (Thanks, @c3024, for quickly jumping into this! 🙏 )
tienifr commentedon Feb 21, 2024
@CortneyOfstad @cristipaval Should we have a payment here since we used my proposal to fix this blocker?
Similar case: https://expensify.slack.com/archives/C01GTK53T8Q/p1707782382926619?thread_ts=1707781846.347169&cid=C01GTK53T8Q
situchan commentedon Feb 21, 2024
@tienifr #35540 (comment) was posted before this issue created and your proposal is posted. And simple enough so not worth considering efforts made to request compensation.
(Just my opinion)
CortneyOfstad commentedon Feb 21, 2024
I agree with @situchan. @cristipaval do you have any thoughts on whether payment is needed based on the comment here?
cristipaval commentedon Feb 21, 2024
I get what @tienifr is saying, and that there were similar cases when other proposals were compensated if they were guiding the developer in fixing it, but given that the discussion about the fix for this issue happened a few days before this issue was created, I think @situchan is the only eligible for the payment here.
CortneyOfstad commentedon Feb 21, 2024
Thanks @cristipaval!
Payment Summary
@situchan — paid $500 via Upwork