Skip to content

[$500] Distance - App crashes when creating a distance request after creating a new workspace #36854

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Found when validating PR: #36147

Version Number: v1.4.43-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Create a new workspace.
  3. Go to workspace chat.
  4. Click + > Request money > Distance.
  5. Enter addresses.
  6. Proceed to confirmation page.
    (Step 2-6 must be done quickly.)

Expected Result:

App does not crash.

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6385297_1708401830321.bandicam_2024-02-20_09-31-11-883.mp4

Bug6385297_1708401830330!staging.new.expensify.com-1708401721990.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e5db64f304cac8ab
  • Upwork Job ID: 1759883217035563008
  • Last Price Increase: 2024-02-20
  • Automatic offers:
    • c3024 | Reviewer | 0
    • situchan | Contributor | 0

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 20, 2024
  2. changed the title [-]Distance - App crashes when creating a distance request after creating a new workspace[/-] [+][$500] Distance - App crashes when creating a distance request after creating a new workspace[/+] on Feb 20, 2024
  3. melvin-bot commented on Feb 20, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 20, 2024
  5. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  6. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

  7. github-actions commented on Feb 20, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. 13 remaining items

  9. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job

  10. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job

  11. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  12. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  13. CortneyOfstad commented on Feb 20, 2024

    @CortneyOfstad
    Contributor

    PR here and looks as though it was cherry-picked for Staging 5 hours ago 👍

  14. cristipaval commented on Feb 20, 2024

    @cristipaval
    Contributor

    @CortneyOfstad, FYI: @situchan is the only contributor to pay here. The C+ is the one who reviewed the original PR that introduced the regression (Thanks, @c3024, for quickly jumping into this! 🙏 )

  15. tienifr commented on Feb 21, 2024

    @tienifr
    Contributor
  16. situchan commented on Feb 21, 2024

    @situchan
    Contributor

    @tienifr #35540 (comment) was posted before this issue created and your proposal is posted. And simple enough so not worth considering efforts made to request compensation.
    (Just my opinion)

  17. CortneyOfstad commented on Feb 21, 2024

    @CortneyOfstad
    Contributor

    I agree with @situchan. @cristipaval do you have any thoughts on whether payment is needed based on the comment here?

  18. cristipaval commented on Feb 21, 2024

    @cristipaval
    Contributor

    I get what @tienifr is saying, and that there were similar cases when other proposals were compensated if they were guiding the developer in fixing it, but given that the discussion about the fix for this issue happened a few days before this issue was created, I think @situchan is the only eligible for the payment here.

  19. CortneyOfstad commented on Feb 21, 2024

    @CortneyOfstad
    Contributor

    Thanks @cristipaval!

    Payment Summary

    @situchan — paid $500 via Upwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions