Skip to content

[HOLD for payment 2024-03-04] [$500] Video - On full screen mode, when the video ends, the play button does nothing #36865

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.43-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): vdargentotest+ios021924@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

Pre-requisite: the user should be logged in.

  1. Go to any chat.
  2. Send a video.
  3. Tap on the video.
  4. Tap on the full screen icon.
  5. Wait for the video to end.
  6. Tap on the play button.

Expected Result:

The video should be restarted.

Actual Result:

The play button does nothing.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6385355_1708408537798.Hhvs7775_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012225fc83456fd541
  • Upwork Job ID: 1759896721297903616
  • Last Price Increase: 2024-02-20
  • Automatic offers:
    • jjcoffee | Reviewer | 0
    • tienifr | Contributor | 0

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 20, 2024
  2. melvin-bot commented on Feb 20, 2024

    @melvin-bot
  3. changed the title [-]Video - On full screen mode, when the video ends, the play button does nothing[/-] [+][$500] Video - On full screen mode, when the video ends, the play button does nothing[/+] on Feb 20, 2024
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 20, 2024
  5. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

  6. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. github-actions commented on Feb 20, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. 17 remaining items

  9. rlinoz commented on Feb 22, 2024

    @rlinoz
    Contributor

    This is CP'd so removing the blocker.

  10. removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Feb 22, 2024
  11. tienifr commented on Mar 1, 2024

    @tienifr
    Contributor

    @greg-schroeder PR hit production. Melvin is malfunctioning. Please add HOLD for payment label.

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Mar 1, 2024
  13. rlinoz commented on Mar 1, 2024

    @rlinoz
    Contributor

    Ok I am removing the label because I am not sure what date to put in the title

  14. greg-schroeder commented on Mar 1, 2024

    @greg-schroeder
    Contributor

    Deployed 2/26, payment date will be 3/4

  15. changed the title [-][$500] Video - On full screen mode, when the video ends, the play button does nothing[/-] [+][HOLD for payment 2024-03-04] [$500] Video - On full screen mode, when the video ends, the play button does nothing[/+] on Mar 1, 2024
  16. jjcoffee commented on Mar 5, 2024

    @jjcoffee
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: Video player #30829
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Video player #30829 (comment)
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug. Yes
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. Go to any chat.
    2. Send a video.
    3. Tap on the video.
    4. Tap on the full screen icon.
    5. Wait for the video to end.
    6. Tap on the play button.
    7. Verify that the video is restarted.

    Do we agree 👍 or 👎

  17. jjcoffee commented on Mar 5, 2024

    @jjcoffee
    Contributor

    @greg-schroeder Checklist complete!

  18. greg-schroeder commented on Mar 5, 2024

    @greg-schroeder
    Contributor

    Thanks! Sorry I was out yesterday, will take care of this today

  19. greg-schroeder commented on Mar 7, 2024

    @greg-schroeder
    Contributor

    Paid, regression test filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions