You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-03-04] [$500] Video - On full screen mode, when the video ends, the play button does nothing #36865
changed the title [-]Video - On full screen mode, when the video ends, the play button does nothing[/-][+][$500] Video - On full screen mode, when the video ends, the play button does nothing[/+]on Feb 20, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$500] Video - On full screen mode, when the video ends, the play button does nothing[/-][+][HOLD for payment 2024-03-04] [$500] Video - On full screen mode, when the video ends, the play button does nothing[/+]on Mar 1, 2024
The PR that introduced the bug has been identified. Link to the PR: Video player #30829
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Video player #30829 (comment)
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Feb 20, 2024
Job added to Upwork: https://www.upwork.com/jobs/~012225fc83456fd541
[-]Video - On full screen mode, when the video ends, the play button does nothing[/-][+][$500] Video - On full screen mode, when the video ends, the play button does nothing[/+]melvin-bot commentedon Feb 20, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (
External)melvin-bot commentedon Feb 20, 2024
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Feb 20, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
17 remaining items
rlinoz commentedon Feb 22, 2024
This is CP'd so removing the blocker.
tienifr commentedon Mar 1, 2024
@greg-schroeder PR hit production. Melvin is malfunctioning. Please add HOLD for payment label.
rlinoz commentedon Mar 1, 2024
Ok I am removing the label because I am not sure what date to put in the title
greg-schroeder commentedon Mar 1, 2024
Deployed 2/26, payment date will be 3/4
[-][$500] Video - On full screen mode, when the video ends, the play button does nothing[/-][+][HOLD for payment 2024-03-04] [$500] Video - On full screen mode, when the video ends, the play button does nothing[/+]jjcoffee commentedon Mar 5, 2024
Regression Test Proposal
Do we agree 👍 or 👎
jjcoffee commentedon Mar 5, 2024
@greg-schroeder Checklist complete!
greg-schroeder commentedon Mar 5, 2024
Thanks! Sorry I was out yesterday, will take care of this today
greg-schroeder commentedon Mar 7, 2024
Paid, regression test filed