Skip to content

[$500] Tag - No violation message for missing tag when tag is not selected #36889

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.43-2
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Precondition::

  • User is an employee of Collect workspace.
  • The Collect workspace has tags and Tag is set to "Required".
  1. Navigate to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create a manual request without tag.
  4. Navigate to request details page.

Expected Result:

There will be a violation message for missing tag.

Actual Result:

There is no violation message for missing tag.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385600_1708428087038.bandicam_2024-02-20_14-55-24-904.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01651062d96a32e6ea
  • Upwork Job ID: 1759949751406247936
  • Last Price Increase: 2024-02-20

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 20, 2024
  2. melvin-bot commented on Feb 20, 2024

    @melvin-bot
  3. changed the title [-]Tag - No violation message for missing tag when tag is not selected[/-] [+][$500] Tag - No violation message for missing tag when tag is not selected[/+] on Feb 20, 2024
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 20, 2024
  5. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

  6. github-actions commented on Feb 20, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. melvin-bot commented on Feb 20, 2024

    @melvin-bot

    Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  8. kbecciv commented on Feb 20, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave6-collect-submitters
    CC @greg-schroeder

  9. 6 remaining items

  10. added
    InternalRequires API changes or must be handled by Expensify staff
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    InternalRequires API changes or must be handled by Expensify staff
    on Feb 21, 2024
  11. melvin-bot commented on Feb 21, 2024

    @melvin-bot

    Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new.

  12. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 21, 2024
  13. self-assigned this
    on Feb 21, 2024
  14. cead22 commented on Feb 21, 2024

    @cead22
    Contributor

    Violations are in beta so this shouldn't be a blocker, and I'm working on the fix

  15. melvin-bot commented on Mar 5, 2024

    @melvin-bot

    @cead22, @pecanoro Whoops! This issue is 2 days overdue. Let's get this updated quick!

  16. pecanoro commented on Mar 5, 2024

    @pecanoro
    Contributor

    This is on prod already, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions