Skip to content

[Held requests] break held message into separate system message + comment #36979

Closed

Description

@robertjchen

Action Performed:

break held message into separate system message + comment

Expected Result:

image

Actual Result:

Screenshot 2024-02-20 at 5 34 03 PM

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 21, 2024
  2. self-assigned this
    on Feb 21, 2024
  3. melvin-bot commented on Feb 21, 2024

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. robertjchen commented on Feb 21, 2024

    @robertjchen
    ContributorAuthor

    @BartoszGrajdek when making the system message, it looks like we can simplify that further since we're breaking things up. I'll update the backend to split these into two different report actions, but the FE may need to generate the separate optimistic messages 👍

  5. melvin-bot commented on Feb 26, 2024

    @melvin-bot

    @robertjchen Eep! 4 days overdue now. Issues have feelings too...

  6. robertjchen commented on Feb 27, 2024

    @robertjchen
    ContributorAuthor

    working on updating the backend!

  7. changed the title [-]Hold Request: break held message into separate system message + comment[/-] [+][Held requests] break held message into separate system message + comment[/+] on Mar 8, 2024
  8. 6 remaining items

  9. melvin-bot commented on Mar 13, 2024

    @melvin-bot

    @robertjchen this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

  10. robertjchen commented on Mar 15, 2024

    @robertjchen
    ContributorAuthor

    was blocked by #36830, now resuming progress in Draft PR https://github.com/Expensify/Auth/pull/10032

  11. robertjchen commented on Mar 18, 2024

    @robertjchen
    ContributorAuthor

    @BartoszGrajdek Could you please help me update the FE to do the following? Thanks!! 🙏

    • break the hold action into the hold action (without the comment) and a new optimistic comment.
    • the HoldRequest API command will take a new commentReportActionID parameter for the optimistic comment report action.
    • we'll also need to remove the comment logic from wherever we call Localize.translateLocal('iou.heldRequest', e.g. pages/home/report/ReportActionItem.tsx
  12. BartoszGrajdek commented on Mar 21, 2024

    @BartoszGrajdek
    Contributor

    Hi! Of course - I've created a draft PR with the changes mentioned above, not sure if the backend is fully working yet, so please let me know what's the status there 🙏🏻

  13. robertjchen commented on Mar 21, 2024

    @robertjchen
    ContributorAuthor

    Thanks! The backend changes are live, let me test with your branch 👍

  14. robertjchen commented on Mar 21, 2024

    @robertjchen
    ContributorAuthor

    Worked great! Some final backend tweaks were required to make things tick- the changes are now under review and will hopefully be merged and deployed to staging later today (PR). Assuming the backend Web change goes out to staging today I'll go ahead and merge your branch first thing tomorrow 🙏

  15. robertjchen commented on Mar 22, 2024

    @robertjchen
    ContributorAuthor

    All PRs merged!! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions