You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Held requests] break held message into separate system message + comment #36979
@BartoszGrajdek when making the system message, it looks like we can simplify that further since we're breaking things up. I'll update the backend to split these into two different report actions, but the FE may need to generate the separate optimistic messages 👍
changed the title [-]Hold Request: break held message into separate system message + comment[/-][+][Held requests] break held message into separate system message + comment[/+]on Mar 8, 2024
@robertjchen this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
@BartoszGrajdek Could you please help me update the FE to do the following? Thanks!! 🙏
break the hold action into the hold action (without the comment) and a new optimistic comment.
the HoldRequest API command will take a new commentReportActionID parameter for the optimistic comment report action.
we'll also need to remove the comment logic from wherever we call Localize.translateLocal('iou.heldRequest', e.g. pages/home/report/ReportActionItem.tsx
Hi! Of course - I've created a draft PR with the changes mentioned above, not sure if the backend is fully working yet, so please let me know what's the status there 🙏🏻
Worked great! Some final backend tweaks were required to make things tick- the changes are now under review and will hopefully be merged and deployed to staging later today (PR). Assuming the backend Web change goes out to staging today I'll go ahead and merge your branch first thing tomorrow 🙏
Activity
melvin-bot commentedon Feb 21, 2024
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.robertjchen commentedon Feb 21, 2024
@BartoszGrajdek when making the system message, it looks like we can simplify that further since we're breaking things up. I'll update the backend to split these into two different report actions, but the FE may need to generate the separate optimistic messages 👍
melvin-bot commentedon Feb 26, 2024
@robertjchen Eep! 4 days overdue now. Issues have feelings too...
robertjchen commentedon Feb 27, 2024
working on updating the backend!
[-]Hold Request: break held message into separate system message + comment[/-][+][Held requests] break held message into separate system message + comment[/+]6 remaining items
melvin-bot commentedon Mar 13, 2024
@robertjchen this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
robertjchen commentedon Mar 15, 2024
was blocked by #36830, now resuming progress in Draft PR https://github.com/Expensify/Auth/pull/10032
robertjchen commentedon Mar 18, 2024
@BartoszGrajdek Could you please help me update the FE to do the following? Thanks!! 🙏
HoldRequestAPI command will take a newcommentReportActionIDparameter for the optimistic comment report action.Localize.translateLocal('iou.heldRequest',e.g. pages/home/report/ReportActionItem.tsxBartoszGrajdek commentedon Mar 21, 2024
Hi! Of course - I've created a draft PR with the changes mentioned above, not sure if the backend is fully working yet, so please let me know what's the status there 🙏🏻
robertjchen commentedon Mar 21, 2024
Thanks! The backend changes are live, let me test with your branch 👍
robertjchen commentedon Mar 21, 2024
Worked great! Some final backend tweaks were required to make things tick- the changes are now under review and will hopefully be merged and deployed to staging later today (PR). Assuming the backend Web change goes out to staging today I'll go ahead and merge your branch first thing tomorrow 🙏
robertjchen commentedon Mar 22, 2024
All PRs merged!! 🎉