You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-28] [Held requests] Hold Request education modal reappears after relogin #37012
Version Number: v1.4.43-6 Reproducible in staging?: y Reproducible in production?: n Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: applause-Internal Team Slack conversation:
Action Performed:
Go to staging.new.expensify.com.
Go to workspace chat.
Create a manual request.
Go to request details page.
Click 3-dot menu > Hold request.
Add a reason and submit it.
Log out.
Log in.
Go to request details page.
Click Got it on the Hold request education modal.
Repeat Step 6-8.
Expected Result:
Hold Request education modal will not appear again after relogin.
Actual Result:
Hold Request education modal reappears after relogin.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Hold Request - Hold Request education modal reappears after relogin[/-][+][$500] Hold Request - Hold Request education modal reappears after relogin[/+]on Feb 21, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][Held requests] Hold Request education modal reappears after relogin[/-][+][HOLD for payment 2024-06-28] [Held requests] Hold Request education modal reappears after relogin[/+]on Jun 21, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@robertjchen] The PR that introduced the bug has been identified. Link to the PR:
[@robertjchen] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@robertjchen] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@cdOut] Determine if we should create a regression test for this bug.
[@cdOut] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Feb 21, 2024
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.[-]Hold Request - Hold Request education modal reappears after relogin[/-][+][$500] Hold Request - Hold Request education modal reappears after relogin[/+]melvin-bot commentedon Feb 21, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0135c085e6de6bb2c1
github-actions commentedon Feb 21, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 21, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)70 remaining items
robertjchen commentedon Jun 11, 2024
Final discussion/tests 🙏
robertjchen commentedon Jun 17, 2024
Hoping to get this wrapped up this week, we're close!
robertjchen commentedon Jun 18, 2024
Backend fix under review and to be deployed!
robertjchen commentedon Jun 21, 2024
The fix is now fully out and confirmed fixed on production, so closing this for now. Please comment if there are any remaining items.
[-][Held requests] Hold Request education modal reappears after relogin[/-][+][HOLD for payment 2024-06-28] [Held requests] Hold Request education modal reappears after relogin[/+]melvin-bot commentedon Jun 21, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 21, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 21, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: