Skip to content

[HOLD for payment 2024-06-28] [Held requests] Hold Request education modal reappears after relogin #37012

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Found when validating PR : #33897

Version Number: v1.4.43-6
Reproducible in staging?: y
Reproducible in production?: n
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause-Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com.
  2. Go to workspace chat.
  3. Create a manual request.
  4. Go to request details page.
  5. Click 3-dot menu > Hold request.
  6. Add a reason and submit it.
  7. Log out.
  8. Log in.
  9. Go to request details page.
  10. Click Got it on the Hold request education modal.
  11. Repeat Step 6-8.

Expected Result:

Hold Request education modal will not appear again after relogin.

Actual Result:

Hold Request education modal reappears after relogin.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6386748_1708514823925.bandicam_2024-02-21_04-07-12-584.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0135c085e6de6bb2c1
  • Upwork Job ID: 1760290228470611968
  • Last Price Increase: 2024-02-21

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 21, 2024
  2. melvin-bot commented on Feb 21, 2024

    @melvin-bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. changed the title [-]Hold Request - Hold Request education modal reappears after relogin[/-] [+][$500] Hold Request - Hold Request education modal reappears after relogin[/+] on Feb 21, 2024
  4. melvin-bot commented on Feb 21, 2024

    @melvin-bot
  5. github-actions commented on Feb 21, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 21, 2024
  7. melvin-bot commented on Feb 21, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  8. 70 remaining items

  9. robertjchen commented on Jun 11, 2024

    @robertjchen
    Contributor

    Final discussion/tests 🙏

  10. robertjchen commented on Jun 17, 2024

    @robertjchen
    Contributor

    Hoping to get this wrapped up this week, we're close!

  11. robertjchen commented on Jun 18, 2024

    @robertjchen
    Contributor

    Backend fix under review and to be deployed!

  12. self-assigned this
    on Jun 18, 2024
  13. robertjchen commented on Jun 21, 2024

    @robertjchen
    Contributor

    The fix is now fully out and confirmed fixed on production, so closing this for now. Please comment if there are any remaining items.

  14. moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collecton Jun 21, 2024
  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 21, 2024
  16. changed the title [-][Held requests] Hold Request education modal reappears after relogin[/-] [+][HOLD for payment 2024-06-28] [Held requests] Hold Request education modal reappears after relogin[/+] on Jun 21, 2024
  17. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  18. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-28. 🎊

    For reference, here are some details about the assignees on this issue:

    • @cdOut does not require payment (Contractor)
  19. melvin-bot commented on Jun 21, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@robertjchen] The PR that introduced the bug has been identified. Link to the PR:
    • [@robertjchen] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@robertjchen] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@cdOut] Determine if we should create a regression test for this bug.
    • [@cdOut] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions