Skip to content

[Violations] -"Review required" and RBR does not appear immediately for "Over limit" error #37013

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


issue found when executing #33969
Version Number: 1.4.43-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Turn on the Violations beta (or use an expensifail account)
  2. Go to OldDot and open or create a Control policy
  3. Enable violations for the workspace in Settings > [Workspace] > Expenses
  4. Make Expense Violations: true
  5. Make Max Expense Amount: $10
  6. Make tags required for the policy
  7. Go to Settings > [Workspace] > Tags
  8. Enable "People must tag expenses"
  9. Add a tag
  10. Go to the policy page
  11. In the JS console with the policy open do:
    p = Policy.getCurrent();
    p.policy.isPolicyExpenseChatEnabled = "true";
    p.save();
  12. Invite a new user to the policy
  13. Sign into that new user account in New Dot
  14. Go through the money request flow, choosing the policy you just created and create an Over the Limit IOU with $20 and tag included.
  15. After the IOU has been created click on the IOU preview to go to the report page
  16. Observe the IOU preview component
  17. Click on the Preview component to open the details thread and go back to the report page

Expected Result:

RBR should be present on the IOU preview with a "Review required" violation the first time user navigates to the report page

Actual Result:

RBR and "Review required" violation show up the second time user navigates to the report page after going back from the transaction detail thread. (i.e it doesn't show up the first time.)

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6386810_1708518542760.over_limit_bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d5c874f3a22433b7
  • Upwork Job ID: 1762193509418659840
  • Last Price Increase: 2024-02-26
Issue OwnerCurrent Issue Owner: @cead22

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 21, 2024
  2. melvin-bot commented on Feb 21, 2024

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. kavimuru commented on Feb 21, 2024

    @kavimuru
    Author

    @zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  4. Tony-MK commented on Feb 24, 2024

    @Tony-MK
    Contributor

    Notes

    This should be an internal issue because while testing on the main, I noticed the policy expense limit is not saved in the onyx.

    Furthermore, the response from the requestMoney endpoint does not contain overLimit as part of the transactionViolations.

    Hence, once the openReport endpoint is called, it responds with overLimit as part of the transactionViolations.

    Therefore, this bug needs to be considered an offline case as well.

    Below is a screenshot of a similar issue of the receipt amount limit violation displaying undefined, which may be solved in the PR.

    Screenshot

  5. melvin-bot commented on Feb 26, 2024

    @melvin-bot

    @zanyrenney Eep! 4 days overdue now. Issues have feelings too...

  6. zanyrenney commented on Feb 26, 2024

    @zanyrenney
    Contributor

    seems like this is related to:
    #32571
    #33969

    these are both part of wave 9.

  7. zanyrenney commented on Feb 26, 2024

    @zanyrenney
    Contributor

    hey @cead22 i think this is related to your issue linked above - can you let me know please?

  8. cead22 commented on Feb 26, 2024

    @cead22
    Contributor

    Furthermore, the response from the requestMoney endpoint does not contain overLimit as part of the transactionViolations.

    Yes, I think the fix will be in the back end to make RequestMoney push violations to clients. This something @luacmartins noticed recently, and I thought the flows would always go through OpenReport so I hadn't created an issue.

    Let's use this one for that and make it internal

  9. added
    InternalRequires API changes or must be handled by Expensify staff
    on Feb 26, 2024
  10. melvin-bot commented on Feb 26, 2024

    @melvin-bot
  11. 36 remaining items

  12. zanyrenney commented on Mar 21, 2024

    @zanyrenney
    Contributor

    Just a note to say, I am OOO now until April 2nd, reassigning BZ team member to help while I am OOO in case we need payments in that time. (as you see from the comment above, PR is on staging) Thanks!

  13. removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 21, 2024
  14. removed their assignment
    on Mar 21, 2024
  15. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 21, 2024
  16. melvin-bot commented on Mar 21, 2024

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  17. laurenreidexpensify commented on Mar 25, 2024

    @laurenreidexpensify
    Contributor

    @cead22 just to follow here - is https://github.com/Expensify/Web-Expensify/pull/41248 the PR for this? Looks like that is on prod now, but was internal review cos it's on Expensify/Web so we can remove @akinwale here, as no payment due for C+ review?

  18. cead22 commented on Mar 25, 2024

    @cead22
    Contributor

    Correct 👍

  19. JmillsExpensify commented on Mar 26, 2024

    @JmillsExpensify
    Contributor

    If this is on production, can't we also close this issue?

  20. cead22 commented on Mar 26, 2024

    @cead22
    Contributor

    Yup!

  21. moved this from Release 1: Spring 2024 (May) to Done in #expensify-bugson Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions