Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
issue found when executing #33969
Version Number: 1.4.43-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
- Turn on the Violations beta (or use an expensifail account)
- Go to OldDot and open or create a Control policy
- Enable violations for the workspace in Settings > [Workspace] > Expenses
- Make Expense Violations: true
- Make Max Expense Amount: $10
- Make tags required for the policy
- Go to Settings > [Workspace] > Tags
- Enable "People must tag expenses"
- Add a tag
- Go to the policy page
- In the JS console with the policy open do:
p = Policy.getCurrent();
p.policy.isPolicyExpenseChatEnabled = "true";
p.save(); - Invite a new user to the policy
- Sign into that new user account in New Dot
- Go through the money request flow, choosing the policy you just created and create an Over the Limit IOU with $20 and tag included.
- After the IOU has been created click on the IOU preview to go to the report page
- Observe the IOU preview component
- Click on the Preview component to open the details thread and go back to the report page
Expected Result:
RBR should be present on the IOU preview with a "Review required" violation the first time user navigates to the report page
Actual Result:
RBR and "Review required" violation show up the second time user navigates to the report page after going back from the transaction detail thread. (i.e it doesn't show up the first time.)
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6386810_1708518542760.over_limit_bug.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01d5c874f3a22433b7
- Upwork Job ID: 1762193509418659840
- Last Price Increase: 2024-02-26
Issue Owner
Current Issue Owner: @cead22Metadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Feb 21, 2024
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.kavimuru commentedon Feb 21, 2024
@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
Tony-MK commentedon Feb 24, 2024
Notes
This should be an internal issue because while testing on the main, I noticed the policy expense limit is not saved in the onyx.
Furthermore, the response from the
requestMoneyendpoint does not containoverLimitas part of thetransactionViolations.Hence, once the
openReportendpoint is called, it responds withoverLimitas part of thetransactionViolations.Therefore, this bug needs to be considered an offline case as well.
Below is a screenshot of a similar issue of the receipt amount limit violation displaying
undefined, which may be solved in the PR.melvin-bot commentedon Feb 26, 2024
@zanyrenney Eep! 4 days overdue now. Issues have feelings too...
zanyrenney commentedon Feb 26, 2024
seems like this is related to:
#32571
#33969
these are both part of wave 9.
zanyrenney commentedon Feb 26, 2024
hey @cead22 i think this is related to your issue linked above - can you let me know please?
cead22 commentedon Feb 26, 2024
Yes, I think the fix will be in the back end to make RequestMoney push violations to clients. This something @luacmartins noticed recently, and I thought the flows would always go through OpenReport so I hadn't created an issue.
Let's use this one for that and make it internal
melvin-bot commentedon Feb 26, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01d5c874f3a22433b7
36 remaining items
zanyrenney commentedon Mar 21, 2024
Just a note to say, I am OOO now until April 2nd, reassigning BZ team member to help while I am OOO in case we need payments in that time. (as you see from the comment above, PR is on staging) Thanks!
melvin-bot commentedon Mar 21, 2024
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.laurenreidexpensify commentedon Mar 25, 2024
@cead22 just to follow here - is https://github.com/Expensify/Web-Expensify/pull/41248 the PR for this? Looks like that is on prod now, but was internal review cos it's on Expensify/Web so we can remove @akinwale here, as no payment due for C+ review?
cead22 commentedon Mar 25, 2024
Correct 👍
JmillsExpensify commentedon Mar 26, 2024
If this is on production, can't we also close this issue?
cead22 commentedon Mar 26, 2024
Yup!