Skip to content

[$250] [Held requests] Markdown isn't applied to the "Hold" message #37015

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.43.0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

  1. Create an IOU in a chat
  2. Put it on hold
  3. Format the reason with markdowns

Expected Result:

Markdown should be applied.

Actual Result:

Markdown isn't applied to the "Hold" message.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6386836_1708519840035!img_1393

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011f83ef4d2ad62f49
  • Upwork Job ID: 1760293330198360064
  • Last Price Increase: 2024-03-25
  • Automatic offers:
    • hoangzinh | Reviewer | 0

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 21, 2024
  2. changed the title [-]IOU - Markdown isn't applied to the "Hold" message[/-] [+][$500] IOU - Markdown isn't applied to the "Hold" message[/+] on Feb 21, 2024
  3. melvin-bot commented on Feb 21, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 21, 2024
  5. melvin-bot commented on Feb 21, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

  6. melvin-bot commented on Feb 21, 2024

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. github-actions commented on Feb 21, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. 64 remaining items

  9. changed the title [-][$250] IOU - Markdown isn't applied to the "Hold" message[/-] [+][$250] [Held requests] Markdown isn't applied to the "Hold" message[/+] on Apr 4, 2024
  10. abekkala commented on Apr 8, 2024

    @abekkala
    Contributor

    Fix: @dragnoir
    PR Review: @hoangzinh

    PR not merged yet

  11. melvin-bot commented on May 1, 2024

    @melvin-bot

    This issue has not been updated in over 15 days. @robertjchen, @hoangzinh, @abekkala, @dragnoir eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  12. hoangzinh commented on May 1, 2024

    @hoangzinh
    Contributor

    We're still working on the PR #39452

  13. moved this from Polish to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collecton May 20, 2024
  14. moved this from Release 2: Summer 2024 (Aug) to Polish in [#whatsnext] #wave-collecton May 20, 2024
  15. trjExpensify commented on May 21, 2024

    @trjExpensify
    Contributor

    I'm suggesting we close this issue, to reflect where we've landed in the PR. #40408 (comment) - any thoughts, comment there. CC: @JmillsExpensify

  16. JmillsExpensify commented on May 21, 2024

    @JmillsExpensify
    Contributor

    Yes, agreed. Let's close.

  17. trjExpensify commented on May 21, 2024

    @trjExpensify
    Contributor

    Cool, thanks ya'll!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2ReviewingHas a PR in review

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions