Skip to content

[$500] Hold Request - Approving report that has expenses on hold removes "hold" status #37020

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Found when validating PR : #33897

Version Number: 1.4.43-6
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal team
Slack conversation:

Action Performed:

precondition: create a workspace, and invite an employee and approver

  1. Go to https://staging.new.expensify.com/

  2. Log in as an employee

  3. Navigate to a workspace chat

  4. Create a manual request

  5. Submit the report to the approver

  6. Navigate to the expense detail page in the submitted report

  7. Click on 3 dots > Hold request

  8. Enter a reason and hold request

  9. In incognito, login in ND as the approver

  10. Approve the submitted report

Expected Result:

The report is approved and the system message is added, the expense is still on hold

Actual Result:

The expense status "Hold" is removed, and the system message says that the " unheld this money request"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6386910_1708523131082.Recording__224.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e61187168c0a96ba
  • Upwork Job ID: 1760303385679118336
  • Last Price Increase: 2024-02-21

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 21, 2024
  2. changed the title [-]Hold Request - Approving report that has expenses on hold removes "hold" status[/-] [+][$500] Hold Request - Approving report that has expenses on hold removes "hold" status[/+] on Feb 21, 2024
  3. melvin-bot commented on Feb 21, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 21, 2024
  5. melvin-bot commented on Feb 21, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

  6. melvin-bot commented on Feb 21, 2024

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. github-actions commented on Feb 21, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. melvin-bot commented on Feb 21, 2024

    @melvin-bot

    Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  9. izarutskaya commented on Feb 21, 2024

    @izarutskaya
    Author

    We think that this bug might be related to #vip-bills
    CC @davidcardoza

  10. sakluger commented on Feb 21, 2024

    @sakluger
    Contributor

    This is related to our newly released Hold Requests feature (https://github.com/Expensify/Expensify/issues/274076) which is part of Wave 7.

  11. BartoszGrajdek commented on Feb 21, 2024

    @BartoszGrajdek
    Contributor

    This is the expected behavior right now - it will be handled better after we finish this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsHourlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions