Skip to content

[$250] Remove Add receipt from the three dot overflow menu #37060

Closed

Description

@JmillsExpensify

Problem

We've recently added a receipt empty state in conjunction with the on-going violations project, though we also have an existing Add receipt option in the three dot overflow menu. Example below.

Screenshot 2024-02-21 at 17 00 02

Accordingly, we effectively have two options to do the same thing, within the same screen. That's confusing and unnecessary.

Solution

Let's remove the Add receipt option in the three dot overflow menu, such that the receipt empty state is the only/main flow for adding receipts.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01462cd7dc3ef5fb51
  • Upwork Job ID: 1760460411785555968
  • Last Price Increase: 2024-02-22
  • Automatic offers:
    • s77rt | Reviewer | 0
    • Krishna2323 | Contributor | 0

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 22, 2024
  2. melvin-bot commented on Feb 22, 2024

    @melvin-bot

    Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 22, 2024
  4. changed the title [-]Remove `Add receipt` from the three dot overflow menu[/-] [+][$500] Remove `Add receipt` from the three dot overflow menu[/+] on Feb 22, 2024
  5. melvin-bot commented on Feb 22, 2024

    @melvin-bot
  6. melvin-bot commented on Feb 22, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

  7. changed the title [-][$500] Remove `Add receipt` from the three dot overflow menu[/-] [+][$250] Remove `Add receipt` from the three dot overflow menu[/+] on Feb 22, 2024
  8. melvin-bot commented on Feb 22, 2024

    @melvin-bot

    Upwork job price has been updated to $250

  9. JmillsExpensify commented on Feb 22, 2024

    @JmillsExpensify
    ContributorAuthor

    Super straightforward issue so updating the price accordingly.

  10. neonbhai commented on Feb 22, 2024

    @neonbhai
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Remove Add receipt from the three dot overflow menu

    What is the root cause of that problem?

    New Feature

    What changes do you think we should make in order to solve the problem?

    We will remove the option form MoneyRequestHeader here

    We will also remove the beta violation check for receipt empty state here:

    {!hasReceipt && canEditReceipt && canUseViolations && (
    <ReceiptEmptyState

  11. Krishna2323 commented on Feb 22, 2024

    @Krishna2323
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Remove Add receipt from the three dot overflow menu

    What is the root cause of that problem?

    new feature

    What changes do you think we should make in order to solve the problem?

    Need to remove the code below:

    if (canModifyRequest) {
    if (!TransactionUtils.hasReceipt(transaction)) {
    threeDotsMenuItems.push({
    icon: Expensicons.Receipt,
    text: translate('receipt.addReceipt'),
    onSelected: () =>
    Navigation.navigate(
    ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(
    CONST.IOU.ACTION.EDIT,
    CONST.IOU.TYPE.REQUEST,
    transaction?.transactionID ?? '',
    report.reportID,
    Navigation.getActiveRouteWithoutParams(),
    ),
    ),
    });
    }

    Result

  12. 27 remaining items

  13. Krishna2323 commented on Feb 25, 2024

    @Krishna2323
    Contributor

    @s77rt PR ready for review.

  14. Krishna2323 commented on Mar 8, 2024

    @Krishna2323
    Contributor

    @JmillsExpensify friendly bump for payments here :)

  15. Krishna2323 commented on Mar 13, 2024

    @Krishna2323
    Contributor

    @JmillsExpensify bump for payments process 🙇🏻

  16. melvin-bot commented on Mar 14, 2024

    @melvin-bot

    @JmillsExpensify @s77rt @Krishna2323 @hayata-suenaga this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

  17. hayata-suenaga commented on Mar 15, 2024

    @hayata-suenaga
    Contributor

    waiting for payment

  18. Krishna2323 commented on Mar 18, 2024

    @Krishna2323
    Contributor

    waiting for payment process by @JmillsExpensify

  19. JmillsExpensify commented on Mar 23, 2024

    @JmillsExpensify
    ContributorAuthor

    Not sure why the automation failed, though please reach out to me via DM for these cases. I'm on hundreds of issues so it's hard to keep track.

  20. JmillsExpensify commented on Mar 23, 2024

    @JmillsExpensify
    ContributorAuthor

    Payment summary:

    All contracts paid. Given that we are removing functionality, I don't think we need to create a regression test for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions