You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Remove Add receipt from the three dot overflow menu #37060
We've recently added a receipt empty state in conjunction with the on-going violations project, though we also have an existing Add receipt option in the three dot overflow menu. Example below.
Accordingly, we effectively have two options to do the same thing, within the same screen. That's confusing and unnecessary.
Solution
Let's remove the Add receipt option in the three dot overflow menu, such that the receipt empty state is the only/main flow for adding receipts.
changed the title [-]Remove `Add receipt` from the three dot overflow menu[/-][+][$500] Remove `Add receipt` from the three dot overflow menu[/+]on Feb 22, 2024
changed the title [-][$500] Remove `Add receipt` from the three dot overflow menu[/-][+][$250] Remove `Add receipt` from the three dot overflow menu[/+]on Feb 22, 2024
@JmillsExpensify@s77rt@Krishna2323@hayata-suenaga this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
Activity
melvin-bot commentedon Feb 22, 2024
Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.
[-]Remove `Add receipt` from the three dot overflow menu[/-][+][$500] Remove `Add receipt` from the three dot overflow menu[/+]melvin-bot commentedon Feb 22, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01462cd7dc3ef5fb51
melvin-bot commentedon Feb 22, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)[-][$500] Remove `Add receipt` from the three dot overflow menu[/-][+][$250] Remove `Add receipt` from the three dot overflow menu[/+]melvin-bot commentedon Feb 22, 2024
Upwork job price has been updated to $250
JmillsExpensify commentedon Feb 22, 2024
Super straightforward issue so updating the price accordingly.
neonbhai commentedon Feb 22, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Remove Add receipt from the three dot overflow menu
What is the root cause of that problem?
New Feature
What changes do you think we should make in order to solve the problem?
We will remove the option form
MoneyRequestHeaderhereWe will also remove the beta violation check for receipt empty state here:
App/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 275 to 276 in 8783eb4
Krishna2323 commentedon Feb 22, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Remove Add receipt from the three dot overflow menu
What is the root cause of that problem?
new feature
What changes do you think we should make in order to solve the problem?
Need to remove the code below:
App/src/components/MoneyRequestHeader.tsx
Lines 151 to 167 in 936ae8f
Result
27 remaining items
Krishna2323 commentedon Feb 25, 2024
@s77rt PR ready for review.
Krishna2323 commentedon Mar 8, 2024
@JmillsExpensify friendly bump for payments here :)
Krishna2323 commentedon Mar 13, 2024
@JmillsExpensify bump for payments process 🙇🏻
melvin-bot commentedon Mar 14, 2024
@JmillsExpensify @s77rt @Krishna2323 @hayata-suenaga this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
hayata-suenaga commentedon Mar 15, 2024
waiting for payment
Krishna2323 commentedon Mar 18, 2024
waiting for payment process by @JmillsExpensify
JmillsExpensify commentedon Mar 23, 2024
Not sure why the automation failed, though please reach out to me via DM for these cases. I'm on hundreds of issues so it's hard to keep track.
JmillsExpensify commentedon Mar 23, 2024
Payment summary:
All contracts paid. Given that we are removing functionality, I don't think we need to create a regression test for this case.