Skip to content

[HOLD component refactoring] [$500] [LOW] Green circular loading does not appear when searching for a contact in request money flow #37144

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.43-14
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @brunovjk
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1708081508978019

Action Performed:

  1. Click + and select Request money
  2. Enter amount and click next
  3. Search for any contact in the field

Expected Result:

Green circular loading ring is seen like when we search for a contact to chat

Actual Result:

Not appearing when searching in Request money flow

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.2773.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01788bcdaa345e5022
  • Upwork Job ID: 1761057209378701312
  • Last Price Increase: 2024-02-23

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 23, 2024
  2. melvin-bot commented on Feb 23, 2024

    @melvin-bot
  3. changed the title [-]Green circular loading does not appear when searching for a contact in request money flow[/-] [+][$500] Green circular loading does not appear when searching for a contact in request money flow[/+] on Feb 23, 2024
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 23, 2024
  5. melvin-bot commented on Feb 23, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

  6. melvin-bot commented on Feb 23, 2024

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. FitseTLT commented on Feb 23, 2024

    @FitseTLT
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Green circular loading does not appear when searching for a contact in request money flow

    What is the root cause of that problem?

    We are not passing isLoadingNewOptions prop to the selection list for participants here

    <SelectionList
    onConfirm={handleConfirmSelection}

    What changes do you think we should make in order to solve the problem?

    We should be passing isLoadingNewOptions prop to the selection list as for search page here

    isLoadingNewOptions={isSearchingForReports}
    />

    after subscribing to it as in here
    isSearchingForReports: {
    key: ONYXKEYS.IS_SEARCHING_FOR_REPORTS,
    initWithStoredValues: false,
    },
    })(SearchPage);

    What alternative solutions did you explore? (Optional)

  8. brunovjk commented on Feb 23, 2024

    @brunovjk
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When making a Request money, the circular loading does not appear when we search for contact

    What is the root cause of that problem?

    We are not setting isLoadingNewOptions correctly in MoneyTemporaryForRefactorRequestParticipantsSelector like we do in SearchPage.

    What changes do you think we should make in order to solve the problem?

    We need to get isSearchingForReports from onyx and use it in MoneyTemporaryForRefactorRequestParticipantsSelector SelectionList

    What alternative solutions did you explore? (Optional)

  9. brunovjk commented on Feb 23, 2024

    @brunovjk
  10. dukenv0307 commented on Feb 23, 2024

    @dukenv0307
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    1. Green circular loading not appearing when searching in Request money flow
    2. Skeleton loading appears when searching in the Send money flow but doesn't appear in the Request money flow

    What is the root cause of that problem?

    1. We don't have isLoadingNewOptions={isSearchingForReports} in here like the NewChatPage, so the loading indicator does not show.

    2. In the Send money flow here, we have the Skeleton loading whenever the user types something to search in the search input, this is inconsistent with the Request money flow where the Skeleton doesn't appear in this case (it only appears initially when first loading the list). This is because in Request money we have a different logic to show the skeleton placeholder based on the didScreenTransitionEnd and isOptionsDataReady here

    What changes do you think we should make in order to solve the problem?

    1. We need to connect to Onyx ONYXKEYS.IS_SEARCHING_FOR_REPORTS there and adds isLoadingNewOptions={isSearchingForReports} here

    We need to do the same thing in the MoneyRequestParticipantsSelector too (For the Send money flow)

    1. If we want the behavior in Request money page (not showing skeleton placeholder when searching), in Send money page we should update this to follow the same logic as in Request money page here. If instead we want to show skeleton placeholder when searching like Send money page, update request money page here to use isSearchingForReports similar to Send money page.

    What alternative solutions did you explore? (Optional)

    NA

  11. mollfpr commented on Feb 23, 2024

    @mollfpr
    Contributor

    Just a head-ups! I'll be reviewing the proposal from @brunovjk first since the posted the proposal along side with this bug report. Context: https://expensify.slack.com/archives/C01GTK53T8Q/p1708081508978019

  12. 54 remaining items

  13. brunovjk commented on May 7, 2024

    @brunovjk
    Contributor

    PR was merged, but not to staging yet

    Edit: PR on staging PR on production

  14. jliexpensify commented on May 16, 2024

    @jliexpensify
    Contributor

    Payment Summary

    NEW UPWORKS JOB

  15. lakchote commented on May 16, 2024

    @lakchote
    Contributor

    Payment Summary

    Is this correct? I'll need to create a new Upworks job.

    This is correct for @mollfpr and @brunovjk! However not for @dukenv0307 as his PR for handling skeleton cases isn't ready, so no payment is due yet.

  16. jliexpensify commented on May 16, 2024

    @jliexpensify
    Contributor

    @lakchote, thanks for checking! I assume I will be paying @dukenv0307 via this job, so we'll need to keep this open?

  17. jliexpensify commented on May 16, 2024

    @jliexpensify
    Contributor
  18. jliexpensify commented on May 17, 2024

    @jliexpensify
    Contributor
  19. JmillsExpensify commented on May 19, 2024

    @JmillsExpensify
    Contributor

    $500 approved for @mollfpr

  20. jliexpensify commented on May 20, 2024

    @jliexpensify
    Contributor

    Note for myself: waiting to pay @dukenv0307

  21. jliexpensify commented on Jun 14, 2024

    @jliexpensify
    Contributor

    @lakchote feel free to bump me when @dukenv0307 needs payment.

  22. brunovjk commented on Jun 14, 2024

    @brunovjk
    Contributor

    @lakchote What do you think about close this issue and open another suitable one to deal with skeleton loading in SelectionList?
    Keep things organized. Since they have different causes, solutions, assignee and payments. I can help with the issue report if needed.

  23. melvin-bot commented on Aug 12, 2024

    @melvin-bot

    @lakchote, @mollfpr, @jliexpensify, @brunovjk, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

ExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2NewFeatureSomething to build that is a new item.Not a priorityReviewingHas a PR in review

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions