You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD component refactoring] [$500] [LOW] Green circular loading does not appear when searching for a contact in request money flow #37144
changed the title [-]Green circular loading does not appear when searching for a contact in request money flow[/-][+][$500] Green circular loading does not appear when searching for a contact in request money flow[/+]on Feb 23, 2024
Please re-state the problem that we are trying to solve in this issue.
Green circular loading not appearing when searching in Request money flow
Skeleton loading appears when searching in the Send money flow but doesn't appear in the Request money flow
What is the root cause of that problem?
We don't have isLoadingNewOptions={isSearchingForReports} in here like the NewChatPage, so the loading indicator does not show.
In the Send money flow here, we have the Skeleton loading whenever the user types something to search in the search input, this is inconsistent with the Request money flow where the Skeleton doesn't appear in this case (it only appears initially when first loading the list). This is because in Request money we have a different logic to show the skeleton placeholder based on the didScreenTransitionEnd and isOptionsDataReadyhere
What changes do you think we should make in order to solve the problem?
We need to connect to Onyx ONYXKEYS.IS_SEARCHING_FOR_REPORTSthere and adds isLoadingNewOptions={isSearchingForReports}here
We need to do the same thing in the MoneyRequestParticipantsSelector too (For the Send money flow)
If we want the behavior in Request money page (not showing skeleton placeholder when searching), in Send money page we should update this to follow the same logic as in Request money page here. If instead we want to show skeleton placeholder when searching like Send money page, update request money page here to use isSearchingForReports similar to Send money page.
What alternative solutions did you explore? (Optional)
@lakchote What do you think about close this issue and open another suitable one to deal with skeleton loading in SelectionList?
Keep things organized. Since they have different causes, solutions, assignee and payments. I can help with the issue report if needed.
Activity
melvin-bot commentedon Feb 23, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01788bcdaa345e5022
[-]Green circular loading does not appear when searching for a contact in request money flow[/-][+][$500] Green circular loading does not appear when searching for a contact in request money flow[/+]melvin-bot commentedon Feb 23, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)melvin-bot commentedon Feb 23, 2024
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.FitseTLT commentedon Feb 23, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Green circular loading does not appear when searching for a contact in request money flow
What is the root cause of that problem?
We are not passing
isLoadingNewOptionsprop to the selection list for participants hereApp/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js
Lines 338 to 339 in 29ad878
What changes do you think we should make in order to solve the problem?
We should be passing
isLoadingNewOptionsprop to the selection list as for search page hereApp/src/pages/SearchPage/index.js
Lines 169 to 170 in 29ad878
after subscribing to it as in here
App/src/pages/SearchPage/index.js
Lines 189 to 193 in 29ad878
What alternative solutions did you explore? (Optional)
brunovjk commentedon Feb 23, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
When making a Request money, the circular loading does not appear when we search for contact
What is the root cause of that problem?
We are not setting
isLoadingNewOptionscorrectly inMoneyTemporaryForRefactorRequestParticipantsSelectorlike we do in SearchPage.What changes do you think we should make in order to solve the problem?
We need to get
isSearchingForReportsfromonyxand use it in MoneyTemporaryForRefactorRequestParticipantsSelector SelectionListWhat alternative solutions did you explore? (Optional)
brunovjk commentedon Feb 23, 2024
dukenv0307 commentedon Feb 23, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
We don't have
isLoadingNewOptions={isSearchingForReports}in here like theNewChatPage, so the loading indicator does not show.In the Send money flow here, we have the Skeleton loading whenever the user types something to search in the search input, this is inconsistent with the Request money flow where the Skeleton doesn't appear in this case (it only appears initially when first loading the list). This is because in Request money we have a different logic to show the skeleton placeholder based on the
didScreenTransitionEndandisOptionsDataReadyhereWhat changes do you think we should make in order to solve the problem?
ONYXKEYS.IS_SEARCHING_FOR_REPORTSthere and addsisLoadingNewOptions={isSearchingForReports}hereWe need to do the same thing in the
MoneyRequestParticipantsSelectortoo (For theSend moneyflow)isSearchingForReportssimilar to Send money page.What alternative solutions did you explore? (Optional)
NA
mollfpr commentedon Feb 23, 2024
Just a head-ups! I'll be reviewing the proposal from @brunovjk first since the posted the proposal along side with this bug report. Context: https://expensify.slack.com/archives/C01GTK53T8Q/p1708081508978019
54 remaining items
brunovjk commentedon May 7, 2024
PR was merged,
but not to staging yetEdit:
PR on stagingPR on productionjliexpensify commentedon May 16, 2024
Payment Summary
NEW UPWORKS JOB
lakchote commentedon May 16, 2024
This is correct for @mollfpr and @brunovjk! However not for @dukenv0307 as his PR for handling skeleton cases isn't ready, so no payment is due yet.
jliexpensify commentedon May 16, 2024
@lakchote, thanks for checking! I assume I will be paying @dukenv0307 via this job, so we'll need to keep this open?
jliexpensify commentedon May 16, 2024
NEW UPWORKS JOB
jliexpensify commentedon May 17, 2024
Paid @brunovjk
JmillsExpensify commentedon May 19, 2024
$500 approved for @mollfpr
jliexpensify commentedon May 20, 2024
Note for myself: waiting to pay @dukenv0307
jliexpensify commentedon Jun 14, 2024
@lakchote feel free to bump me when @dukenv0307 needs payment.
brunovjk commentedon Jun 14, 2024
@lakchote What do you think about close this issue and open another suitable one to deal with
skeleton loading in SelectionList?Keep things organized. Since they have different causes, solutions, assignee and payments. I can help with the issue report if needed.
melvin-bot commentedon Aug 12, 2024
@lakchote, @mollfpr, @jliexpensify, @brunovjk, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.