Skip to content

[HOLD for payment 2024-03-07] [$500] Room - User is navigated to Concierge report when creating room #37234

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.44-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

  1. Create a workspace if you don't have any
  2. Click on 'FAB' > Start chat > Room tab
  3. Enter room name and click on 'Create room' button

Expected Result:

User should be navigated to the newly created room

Actual Result:

User is navigated to Concierge report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393358_1708984329114.Screen_Recording_2024-02-27_at_12.26.11_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0146027f79fc978115
  • Upwork Job ID: 1762246166149222400
  • Last Price Increase: 2024-02-26

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 26, 2024
  2. changed the title [-]Room - User is navigated to Concierge report when creating room[/-] [+][$500] Room - User is navigated to Concierge report when creating room[/+] on Feb 26, 2024
  3. melvin-bot commented on Feb 26, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 26, 2024
  5. melvin-bot commented on Feb 26, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

  6. github-actions commented on Feb 26, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. kbecciv commented on Feb 26, 2024

    @kbecciv
    Author

    We think that this bug might be related to #vip-vsb
    |CC @quinthar

  8. melvin-bot commented on Feb 26, 2024

    @melvin-bot

    Triggered auto assignment to @blimpich (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  9. 14 remaining items

  10. blimpich commented on Feb 27, 2024

    @blimpich
    Contributor

    Reverted the react Onyx change by first reverting the react-onyx package and then upgrading the App's package to the latest version. Thank you @s77rt for the explanation!

    And I'm sorry @bernhardoj the timing didn't work out with your fix. Its morning over here and by the time I started work we really wanted to get the deploy out, so it makes sense to do this revert given the time / risk involved. It always sucks when making seemingly straightforward changes has these unforeseeable cascading effects.

    Closing as #37323 fixes this.

  11. luacmartins commented on Feb 27, 2024

    @luacmartins
    Contributor

    Seems like this was also the root cause for #37300

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Feb 29, 2024
  13. changed the title [-][$500] Room - User is navigated to Concierge report when creating room[/-] [+][HOLD for payment 2024-03-07] [$500] Room - User is navigated to Concierge report when creating room[/+] on Feb 29, 2024
  14. melvin-bot commented on Feb 29, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Feb 29, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-07. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Pujan92 requires payment (Needs manual offer from BZ)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions