You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Category - Narrow spacing between search field and "Recent" header #37328
Version Number: 1.4.44-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat
Open manual request page
Enter amount > Next
Click Show more > Category
Expected Result:
There will be adequate spacing between the search field and "Recent" header
Actual Result:
The spacing between search field and "Recent" is narrow
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Category - Narrow spacing between search field and "Recent" header[/-][+][$500] Category - Narrow spacing between search field and "Recent" header[/+]on Feb 27, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
I am pretty confused. What should I do? Should I raise a PR for review or not ? @abdulrahuman5196
@godofoutcasts94 PR shouldn't be raised until you have been assigned(If assigned after discussions)
I think the bug here is the space between the search input and the section header is less than before. In the past, we used OptionSelector, section header had margin-top 20px but now it's 8px when we use SelectionList.
I am not sure comparing it to previous view would be the right path. Anyways it would be design decision to maintain the current existing spacing or have more spacing. I was under the impression this was already design team reviewed since the bug as already a deployment blocker.
@dannymcclain@strepanier03@abdulrahuman5196@aldo-expensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Activity
[-]Category - Narrow spacing between search field and "Recent" header[/-][+][$500] Category - Narrow spacing between search field and "Recent" header[/+]melvin-bot commentedon Feb 27, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01698b7535b20746f7
melvin-bot commentedon Feb 27, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (
External)github-actions commentedon Feb 27, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 27, 2024
Triggered auto assignment to @aldo-expensify (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Feb 27, 2024
We think that this bug might be related to #wave5
CC @dylanexpensify
38 remaining items
abdulrahuman5196 commentedon Mar 5, 2024
@godofoutcasts94 PR shouldn't be raised until you have been assigned(If assigned after discussions)
I am not sure comparing it to previous view would be the right path. Anyways it would be design decision to maintain the current existing spacing or have more spacing. I was under the impression this was already design team reviewed since the bug as already a deployment blocker.
shawnborton commentedon Mar 7, 2024
I guess we could add extra space below the search input, or we just do nothing and close this out. Curious what everyone else thinks.
aldo-expensify commentedon Mar 7, 2024
No strong opinion, I'll go with what you think is best from a design point of view :P. if both options feel equivalent, I would close.
dannymcclain commentedon Mar 7, 2024
I think we should close.
strepanier03 commentedon Mar 12, 2024
I'm happy to close this and have everyone focus on higher value bugs. That's my vote.
melvin-bot commentedon Mar 12, 2024
@dannymcclain @strepanier03 @abdulrahuman5196 @aldo-expensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
strepanier03 commentedon Mar 12, 2024
Closing this out, we can always reopen in the future if we want but for now lets narrow our focus on higher value items.