Skip to content

[$500] Category - Narrow spacing between search field and "Recent" header #37328

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.44-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Open manual request page
  4. Enter amount > Next
  5. Click Show more > Category

Expected Result:

There will be adequate spacing between the search field and "Recent" header

Actual Result:

The spacing between search field and "Recent" is narrow

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6394362_1709055607590!Screenshot_2024-02-27_at_13 50 42

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01698b7535b20746f7
  • Upwork Job ID: 1762534844609216512
  • Last Price Increase: 2024-02-27

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 27, 2024
  2. changed the title [-]Category - Narrow spacing between search field and "Recent" header[/-] [+][$500] Category - Narrow spacing between search field and "Recent" header[/+] on Feb 27, 2024
  3. melvin-bot commented on Feb 27, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 27, 2024
  5. melvin-bot commented on Feb 27, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

  6. github-actions commented on Feb 27, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. melvin-bot commented on Feb 27, 2024

    @melvin-bot

    Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  8. lanitochka17 commented on Feb 27, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave5
    CC @dylanexpensify

  9. 38 remaining items

  10. abdulrahuman5196 commented on Mar 5, 2024

    @abdulrahuman5196
    Contributor

    I am pretty confused. What should I do? Should I raise a PR for review or not ? @abdulrahuman5196

    @godofoutcasts94 PR shouldn't be raised until you have been assigned(If assigned after discussions)

    I think the bug here is the space between the search input and the section header is less than before. In the past, we used OptionSelector, section header had margin-top 20px but now it's 8px when we use SelectionList.

    I am not sure comparing it to previous view would be the right path. Anyways it would be design decision to maintain the current existing spacing or have more spacing. I was under the impression this was already design team reviewed since the bug as already a deployment blocker.

  11. shawnborton commented on Mar 7, 2024

    @shawnborton
    Contributor

    I guess we could add extra space below the search input, or we just do nothing and close this out. Curious what everyone else thinks.

  12. aldo-expensify commented on Mar 7, 2024

    @aldo-expensify
    Contributor

    No strong opinion, I'll go with what you think is best from a design point of view :P. if both options feel equivalent, I would close.

  13. dannymcclain commented on Mar 7, 2024

    @dannymcclain
    Contributor

    I think we should close.

  14. strepanier03 commented on Mar 12, 2024

    @strepanier03
    Contributor

    I'm happy to close this and have everyone focus on higher value bugs. That's my vote.

  15. melvin-bot commented on Mar 12, 2024

    @melvin-bot

    @dannymcclain @strepanier03 @abdulrahuman5196 @aldo-expensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  16. strepanier03 commented on Mar 12, 2024

    @strepanier03
    Contributor

    Closing this out, we can always reopen in the future if we want but for now lets narrow our focus on higher value items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2DesignEngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions