You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500][MEDIUM] Categories: Search field is present in category list when there are fewer than 8 categories to choose from #37329
Version Number: 1.4.44-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Precondition:
User is an employee of Collect workspace
The Collect workspace has less than 8 categories
Go to staging.new.expensify.com
Go to workspace chat
Open request money page
Create manual request and proceed to confirmation page
Click Show more > Category
Expected Result:
There will be no search field because there are less than 8 categories
Actual Result:
Search field is present when there are less than 8 categories
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Category - Search field is present in Category list when there is less than 8 categories[/-][+][$500] Category - Search field is present in Category list when there is less than 8 categories[/+]on Feb 27, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$500] Category - Search field is present in Category list when there is less than 8 categories[/-][+][$500][MEDIUM] Categories: Search field is present in category list when there are fewer than 8 categories to choose from[/+]on Feb 27, 2024
Activity
[-]Category - Search field is present in Category list when there is less than 8 categories[/-][+][$500] Category - Search field is present in Category list when there is less than 8 categories[/+]melvin-bot commentedon Feb 27, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0110ba1eec3b905bcd
melvin-bot commentedon Feb 27, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (
External)melvin-bot commentedon Feb 27, 2024
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Feb 27, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
7 remaining items
eucool commentedon Feb 27, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Search field is present in Category list when there is less than 8 categories
What is the root cause of that problem?
The variable name policyCategoriesCount is wrong:
App/src/components/CategoryPicker/index.js
Line 52 in 7942cb8
What changes do you think we should make in order to solve the problem?
Replace the above with:
policiesCountApp/src/components/CategoryPicker/index.js
Line 51 in 7942cb8
What alternative solutions did you explore? (Optional)
N/A
puneetlath commentedon Feb 27, 2024
Definitely a bug, but doesn't need to block the deploy. Removing the label.
[-][$500] Category - Search field is present in Category list when there is less than 8 categories[/-][+][$500][MEDIUM] Categories: Search field is present in category list when there are fewer than 8 categories to choose from[/+]jasperhuangg commentedon Mar 1, 2024
Waiting for proposals
eucool commentedon Mar 1, 2024
akinwale commentedon Mar 4, 2024
I am unable to reproduce this. Seems it has already been fixed on main.
App/src/components/CategoryPicker.tsx
Line 67 in 4231ac9