Skip to content

[$500][MEDIUM] Categories: Search field is present in category list when there are fewer than 8 categories to choose from #37329

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.44-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

  • User is an employee of Collect workspace
  • The Collect workspace has less than 8 categories
  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Open request money page
  4. Create manual request and proceed to confirmation page
  5. Click Show more > Category

Expected Result:

There will be no search field because there are less than 8 categories

Actual Result:

Search field is present when there are less than 8 categories

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6394369_1709055952133.20240227-141548-1_kEAvasRf.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0110ba1eec3b905bcd
  • Upwork Job ID: 1762535661381767168
  • Last Price Increase: 2024-02-27

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 27, 2024
  2. changed the title [-]Category - Search field is present in Category list when there is less than 8 categories[/-] [+][$500] Category - Search field is present in Category list when there is less than 8 categories[/+] on Feb 27, 2024
  3. melvin-bot commented on Feb 27, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 27, 2024
  5. melvin-bot commented on Feb 27, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

  6. melvin-bot commented on Feb 27, 2024

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. github-actions commented on Feb 27, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. 7 remaining items

  9. eucool commented on Feb 27, 2024

    @eucool
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Search field is present in Category list when there is less than 8 categories

    What is the root cause of that problem?

    The variable name policyCategoriesCount is wrong:

    const isCategoriesCountBelowThreshold = policyCategoriesCount < CONST.CATEGORY_LIST_THRESHOLD;

    What changes do you think we should make in order to solve the problem?

    Replace the above with: policiesCount

    const policiesCount = OptionsListUtils.getEnabledCategoriesCount(_.values(policyCategories));

    What alternative solutions did you explore? (Optional)

    N/A

  10. puneetlath commented on Feb 27, 2024

    @puneetlath
    Contributor

    Definitely a bug, but doesn't need to block the deploy. Removing the label.

  11. changed the title [-][$500] Category - Search field is present in Category list when there is less than 8 categories[/-] [+][$500][MEDIUM] Categories: Search field is present in category list when there are fewer than 8 categories to choose from[/+] on Feb 27, 2024
  12. jasperhuangg commented on Mar 1, 2024

    @jasperhuangg
    Contributor

    Waiting for proposals

  13. eucool commented on Mar 1, 2024

    @eucool
    Contributor
  14. akinwale commented on Mar 4, 2024

    @akinwale
    Contributor

    I am unable to reproduce this. Seems it has already been fixed on main.

    const isCategoriesCountBelowThreshold = policiesCount < CONST.CATEGORY_LIST_THRESHOLD;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions