Skip to content

Add NewDot image preflight request caching #37431

Closed

Description

@Beamanator

Problem

#36560 (comment)

I believe I've identified the issue—the preflight response isn't being cached, resulting in its repeated execution with each image render. While the images themselves are cached, the browser is forced to reinitiate the preflight check due to the absence of caching headers. These headers are crucial as they instruct the browser on whether and how long to cache the preflight request.

  • a preflight request is being made even though the actual resource is cached
    image

Consequently, in offline scenarios, the browser is unable to perform the preflight request, leading to a failure in loading all images.

Here are some visuals to illustrate the point:

  • Image caching example (Notice how the GET response for the image is cached):
    Image caching example

  • Preflight request missing caching headers:
    Preflight request missing caching headers

Solution

To fix the issue in offline usage, and omit doing preflight request for cached items we should add some cache to the preflight response as well (this is a backend task)

cc @trjExpensify since you're helping coordinate this effort as BugZero

cc @kidroca since the above P / S was written by you 🙏

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d9de82c0447606ee
  • Upwork Job ID: 1762857975561478144
  • Last Price Increase: 2024-02-28

Activity

  1. melvin-bot commented on Feb 28, 2024

    @melvin-bot
  2. melvin-bot commented on Feb 28, 2024

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @eh2077 (Internal)

  3. self-assigned this
    on Feb 28, 2024
  4. trjExpensify commented on Feb 28, 2024

    @trjExpensify
    Contributor

    I'll self assign to BZ this one as well.

  5. justinpersaud commented on Mar 1, 2024

    @justinpersaud
    Contributor

    PR is up for review.

  6. removed their assignment
    on Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringInternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions