You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe I've identified the issue—the preflight response isn't being cached, resulting in its repeated execution with each image render. While the images themselves are cached, the browser is forced to reinitiate the preflight check due to the absence of caching headers. These headers are crucial as they instruct the browser on whether and how long to cache the preflight request.
a preflight request is being made even though the actual resource is cached
Consequently, in offline scenarios, the browser is unable to perform the preflight request, leading to a failure in loading all images.
Here are some visuals to illustrate the point:
Image caching example (Notice how the GET response for the image is cached):
Preflight request missing caching headers:
Solution
To fix the issue in offline usage, and omit doing preflight request for cached items we should add some cache to the preflight response as well (this is a backend task)
cc @trjExpensify since you're helping coordinate this effort as BugZero
cc @kidroca since the above P / S was written by you 🙏
Activity
melvin-bot commentedon Feb 28, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01d9de82c0447606ee
melvin-bot commentedon Feb 28, 2024
Triggered auto assignment to Contributor Plus for review of internal employee PR - @eh2077 (
Internal)trjExpensify commentedon Feb 28, 2024
I'll self assign to BZ this one as well.
justinpersaud commentedon Mar 1, 2024
PR is up for review.