You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-03-13] [HOLD for payment 2024-03-11] Profile - Date of birth opens Legal page #37597
Version Number: v1.4.46-0 Reproducible in staging?: Y Reproducible in production?: N Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to Account settings.
Go to Profile.
Click Date of birth.
Expected Result:
Date of birth page will open.
Actual Result:
Legal name page opens instead.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@cristipaval I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
changed the title [-]Profile - Date of birth opens Legal page[/-][+][HOLD for payment 2024-03-11] Profile - Date of birth opens Legal page[/+]on Mar 4, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@cristipaval] The PR that introduced the bug has been identified. Link to the PR:
[@cristipaval] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@cristipaval] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@cristipaval] Determine if we should create a regression test for this bug.
[@cristipaval] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-03-11] Profile - Date of birth opens Legal page[/-][+][HOLD for payment 2024-03-13] [HOLD for payment 2024-03-11] Profile - Date of birth opens Legal page[/+]on Mar 6, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@cristipaval] The PR that introduced the bug has been identified. Link to the PR:
[@cristipaval] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@cristipaval] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@cristipaval] Determine if we should create a regression test for this bug.
[@cristipaval] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Mar 1, 2024
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Mar 1, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 1, 2024
Triggered auto assignment to @cristipaval (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.izarutskaya commentedon Mar 1, 2024
@cristipaval I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
twisterdotcom commentedon Mar 1, 2024
Surely an external bug yeah. Let's throw it on, but would be good to know what this was introduced in.
37597.mp4
twisterdotcom commentedon Mar 1, 2024
No idea which of these is the culprit: #37578
19 remaining items
[-]Profile - Date of birth opens Legal page[/-][+][HOLD for payment 2024-03-11] Profile - Date of birth opens Legal page[/+]melvin-bot commentedon Mar 4, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 4, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-11. 🎊
melvin-bot commentedon Mar 4, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
hoangzinh commentedon Mar 5, 2024
I guess we can close this issue as no further action is required.
[-][HOLD for payment 2024-03-11] Profile - Date of birth opens Legal page[/-][+][HOLD for payment 2024-03-13] [HOLD for payment 2024-03-11] Profile - Date of birth opens Legal page[/+]melvin-bot commentedon Mar 6, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-13. 🎊
melvin-bot commentedon Mar 6, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: