Skip to content

[HOLD for payment 2024-03-13] [HOLD for payment 2024-03-11] Profile - Date of birth opens Legal page #37597

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.46-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Account settings.
  3. Go to Profile.
  4. Click Date of birth.

Expected Result:

Date of birth page will open.

Actual Result:

Legal name page opens instead.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6398174_1709293975666.bandicam_2024-03-01_07-51-50-080__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01576dd3bd294513f4
  • Upwork Job ID: 1763548635401383936
  • Last Price Increase: 2024-03-01

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 1, 2024
  2. melvin-bot commented on Mar 1, 2024

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. github-actions commented on Mar 1, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Mar 1, 2024

    @melvin-bot

    Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. izarutskaya commented on Mar 1, 2024

    @izarutskaya
    Author

    @cristipaval I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. twisterdotcom commented on Mar 1, 2024

    @twisterdotcom
    Contributor

    Surely an external bug yeah. Let's throw it on, but would be good to know what this was introduced in.

    37597.mp4
  7. twisterdotcom commented on Mar 1, 2024

    @twisterdotcom
    Contributor

    No idea which of these is the culprit: #37578

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 1, 2024
  9. 19 remaining items

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 4, 2024
  11. changed the title [-]Profile - Date of birth opens Legal page[/-] [+][HOLD for payment 2024-03-11] Profile - Date of birth opens Legal page[/+] on Mar 4, 2024
  12. melvin-bot commented on Mar 4, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Mar 4, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-11. 🎊

  14. melvin-bot commented on Mar 4, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@cristipaval] The PR that introduced the bug has been identified. Link to the PR:
    • [@cristipaval] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@cristipaval] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@cristipaval] Determine if we should create a regression test for this bug.
    • [@cristipaval] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. hoangzinh commented on Mar 5, 2024

    @hoangzinh
    Contributor

    I guess we can close this issue as no further action is required.

  16. changed the title [-][HOLD for payment 2024-03-11] Profile - Date of birth opens Legal page[/-] [+][HOLD for payment 2024-03-13] [HOLD for payment 2024-03-11] Profile - Date of birth opens Legal page[/+] on Mar 6, 2024
  17. melvin-bot commented on Mar 6, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-13. 🎊

  18. melvin-bot commented on Mar 6, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@cristipaval] The PR that introduced the bug has been identified. Link to the PR:
    • [@cristipaval] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@cristipaval] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@cristipaval] Determine if we should create a regression test for this bug.
    • [@cristipaval] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions