Skip to content

[HOLD for payment 2024-04-05] [$500] Settings - Preferences page is visible for a moment when navigate via text link in Focus Mode popup #37606

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.46-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): applausetester+jp_e_category@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #34069

Action Performed:

  1. Open New Expensify app.
  2. Login
  3. Popup appears
  4. Click on the text link “Settings”

Expected Result:

Priority mode page opens

Actual Result:

Preferences page is visible for a moment when navigate via text link in Focus Mode popup

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6398320_1709303268047.And_Chat_-_Popup_window_appears_that_can_t_close_tapping_outside.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0128371baf608716e9
  • Upwork Job ID: 1765238125791371264
  • Last Price Increase: 2024-03-06
  • Automatic offers:
    • DylanDylann | Reviewer | 0
    • tienifr | Contributor | 0

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 1, 2024
  2. melvin-bot commented on Mar 1, 2024

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. lanitochka17 commented on Mar 1, 2024

    @lanitochka17
    Author

    @JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. melvin-bot commented on Mar 4, 2024

    @melvin-bot

    @JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. melvin-bot commented on Mar 5, 2024

    @melvin-bot

    @JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  6. JmillsExpensify commented on Mar 6, 2024

    @JmillsExpensify
    Contributor

    I'm also not sure, so let's see what the community says.

  7. changed the title [-]Settings - Preferences page is visible for a moment when navigate via text link in Focus Mode popup[/-] [+][$500] Settings - Preferences page is visible for a moment when navigate via text link in Focus Mode popup[/+] on Mar 6, 2024
  8. melvin-bot commented on Mar 6, 2024

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 6, 2024
  10. 36 remaining items

  11. changed the title [-][$500] Settings - Preferences page is visible for a moment when navigate via text link in Focus Mode popup[/-] [+][HOLD for payment 2024-04-05] [$500] Settings - Preferences page is visible for a moment when navigate via text link in Focus Mode popup[/+] on Mar 29, 2024
  12. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-05. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
    • [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@DylanDylann] Determine if we should create a regression test for this bug.
    • [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. DylanDylann commented on Apr 10, 2024

    @DylanDylann
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
    [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
    [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
    [@DylanDylann] Determine if we should create a regression test for this bug. Yes
    [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal
    Pre-requisite: Using an account that enables focus mode

    1. Open New Expensify app.
    2. Login
    3. Popup appears
    4. Click on the text link “Settings”
    5. Verify that Preferences page is not visible and priority mode page opens

    Do we agree 👍 or 👎

  16. JmillsExpensify commented on Apr 11, 2024

    @JmillsExpensify
    Contributor

    Payment summary:

  17. JmillsExpensify commented on Apr 11, 2024

    @JmillsExpensify
    Contributor

    For the regression test, isn't there a pre-requisite that you're in focus mode? I don't quite understand how that's going to prevent this from being tested and happening again.

  18. DylanDylann commented on Apr 12, 2024

    @DylanDylann
    Contributor

    @JmillsExpensify Yeah, we should have a pre-requisite as you said. I updated

  19. JmillsExpensify commented on Apr 18, 2024

    @JmillsExpensify
    Contributor

    All contributors paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions