You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-04-05] [$500] Settings - Preferences page is visible for a moment when navigate via text link in Focus Mode popup #37606
Version Number: 1.4.46-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers):applausetester+jp_e_category@applause.expensifail.com Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Settings - Preferences page is visible for a moment when navigate via text link in Focus Mode popup[/-][+][$500] Settings - Preferences page is visible for a moment when navigate via text link in Focus Mode popup[/+]on Mar 6, 2024
changed the title [-][$500] Settings - Preferences page is visible for a moment when navigate via text link in Focus Mode popup[/-][+][HOLD for payment 2024-04-05] [$500] Settings - Preferences page is visible for a moment when navigate via text link in Focus Mode popup[/+]on Mar 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@DylanDylann] Determine if we should create a regression test for this bug.
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Pre-requisite: Using an account that enables focus mode
Open New Expensify app.
Login
Popup appears
Click on the text link “Settings”
Verify that Preferences page is not visible and priority mode page opens
For the regression test, isn't there a pre-requisite that you're in focus mode? I don't quite understand how that's going to prevent this from being tested and happening again.
Activity
melvin-bot commentedon Mar 1, 2024
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.lanitochka17 commentedon Mar 1, 2024
@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
melvin-bot commentedon Mar 4, 2024
@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Mar 5, 2024
@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
JmillsExpensify commentedon Mar 6, 2024
I'm also not sure, so let's see what the community says.
[-]Settings - Preferences page is visible for a moment when navigate via text link in Focus Mode popup[/-][+][$500] Settings - Preferences page is visible for a moment when navigate via text link in Focus Mode popup[/+]melvin-bot commentedon Mar 6, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0128371baf608716e9
36 remaining items
[-][$500] Settings - Preferences page is visible for a moment when navigate via text link in Focus Mode popup[/-][+][HOLD for payment 2024-04-05] [$500] Settings - Preferences page is visible for a moment when navigate via text link in Focus Mode popup[/+]melvin-bot commentedon Mar 29, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 29, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
DylanDylann commentedon Apr 10, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Pre-requisite: Using an account that enables focus mode
Do we agree 👍 or 👎
JmillsExpensify commentedon Apr 11, 2024
Payment summary:
JmillsExpensify commentedon Apr 11, 2024
For the regression test, isn't there a pre-requisite that you're in focus mode? I don't quite understand how that's going to prevent this from being tested and happening again.
DylanDylann commentedon Apr 12, 2024
@JmillsExpensify Yeah, we should have a pre-requisite as you said. I updated
JmillsExpensify commentedon Apr 18, 2024
All contributors paid