You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] Distance - Distance request thumbnail is different in reports when created offline #37638
Version Number: 1.4.46-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Go to staging.new.expensify.com
Go offline
Go to workspace chat
Create a distance request
Click on the expense preview
Click on the expense preview again
Expected Result:
The receipt preview for the distance request should be consistent in the main chat, expense report and transaction thread
Actual Result:
The receipt preview for the distance request is different in the main chat, expense report and transaction thread
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
that's because we have only svg icon of the route pending image that we are using for example here. we couldn't use Expensicons.EmptyStateRoutePendinghere and here. because of the type mismatch.
What changes do you think we should make in order to solve the problem?
we should add png version for route pending image
and use it as source when creating the optimisticReceipt here and when displaying the image here
changed the title [-][HOLD for payment 2024-06-18] [$500] Distance - Distance request thumbnail is different in reports when created offline[/-][+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] Distance - Distance request thumbnail is different in reports when created offline[/+]on Jun 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
Couldn't find the offending PR. We re-work the component to fix the issue and also replace the map pending thumbnail.
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
No need to create a discussion on the channel, because it seems only a time bug.
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Go to staging.new.expensify.com
Go offline
Go to workspace chat
Create a distance request
Verify on the report preview check that the pending map is displayed corresponding to the distance request created in (4) (instead of the receipt thumbnail)
Get back online and verify that the pending map is displayed (instead of the receipt thumbnail) until the map image from the server is returned
And once the map image is ready it should display the map image.
Create a distance request again
Verify on the report preview check a map is displayed corresponding to the distance request u created (instead of a receipt thumbnail)
Activity
melvin-bot commentedon Mar 1, 2024
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.lanitochka17 commentedon Mar 1, 2024
@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Mar 1, 2024
We think that this bug might be related to #wave5
CC @dylanexpensify
rayane-d commentedon Mar 1, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Distance request thumbnail is different in reports when created offline.
What is the root cause of that problem?
when creating the distance request we set an optimisticReceipt with source as ReceiptGeneric image here:
App/src/libs/actions/IOU.ts
Lines 992 to 995 in fc4297d
and we are using ReceiptGeneric also when displaying the receipt here:
App/src/libs/ReceiptUtils.ts
Line 37 in 93c66ce
that's because we have only svg icon of the route pending image that we are using for example here. we couldn't use
Expensicons.EmptyStateRoutePendinghere and here. because of the type mismatch.What changes do you think we should make in order to solve the problem?
we should add png version for route pending image
and use it as source when creating the optimisticReceipt here and when displaying the image here
gijoe0295 commentedon Mar 1, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Distance - Distance request thumbnail is different in reports when created offline
What is the root cause of that problem?
We display
ReceiptGenericon preview for distance request that is pending route from server:App/src/libs/ReceiptUtils.ts
Lines 37 to 39 in ea2bda2
But we use
EmptyStateRoutePendingicon for others.What changes do you think we should make in order to solve the problem?
We should add
pngimage forEmptyStateRoutePendingbecause it's currently just SVG.Then change
ReceiptGenericabove toEmptyStateRoutePendingfor consistency.What alternative solutions did you explore? (Optional)
NA
melvin-bot commentedon Mar 5, 2024
@garrettmknight Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Mar 5, 2024
@garrettmknight Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
74 remaining items
[-][HOLD for payment 2024-06-18] [$500] Distance - Distance request thumbnail is different in reports when created offline[/-][+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] Distance - Distance request thumbnail is different in reports when created offline[/+]melvin-bot commentedon Jun 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 13, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
garrettmknight commentedon Jun 20, 2024
Payment Summary:
@mollfpr can you finish the checklist when you get a chance?
mollfpr commentedon Jun 22, 2024
Couldn't find the offending PR. We re-work the component to fix the issue and also replace the map pending thumbnail.
No need to create a discussion on the channel, because it seems only a time bug.
JmillsExpensify commentedon Jun 22, 2024
$500 approved for @mollfpr
garrettmknight commentedon Jun 24, 2024
All set here