You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Android-Required label appears when create request even People must tag expenses is disabled #37645
Version Number: 1.4.46-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers):applausetester+gmcategory2@applause.expensifail.com Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Precondition:
User is an employee of Collect workspace on Old Dot
"People must tag expenses" option is disabled by Admin
As employee navigate to Workspace chat> +> Request money> Manual
Add amount> Click Next
Take a note of Final confirmation page
Expected Result:
Since Admin has disable "People must tag expenses" option - Employee should not see Required label on Tag section
Actual Result:
"Required" label is present on Tag section when Employee create request, even "People must tag expenses" is disabled by admin
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@francoisl FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
I'm unable to repro, I'm thinking it might have been a delayed notification being sent to the Android client after you disabled the tag requirement in the workspace on OldDot. The code for that page also hasn't changed in a while.
Activity
github-actions commentedon Mar 1, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 1, 2024
Triggered auto assignment to @francoisl (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Mar 1, 2024
@francoisl FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Mar 1, 2024
We think that this bug might be related to #wave6
CC @greg-schroeder
francoisl commentedon Mar 1, 2024
I'm unable to repro, I'm thinking it might have been a delayed notification being sent to the Android client after you disabled the tag requirement in the workspace on OldDot. The code for that page also hasn't changed in a while.
gh37645.mov
francoisl commentedon Mar 5, 2024
Can't repro on v1.4.47-6 either, closing for now.