You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-04-05] HIGH: [Video] [$500] Can not pause or play video on full screen mode #37803
Version Number: 1.4.47-6 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail:vdargentotest+web030424@gmail.comhttps://expensify.testrail.io/index.php?/tests/view/4378376 Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Pre-requisite: the user must be logged in
Go to any chat
Send a video
Open it on full screen mode (important step)
Click on the video to play or pause
Verify the video is not played or paused
Expected Result:
The video should be played or paused when clicked on it
Actual Result:
The video does not play or pause when the user clicks on it
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Please re-state the problem that we are trying to solve in this issue.
Can not pause or play video on full screen mode.
What is the root cause of that problem?
For full screen mode, play and pause methods are being called from two places - togglePlayCurrentVideo and the internal implementation of full screen video player in av-expo.
For non-fullscreen view, we have custom logic in togglePlayCurrentVideo, but that is not needed for the full screen view.
What changes do you think we should make in order to solve the problem?
In togglePlayCurrentVideo, there should be a check for full screen mode. If video is playing in full screen mode, then play and pause should not be called from that method since that is already being handled by av-expo's full screen APIs.
A state called isFullscreen can be created (actual code can be more polished):
changed the title [-]HIGH: [Video] [$500] Can not pause or play video on full screen mode[/-][+][HOLD for payment 2024-04-05] HIGH: [Video] [$500] Can not pause or play video on full screen mode[/+]on Mar 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@sobitneupane] Determine if we should create a regression test for this bug.
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Mar 5, 2024
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.lanitochka17 commentedon Mar 5, 2024
We think that this bug might be related to #vip-vsp
CC @quinthar
lanitochka17 commentedon Mar 5, 2024
@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
dylanexpensify commentedon Mar 6, 2024
Apologies, I've been OOO sick, but getting to this today!
ShridharGoel commentedon Mar 7, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Can not pause or play video on full screen mode.
What is the root cause of that problem?
For full screen mode, play and pause methods are being called from two places -
togglePlayCurrentVideoand the internal implementation of full screen video player inav-expo.For non-fullscreen view, we have custom logic in
togglePlayCurrentVideo, but that is not needed for the full screen view.App/src/components/VideoPlayer/BaseVideoPlayer.js
Lines 65 to 74 in 86a9904
What changes do you think we should make in order to solve the problem?
In
togglePlayCurrentVideo, there should be a check for full screen mode. If video is playing in full screen mode, then play and pause should not be called from that method since that is already being handled by av-expo's full screen APIs.A state called
isFullscreencan be created (actual code can be more polished):This logic to update fullscreen status can be added in
handleFullscreenUpdate:Screen.Recording.2024-03-07.at.1.04.53.PM.mov
Optional
If we want to toggle full screen mode on long press or double tap, we can include that.
Then, inside
PressableWithoutFeedbackinBaseVideoPlayer, include onLongPress:Double tap can be handled using gestures.
dylanexpensify commentedon Mar 8, 2024
Posted here to confirm in vsb!
dylanexpensify commentedon Mar 11, 2024
Agreed, HIGH!
42 remaining items
[-]HIGH: [Video] [$500] Can not pause or play video on full screen mode[/-][+][HOLD for payment 2024-04-05] HIGH: [Video] [$500] Can not pause or play video on full screen mode[/+]melvin-bot commentedon Mar 29, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 29, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
dylanexpensify commentedon Apr 9, 2024
Payment summary:
Please apply/request!
dylanexpensify commentedon Apr 9, 2024
Done!
JmillsExpensify commentedon Apr 11, 2024
$500 approved for @sobitneupane