You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[CRITICAL] [VIP-Travel] Create workspace address page and section in overview #37827
This issue is for creating the new workspace address page:
A new MenuItemWithTopDescription will be added to WorkspaceOverviewPage to display the Company address as shown above. On click, it’ll open WorkspaceOverviewAddressPage.
A new page, WorkspaceOverviewAddressPage will be created, with a new route, ROUTES.WORKSPACE_PROFILE_ADDRESS. It will mostly mimic AddressPage.js with a couple of changes:
Instead of receiving the user’s personal details, it’ll receive the workspace data, including the address.
The PHP layer will be updated to receive the new command in api.php, and it will call a new function, PolicyAPI::updateWorkspaceAddress, which, in turn, will call a new Auth command.. [WIP]
changed the title [-][CRITICAL] [VIP-Travel] Create new Trip Room[/-][+][CRITICAL] [VIP-Travel] Create workspace address page and section in overview[/+]on Mar 6, 2024
Activity
[-][CRITICAL] [VIP-Travel] Create new Trip Room[/-][+][CRITICAL] [VIP-Travel] Create workspace address page and section in overview[/+]smelaa commentedon Mar 8, 2024
Hello, I'm Aleksandra from Software Mansion, the expert agency, and I'd like to work on this issue.
twisterdotcom commentedon Mar 8, 2024
Adding a C+ here for Travel reviews: @shubham1206agra
twisterdotcom commentedon Mar 11, 2024
Only assigned on Friday. We can give them a day here Melvin.
smelaa commentedon Mar 13, 2024
Hi,
Could you please let me know under which prop can I find that address? Is it already implemented?
stitesExpensify commentedon Mar 13, 2024
The address is not implemented yet. It will be a field on the policy object
36 remaining items
melvin-bot commentedon Apr 29, 2024
Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
melvin-bot commentedon May 2, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon May 2, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon May 2, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
lakchote commentedon May 3, 2024
cc @smelaa looks like a lot of blockers are related to it
shubham1206agra commentedon May 3, 2024
@lakchote This feature is behind beta. So you can remove the deploy blocker label from them.
twisterdotcom commentedon May 15, 2024
This is already live!
shubham1206agra commentedon May 15, 2024
@twisterdotcom This issue still requires payment.
twisterdotcom commentedon May 15, 2024
Ah! Didn't realise this was linked to a PR, thought it was one of those handled in another issue. Found it: #38381
twisterdotcom commentedon May 15, 2024
Payment Summary: