Skip to content

[CRITICAL] [VIP-Travel] Create workspace address page and section in overview #37827

Closed

Description

@stitesExpensify

VIP-Travel Implementation Issue

Tracking Issue: https://github.com/Expensify/Expensify/issues/333471
Project: [#whatsnext] #Travel
Relevant Design Doc Section: https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.9gtuxny77xql

This issue is for creating the new workspace address page:
2024-03-06_08-42-12

  • A new MenuItemWithTopDescription will be added to WorkspaceOverviewPage to display the Company address as shown above. On click, it’ll open WorkspaceOverviewAddressPage.
  • A new page, WorkspaceOverviewAddressPage will be created, with a new route, ROUTES.WORKSPACE_PROFILE_ADDRESS. It will mostly mimic AddressPage.js with a couple of changes:
  • Instead of receiving the user’s personal details, it’ll receive the workspace data, including the address.
  • Instead of calling PersonalDetails.UpdateAddress, it will call a new function, Policy.updateAddress.
    Policy.updateAddress will behave much like Policy.updateWorkspaceCustomUnitAndRate, but it will call a new command, UpdateWorkspaceAddress.
  • The PHP layer will be updated to receive the new command in api.php, and it will call a new function, PolicyAPI::updateWorkspaceAddress, which, in turn, will call a new Auth command.. [WIP]
  • The current Policy.updateGeneralSettings… [WIP]

Routes table:
https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.gn6jbl2udlnx

Activity

  1. changed the title [-][CRITICAL] [VIP-Travel] Create new Trip Room[/-] [+][CRITICAL] [VIP-Travel] Create workspace address page and section in overview[/+] on Mar 6, 2024
  2. smelaa commented on Mar 8, 2024

    @smelaa
    Contributor

    Hello, I'm Aleksandra from Software Mansion, the expert agency, and I'd like to work on this issue.

  3. twisterdotcom commented on Mar 8, 2024

    @twisterdotcom
    Contributor

    Adding a C+ here for Travel reviews: @shubham1206agra

  4. twisterdotcom commented on Mar 11, 2024

    @twisterdotcom
    Contributor

    Only assigned on Friday. We can give them a day here Melvin.

  5. smelaa commented on Mar 13, 2024

    @smelaa
    Contributor

    Hi,

    Instead of receiving the user’s personal details, it’ll receive the workspace data, including the address.

    Could you please let me know under which prop can I find that address? Is it already implemented?

  6. stitesExpensify commented on Mar 13, 2024

    @stitesExpensify
    ContributorAuthor

    The address is not implemented yet. It will be a field on the policy object

  7. 36 remaining items

  8. melvin-bot commented on Apr 29, 2024

    @melvin-bot

    Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  9. melvin-bot commented on May 2, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  10. melvin-bot commented on May 2, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. melvin-bot commented on May 2, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  12. lakchote commented on May 3, 2024

    @lakchote
    Contributor

    cc @smelaa looks like a lot of blockers are related to it

  13. shubham1206agra commented on May 3, 2024

    @shubham1206agra
    Contributor

    @lakchote This feature is behind beta. So you can remove the deploy blocker label from them.

  14. twisterdotcom commented on May 15, 2024

    @twisterdotcom
    Contributor

    This is already live!

  15. moved this from Critical - V1 to Done in [#whatsnext] #Travelon May 15, 2024
  16. shubham1206agra commented on May 15, 2024

    @shubham1206agra
    Contributor

    @twisterdotcom This issue still requires payment.

  17. twisterdotcom commented on May 15, 2024

    @twisterdotcom
    Contributor

    Ah! Didn't realise this was linked to a PR, thought it was one of those handled in another issue. Found it: #38381

  18. twisterdotcom commented on May 15, 2024

    @twisterdotcom
    Contributor

    Payment Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions