You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-04-05] [$500] mentioning a user from a different domain with same "front part" of the email address as logged in account causes the mention render as you #38074
changed the title [-]mentioning a user from a different domain with same "front part" of the email address as logged in account causes the mention render as you[/-][+][$500] mentioning a user from a different domain with same "front part" of the email address as logged in account causes the mention render as you[/+]on Mar 11, 2024
Could not reproduce this using two emails with the same "front part" of the email. My email addresses did not have a sub-domain name like the report does and I have no way to create an email with a sub-domain.
I am able to reproduce with creating an account in old expensify since it doesn't require email verification.
I created jeremycroff@sub1.gmail.com
Anytime I tag @jeremycroff@anything.com it shows the shortened part followed by the remainder.
This is how we are saving it:
However it's a regression from: #36697 which was deployed to prod 5 days ago. Should we still propose @situchan?
The code is naively saying if the first part + current user email exists in contact list then it's a short text we need to expand.
But we should also compare if the second part the users' email does not equal the last part.
I am OOO from the 21st to 31st of March, but I don't think this needs reassigning, as it's a regression and no payment is needed. Please let me know if I am incorrect though!
changed the title [-][$500] mentioning a user from a different domain with same "front part" of the email address as logged in account causes the mention render as you[/-][+][HOLD for payment 2024-04-05] [$500] mentioning a user from a different domain with same "front part" of the email address as logged in account causes the mention render as you[/+]on Mar 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allroundexperts] Determine if we should create a regression test for this bug.
[@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Mar 11, 2024
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Mar 11, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01c23b4f231f3691d1
[-]mentioning a user from a different domain with same "front part" of the email address as logged in account causes the mention render as you[/-][+][$500] mentioning a user from a different domain with same "front part" of the email address as logged in account causes the mention render as you[/+]melvin-bot commentedon Mar 11, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (
External)garatkarr commentedon Mar 11, 2024
Could not reproduce this using two emails with the same "front part" of the email. My email addresses did not have a sub-domain name like the report does and I have no way to create an email with a sub-domain.
jeremy-croff commentedon Mar 12, 2024
I am able to reproduce with creating an account in old expensify since it doesn't require email verification.
I created jeremycroff@sub1.gmail.com
Anytime I tag @jeremycroff@anything.com it shows the shortened part followed by the remainder.
This is how we are saving it:

However it's a regression from: #36697 which was deployed to prod 5 days ago. Should we still propose @situchan?
The code is naively saying if the first part + current user email exists in contact list then it's a short text we need to expand.
But we should also compare if the second part the users' email does not equal the last part.
jliexpensify commentedon Mar 12, 2024
If it's a regression, it should go to @tienifr and @allroundexperts
jliexpensify commentedon Mar 12, 2024
@situchan let me know if @jeremy-croff is correct and I can get this assigned to them
14 remaining items
jliexpensify commentedon Mar 19, 2024
I am OOO from the 21st to 31st of March, but I don't think this needs reassigning, as it's a regression and no payment is needed. Please let me know if I am incorrect though!
[-][$500] mentioning a user from a different domain with same "front part" of the email address as logged in account causes the mention render as you[/-][+][HOLD for payment 2024-04-05] [$500] mentioning a user from a different domain with same "front part" of the email address as logged in account causes the mention render as you[/+]melvin-bot commentedon Mar 29, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 29, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
jliexpensify commentedon Mar 31, 2024
As per my comment here, I don't think payment is needed but lmk if I am wrong!
@allroundexperts any need for a checklist?
jliexpensify commentedon Apr 5, 2024
Bump @allroundexperts - any checklist needed here?
melvin-bot commentedon Apr 5, 2024
Payment Summary
Upwork Job
BugZero Checklist (@jliexpensify)
jliexpensify commentedon Apr 7, 2024
This is a regression from another PR so no payment needed.