Skip to content

[HOLD for payment 2024-04-05] [$500] mentioning a user from a different domain with same "front part" of the email address as logged in account causes the mention render as you #38074

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.50-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710094172947319

Action Performed:

  1. Have same front part of the email address in 2 different domain (applausetester+mn1003@applause.expensifail.com and applausetester+mn1003@applause2fa.expensifail.com)
  2. Sign in as applausetester+mn1003@applause.expensifail.com
  3. Go to any chat and mention applausetester+mn1003@applause2fa.expensifail.com

Expected Result:

mentioned user shouldn't be highlighted in green

Actual Result:

mentioned user highlighted in green to incorrectly render as the logged in account

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen Shot 2024-03-11 at 2 20 43 PM

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c23b4f231f3691d1
  • Upwork Job ID: 1767259879670747136
  • Last Price Increase: 2024-03-11

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 11, 2024
  2. melvin-bot commented on Mar 11, 2024

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 11, 2024
  4. melvin-bot commented on Mar 11, 2024

    @melvin-bot
  5. changed the title [-]mentioning a user from a different domain with same "front part" of the email address as logged in account causes the mention render as you[/-] [+][$500] mentioning a user from a different domain with same "front part" of the email address as logged in account causes the mention render as you[/+] on Mar 11, 2024
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 11, 2024
  7. melvin-bot commented on Mar 11, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

  8. garatkarr commented on Mar 11, 2024

    @garatkarr

    Could not reproduce this using two emails with the same "front part" of the email. My email addresses did not have a sub-domain name like the report does and I have no way to create an email with a sub-domain.

  9. jeremy-croff commented on Mar 12, 2024

    @jeremy-croff
    Contributor

    I am able to reproduce with creating an account in old expensify since it doesn't require email verification.
    I created jeremycroff@sub1.gmail.com
    Anytime I tag @jeremycroff@anything.com it shows the shortened part followed by the remainder.

    This is how we are saving it:
    Screenshot 2024-03-11 at 6 2 Screenshot 2024-03-11 at 6 55 29 PM 4 36 PM

    However it's a regression from: #36697 which was deployed to prod 5 days ago. Should we still propose @situchan?

    The code is naively saying if the first part + current user email exists in contact list then it's a short text we need to expand.
    But we should also compare if the second part the users' email does not equal the last part.

  10. jliexpensify commented on Mar 12, 2024

    @jliexpensify
    Contributor

    If it's a regression, it should go to @tienifr and @allroundexperts

  11. jliexpensify commented on Mar 12, 2024

    @jliexpensify
    Contributor

    @situchan let me know if @jeremy-croff is correct and I can get this assigned to them

  12. 14 remaining items

  13. jliexpensify commented on Mar 19, 2024

    @jliexpensify
    Contributor

    I am OOO from the 21st to 31st of March, but I don't think this needs reassigning, as it's a regression and no payment is needed. Please let me know if I am incorrect though!

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 29, 2024
  15. changed the title [-][$500] mentioning a user from a different domain with same "front part" of the email address as logged in account causes the mention render as you[/-] [+][HOLD for payment 2024-04-05] [$500] mentioning a user from a different domain with same "front part" of the email address as logged in account causes the mention render as you[/+] on Mar 29, 2024
  16. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-05. 🎊

    For reference, here are some details about the assignees on this issue:

    • @allroundexperts requires payment through NewDot Manual Requests
    • @tienifr requires payment (Needs manual offer from BZ)
  18. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
    • [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@allroundexperts] Determine if we should create a regression test for this bug.
    • [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  19. jliexpensify commented on Mar 31, 2024

    @jliexpensify
    Contributor

    As per my comment here, I don't think payment is needed but lmk if I am wrong!

    @allroundexperts any need for a checklist?

  20. jliexpensify commented on Apr 5, 2024

    @jliexpensify
    Contributor

    Bump @allroundexperts - any checklist needed here?

  21. melvin-bot commented on Apr 5, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@jliexpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1767259879670747136/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  22. jliexpensify commented on Apr 7, 2024

    @jliexpensify
    Contributor

    This is a regression from another PR so no payment needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions