You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-04-15] [$250] [SelectionList refactor] [Wave Collect] Extract checkbox design and placing outside the BaseListItem component to specific list item components. #38222
Coming from this issue: #35717 and discussed it on Slack.
We recently refactored the SelectionList component extracting list item components like UserListItem, RadioListItem and TableListItem and asking the parent component to decide which list item component should be used by the SelectionList. There is also a BaseListItem component used by all of these newly extracted item components that holds some common part of the code.
Unfortunately this component still encapsulate how the checkbox used in the list item looks like and where it's placed, so the goal of this issue is to extract defining checkbox outside the BaseListItem and move this responsibility to specific list item components.
Version Number: Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Slack conversation:
Action Performed:
Break down in numbered steps
Expected Result:
Describe what you think should've happened
Actual Result:
Describe what actually happened
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-][SelectionList refactor] Extract checkbox design and placing outside the BaseListItem component to specific list item components.[/-][+][$500] [SelectionList refactor] Extract checkbox design and placing outside the BaseListItem component to specific list item components.[/+]on Mar 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@DylanDylann] Determine if we should create a regression test for this bug.
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
Activity
melvin-bot commentedon Mar 13, 2024
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.[-][SelectionList refactor] Extract checkbox design and placing outside the BaseListItem component to specific list item components.[/-][+][$500] [SelectionList refactor] Extract checkbox design and placing outside the BaseListItem component to specific list item components.[/+]melvin-bot commentedon Mar 13, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01e7cfec47d64461f0
melvin-bot commentedon Mar 13, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (
External)27 remaining items
melvin-bot commentedon Apr 8, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-15. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 8, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
shubham1206agra commentedon Apr 8, 2024
Please assign me here as PR author.
melvin-bot commentedon Apr 8, 2024
📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
mountiny commentedon Apr 8, 2024
$250 to both @shubham1206agra and @DylanDylann
Christinadobrzyn commentedon Apr 11, 2024
Prepping payouts.
Upwork job is here.
@shubham1206agra please accept the above offer in Upwork, thanks!
Christinadobrzyn commentedon Apr 16, 2024
Paid @DylanDylann based on this payment summary - #38222 (comment)
Waiting for @shubham1206agra to accept the Upwork offer
@DylanDylann do we need a regression test?
DylanDylann commentedon Apr 16, 2024
@Christinadobrzyn I don't think we need a regression test for this issue because this is a refactor task
Christinadobrzyn commentedon Apr 17, 2024
DM'd @shubham1206agra about the upwork offer
Christinadobrzyn commentedon Apr 17, 2024
Awesome! Paid this out based on this payment summary - #38222 (comment)
closing - let me know if I missed anything!