Skip to content

[HOLD for payment 2024-04-15] [$250] [SelectionList refactor] [Wave Collect] Extract checkbox design and placing outside the BaseListItem component to specific list item components. #38222

Closed

Description

@burczu

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Coming from this issue: #35717 and discussed it on Slack.

We recently refactored the SelectionList component extracting list item components like UserListItem, RadioListItem and TableListItem and asking the parent component to decide which list item component should be used by the SelectionList. There is also a BaseListItem component used by all of these newly extracted item components that holds some common part of the code.

Unfortunately this component still encapsulate how the checkbox used in the list item looks like and where it's placed, so the goal of this issue is to extract defining checkbox outside the BaseListItem and move this responsibility to specific list item components.


Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

Break down in numbered steps

Expected Result:

Describe what you think should've happened

Actual Result:

Describe what actually happened

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e7cfec47d64461f0
  • Upwork Job ID: 1767895235204546560
  • Last Price Increase: 2024-03-13
  • Automatic offers:
    • DylanDylann | Contributor | 0
    • shubham1206agra | Contributor | 0
Issue OwnerCurrent Issue Owner: @Christinadobrzyn

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 13, 2024
  2. melvin-bot commented on Mar 13, 2024

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collecton Mar 13, 2024
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 13, 2024
  5. changed the title [-][SelectionList refactor] Extract checkbox design and placing outside the BaseListItem component to specific list item components.[/-] [+][$500] [SelectionList refactor] Extract checkbox design and placing outside the BaseListItem component to specific list item components.[/+] on Mar 13, 2024
  6. melvin-bot commented on Mar 13, 2024

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 13, 2024
  8. melvin-bot commented on Mar 13, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

  9. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 13, 2024
  10. 27 remaining items

  11. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-15. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
    • [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@DylanDylann] Determine if we should create a regression test for this bug.
    • [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. shubham1206agra commented on Apr 8, 2024

    @shubham1206agra
    Contributor

    Please assign me here as PR author.

  14. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  15. mountiny commented on Apr 8, 2024

    @mountiny
    Contributor
  16. Christinadobrzyn commented on Apr 11, 2024

    @Christinadobrzyn
    Contributor

    Prepping payouts.

    Upwork job is here.

    @shubham1206agra please accept the above offer in Upwork, thanks!

  17. Christinadobrzyn commented on Apr 16, 2024

    @Christinadobrzyn
    Contributor

    Paid @DylanDylann based on this payment summary - #38222 (comment)

    Waiting for @shubham1206agra to accept the Upwork offer

    @DylanDylann do we need a regression test?

  18. DylanDylann commented on Apr 16, 2024

    @DylanDylann
    Contributor

    @Christinadobrzyn I don't think we need a regression test for this issue because this is a refactor task

  19. Christinadobrzyn commented on Apr 17, 2024

    @Christinadobrzyn
    Contributor

    DM'd @shubham1206agra about the upwork offer

  20. Christinadobrzyn commented on Apr 17, 2024

    @Christinadobrzyn
    Contributor

    Awesome! Paid this out based on this payment summary - #38222 (comment)

    closing - let me know if I missed anything!

  21. moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collecton Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions