Skip to content

[HOLD for payment 2024-03-25] Profile avatar is not aligned within highlighted circle #38263

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.52-0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition: Device font size is minimum.

  1. Launch New Expensify app.
  2. Go to Profile.

Expected Result:

Profile avatar is aligned within highlighted circle

Actual Result:

Profile avatar is not aligned within highlighted circle
Reproducible in SG Note 10+ / Android 12 , SG Z Fold 4 / Android 14,iPhone 15 Pro Max / iOS 17.3.1

Workaround:

visual

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6412856_1710369724081!Screenshot_20240314_042548_New_Expensify

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016e3c16578ce4b6d1
  • Upwork Job ID: 1768105574093357056
  • Last Price Increase: 2024-03-14

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 14, 2024
  2. melvin-bot commented on Mar 14, 2024

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. github-actions commented on Mar 14, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Mar 14, 2024

    @melvin-bot

    Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 14, 2024
  6. robertjchen commented on Mar 14, 2024

    @robertjchen
    Contributor

    Not a deploy blocker. Opening for External Contributors

  7. 18 remaining items

  8. removed their assignment
    on Mar 14, 2024
  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 18, 2024
  10. changed the title [-]Profile avatar is not aligned within highlighted circle[/-] [+][HOLD for payment 2024-03-25] Profile avatar is not aligned within highlighted circle[/+] on Mar 18, 2024
  11. melvin-bot commented on Mar 18, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Mar 18, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-25. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mkhutornyi requires payment (Needs manual offer from BZ)
    • @kosmydel does not require payment (Contractor)
  13. melvin-bot commented on Mar 18, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mkhutornyi] The PR that introduced the bug has been identified. Link to the PR:
    • [@mkhutornyi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mkhutornyi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mkhutornyi] Determine if we should create a regression test for this bug.
    • [@mkhutornyi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. kosmydel commented on Mar 19, 2024

    @kosmydel
    Contributor

    This one is related to #38463.

  15. twisterdotcom commented on Mar 25, 2024

    @twisterdotcom
    Contributor

    Payment Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions